Bug fix and rationalization of Boards/Libs installer GUI #4362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getTableCellRendererComponent() interface requires to return independent Component objects used for "stamping" the table element.
…derer This is in preparation for the next refactoring.
This rationalization helps to better follow the swing abstractions of table models and increase separation of concerns. (WIP: ContributedPlatforms needs a similar refactoring that will be done in the next commits)
This commit completes the refactoring
cmaglie
added
feature request
Contributor
Contributor
|
I tested the following on OS X 10.11.1, and observed no issues:
|
cmaglie
changed the title
Member
Author
|
I've tested on Windows 10 and OS X 10.10 as well. I'm going to merge this one so it becomes available through hourly-builds. The deadlock on linux seems related to the recent update of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a deadlock experienced on some recent linux distros and rationalize the code of the Boards and Libraries installers GUI.
Tested on linux. To be tested on Mac & Windows.