Make SD library board agnostic #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than redefining everything.
ghost
assigned
cmaglie
added
feature request
Collaborator
|
This commit looks good to me. I haven't checked it thoroughly or tested it, but the diff looks fine. |
Member
Member
|
Ok, it seems that we called victory too fast: as @PaulStoffregen pointed out (05a9750#commitcomment-15657902) this patch has a big performance impact, so I'm reverting for now, until we find a better way to improve optimization of pin-mapping macros (at least when the argument is a constant known at compile-time). PS: @JasonSheng I've merged your patch in the meantime, sorry for the confusion! |
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
Updated Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Sd2PinMap.h to use the pin mapping defined in the variant header pins_arduino.h (instead of redefining everything).
This small change makes the SD library compatible with any board that has a variant defined.
The library was tested successfully for both read and write using both the hardware SPI and the soft SPI.
PS.
This pull request replaces pull request #117. The content is the same, but now neatly grouped in a single commit.