Fix SerialMonitor and SerialPlotter lifecycles

Fixes #7683

When the selected serial port is busy both monitors now avoid displaying a useless window, cleaning the status area once the open succeeds.

Author: facchinm

app/src/processing/app/Editor.java

@@ -2409,11 +2409,12 @@ public void handleSerial() {
       }
 
       try {
-        serialMonitor.setVisible(true);
         if (!avoidMultipleOperations) {
           serialMonitor.open();
         }
+        serialMonitor.setVisible(true);
         success = true;
+        statusEmpty();
       } catch (ConnectException e) {
         statusError(tr("Unable to connect: is the sketch using the bridge?"));
       } catch (JSchException e) {
@@ -2423,6 +2424,7 @@ public void handleSerial() {
         if (e.getCause() != null && e.getCause() instanceof SerialPortException) {
           errorMessage += " (" + ((SerialPortException) e.getCause()).getExceptionType() + ")";
         }
+        serialMonitor = null;
         statusError(errorMessage);
         try {
           serialMonitor.close();
@@ -2432,12 +2434,12 @@ public void handleSerial() {
       } catch (Exception e) {
         statusError(e);
       } finally {
-        if (serialMonitor.requiresAuthorization() && !success) {
+        if (serialMonitor != null && serialMonitor.requiresAuthorization() && !success) {
           PreferencesData.remove(serialMonitor.getAuthorizationKey());
         }
       }
 
-    } while (serialMonitor.requiresAuthorization() && !success);
+    } while (serialMonitor != null && serialMonitor.requiresAuthorization() && !success);
 
   }
 
@@ -2457,6 +2459,7 @@ public void handlePlotter() {
       if (serialPlotter.isClosed()) {
         // If it's closed, clear the refrence to the existing
         // plotter and create a new one
+        serialPlotter.dispose();
         serialPlotter = null;
       }
       else {
@@ -2510,6 +2513,7 @@ public void handlePlotter() {
         serialPlotter.open();
         serialPlotter.setVisible(true);
         success = true;
+        statusEmpty();
       } catch (ConnectException e) {
         statusError(tr("Unable to connect: is the sketch using the bridge?"));
       } catch (JSchException e) {
@@ -2520,15 +2524,16 @@ public void handlePlotter() {
           errorMessage += " (" + ((SerialPortException) e.getCause()).getExceptionType() + ")";
         }
         statusError(errorMessage);
+        serialPlotter = null;
       } catch (Exception e) {
         statusError(e);
       } finally {
-        if (serialPlotter.requiresAuthorization() && !success) {
+        if (serialPlotter != null && serialPlotter.requiresAuthorization() && !success) {
           PreferencesData.remove(serialPlotter.getAuthorizationKey());
         }
       }
 
-    } while (serialPlotter.requiresAuthorization() && !success);
+    } while (serialPlotter != null && serialPlotter.requiresAuthorization() && !success);
 
   }