Block discovery threads until packages is not null, otherwise boards discovered during startup will miss model name

Author: Federico Fissore

arduino-core/src/cc/arduino/packages/discoverers/NetworkDiscovery.java

@@ -45,6 +45,8 @@
 
 public class NetworkDiscovery implements Discovery, ServiceListener, cc.arduino.packages.discoverers.network.NetworkTopologyListener {
 
+  private static final int MAX_TIME_AWAITING_FOR_PACKAGES = 5000;
+
   private final List<BoardPort> boardPortsDiscoveredWithJmDNS;
   private final Map<InetAddress, JmDNS> mappedJmDNSs;
   private Timer networkCheckerTimer;
@@ -121,6 +123,16 @@ public void serviceRemoved(ServiceEvent serviceEvent) {
 
   @Override
   public void serviceResolved(ServiceEvent serviceEvent) {
+    int sleptFor = 0;
+    while (BaseNoGui.packages == null && sleptFor <= MAX_TIME_AWAITING_FOR_PACKAGES) {
+      try {
+        Thread.sleep(1000);
+        sleptFor += 1000;
+      } catch (InterruptedException e) {
+        e.printStackTrace();
+      }
+    }
+
     ServiceInfo info = serviceEvent.getInfo();
     for (InetAddress inetAddress : info.getInet4Addresses()) {
       String address = inetAddress.getHostAddress();

arduino-core/src/cc/arduino/packages/discoverers/serial/SerialBoardsLister.java

@@ -43,6 +43,8 @@
 
 public class SerialBoardsLister extends TimerTask {
 
+  private static final int MAX_TIME_AWAITING_FOR_PACKAGES = 5000;
+
   private final SerialDiscovery serialDiscovery;
 
   public SerialBoardsLister(SerialDiscovery serialDiscovery) {
@@ -55,8 +57,14 @@ public void start(Timer timer) {
 
   @Override
   public void run() {
-    if (BaseNoGui.packages == null) {
-      return;
+    int sleptFor = 0;
+    while (BaseNoGui.packages == null && sleptFor <= MAX_TIME_AWAITING_FOR_PACKAGES) {
+      try {
+        Thread.sleep(1000);
+        sleptFor += 1000;
+      } catch (InterruptedException e) {
+        e.printStackTrace();
+      }
     }
 
     Platform platform = BaseNoGui.getPlatform();