Fix Codacy checks

Author: Joe Wegner

app/src/cc/arduino/contributions/ContributionsSelfCheck.java

@@ -36,6 +36,7 @@
 import cc.arduino.contributions.packages.filters.UpdatablePlatformPredicate;
 import cc.arduino.view.NotificationPopup;
 import com.sun.javafx.binding.Logging;
+import org.apache.logging.log4j.LogManager;
 import processing.app.*;
 
 import javax.swing.*;
@@ -178,7 +179,7 @@ private void goToManager(String link) {
       ((UpdatableBoardsLibsFakeURLsHandler) hyperlinkListener).openBoardLibManager(new URL(link));
     }
       catch (Exception e){
-        Logging.getLogger().warning("Exception while attempting to go to board manager", e);
+        LogManager.getLogger(ContributionsSelfCheck.class).warn("Exception while attempting to go to board manager", e);
     }
   }
   // callback for boards button

app/src/cc/arduino/view/NotificationPopup.java

@@ -58,15 +58,15 @@
 import static processing.app.I18n.tr;
 
 public class NotificationPopup extends JDialog {
+  private Timer autoCloseTimer = new Timer(false);
+  private boolean autoClose = true;
+  private OptionalButtonCallbacks optionalButtonCallbacks;
+
   public interface OptionalButtonCallbacks {
     void onOptionalButton1Callback();
     void onOptionalButton2Callback();
   }
 
-  private Timer autoCloseTimer = new Timer(false);
-  private boolean autoClose = true;
-  private OptionalButtonCallbacks optionalButtonCallbacks;
-
   public NotificationPopup(Frame parent, HyperlinkListener hyperlinkListener,
                            String message) {
     this(parent, hyperlinkListener, message, true, null, null, null);
@@ -153,9 +153,11 @@ public void mouseClicked(MouseEvent e) {
 
       KeyListener button2Key = new KeyListener() {
         public void keyTyped(KeyEvent e) {
+          // do nothing here, wait until the key is released
         }
 
         public void keyPressed(KeyEvent e) {
+          // do nothing here, wait until the key is released
         }
 
         public void keyReleased(KeyEvent e) {