Canceling self check timer when opening boards/libs manager

Author: Federico Fissore

app/src/processing/app/Base.java

@@ -1259,6 +1259,9 @@ public void onBoardOrPortChange() {
   }
 
   public void openLibraryManager(String dropdownItem) {
+    if (selfCheckTimer != null) {
+      selfCheckTimer.cancel();
+    }
     @SuppressWarnings("serial")
     LibraryManagerUI managerUI = new LibraryManagerUI(activeEditor, BaseNoGui.getPlatform()) {
       @Override
@@ -1285,7 +1288,9 @@ protected void onIndexesUpdated() throws Exception {
   }
 
   public void openBoardsManager(final String filterText, String dropdownItem) throws Exception {
-    // Create dialog for contribution manager
+    if (selfCheckTimer != null) {
+      selfCheckTimer.cancel();
+    }
     @SuppressWarnings("serial")
     ContributionManagerUI managerUI = new ContributionManagerUI(activeEditor, BaseNoGui.getPlatform()) {
       @Override

arduino-core/src/cc/arduino/contributions/packages/ContributionInstaller.java

@@ -322,15 +322,8 @@ private File download(MultiStepProgress progress, String packageIndexUrl) throws
     File tmpFile = new File(outputFile.getAbsolutePath() + ".tmp");
     downloader.download(url, tmpFile, progress, statusText);
 
-    // Replace old index with the updated one
-    if (outputFile.exists()) {
-      if (!outputFile.delete()) {
-        throw new Exception("An error occurred while updating platforms index! I can't delete file " + outputFile);
-      }
-    }
-    if (!tmpFile.renameTo(outputFile)) {
-      throw new Exception("An error occurred while updating platforms index! I can't rename file " + tmpFile);
-    }
+    Files.deleteIfExists(outputFile.toPath());
+    Files.move(tmpFile.toPath(), outputFile.toPath());
 
     return outputFile;
   }