avoid queuing a lot of threads while waiting for platform

Author: facchinm

arduino-core/src/cc/arduino/packages/discoverers/serial/SerialBoardsLister.java

@@ -56,13 +56,6 @@ public void start(Timer timer) {
   }
 
   public synchronized void retriggerDiscovery(boolean polled) {
-    while (BaseNoGui.packages == null) {
-      try {
-        Thread.sleep(1000);
-      } catch (InterruptedException e) {
-        // noop
-      }
-    }
     Platform platform = BaseNoGui.getPlatform();
     if (platform == null) {
       return;
@@ -103,6 +96,11 @@ public synchronized void retriggerDiscovery(boolean polled) {
       String[] parts = newPort.split("_");
       String port = parts[0];
 
+      if (parts.length != 3) {
+        // something went horribly wrong
+        continue;
+      }
+
       Map<String, Object> boardData = platform.resolveDeviceByVendorIdProductId(port, BaseNoGui.packages);
 
       BoardPort boardPort = null;
@@ -168,6 +166,9 @@ public synchronized void retriggerDiscovery(boolean polled) {
 
   @Override
   public void run() {
+     if (BaseNoGui.packages == null) {
+        return;
+     }
      retriggerDiscovery(true);
   }
 }