Fix macOS 10.13 missing menubar

The global bar is being used if locale is English and About() menu is present

Author: facchinm

app/src/processing/app/Base.java

@@ -133,6 +133,10 @@ static public void main(String args[]) throws Exception {
     System.setProperty("java.net.useSystemProxies", "true");
 
     if (OSUtils.isMacOS()) {
+      System.setProperty("apple.laf.useScreenMenuBar",
+        String.valueOf(!System.getProperty("os.version").startsWith("10.13")
+          || com.apple.eawt.Application.getApplication().isAboutMenuItemPresent()));
+
       ThinkDifferent.init();
     }
 

app/src/processing/app/Editor.java

@@ -619,7 +619,7 @@ public void actionPerformed(ActionEvent e) {
     fileMenu.add(item);
 
     // macosx already has its own preferences and quit menu
-    if (!OSUtils.isMacOS()) {
+    if (!OSUtils.isMacOS() || System.getProperty("apple.laf.useScreenMenuBar") == "false") {
       fileMenu.addSeparator();
 
       item = newJMenuItem(tr("Preferences"), ',');
@@ -1252,7 +1252,7 @@ public void actionPerformed(ActionEvent e) {
     menu.add(item);
 
     // macosx already has its own about menu
-    if (!OSUtils.isMacOS()) {
+    if (!OSUtils.isMacOS() || System.getProperty("apple.laf.useScreenMenuBar") == "false") {
       menu.addSeparator();
       item = new JMenuItem(tr("About Arduino"));
       item.addActionListener(new ActionListener() {
@@ -1812,7 +1812,7 @@ protected boolean checkModified() {
     String prompt = I18n.format(tr("Save changes to \"{0}\"?  "),
                                 sketch.getName());
 
-    if (!OSUtils.isMacOS()) {
+    if (!OSUtils.isMacOS() || System.getProperty("apple.laf.useScreenMenuBar") == "false") {
       int result =
         JOptionPane.showConfirmDialog(this, prompt, tr("Close"),
                                       JOptionPane.YES_NO_CANCEL_OPTION,

arduino-core/src/processing/app/macosx/Platform.java

@@ -62,9 +62,6 @@ public Platform() {
   @Override
   public void init() throws Exception {
     super.init();
-
-    System.setProperty("apple.laf.useScreenMenuBar", "true");
-
     discoverRealOsArch();
   }