Do not cache PrinterJob instances. Cache is evil

Author: Federico Fissore

app/src/processing/app/Editor.java

@@ -119,7 +119,6 @@ public boolean apply(Sketch sketch) {
   boolean untitled;
 
   PageFormat pageFormat;
-  PrinterJob printerJob;
 
   // file, sketch, and tools menus for re-inserting items
   JMenu fileMenu;
@@ -2760,15 +2759,11 @@ public void run() {
    * Handler for File → Page Setup.
    */
   public void handlePageSetup() {
-    //printerJob = null;
-    if (printerJob == null) {
-      printerJob = PrinterJob.getPrinterJob();
-    }
+    PrinterJob printerJob = PrinterJob.getPrinterJob();
     if (pageFormat == null) {
       pageFormat = printerJob.defaultPage();
     }
     pageFormat = printerJob.pageDialog(pageFormat);
-    //System.out.println("page format is " + pageFormat);
   }
 
 
@@ -2778,9 +2773,7 @@ public void handlePageSetup() {
   public void handlePrint() {
     statusNotice(_("Printing..."));
     //printerJob = null;
-    if (printerJob == null) {
-      printerJob = PrinterJob.getPrinterJob();
-    }
+    PrinterJob printerJob = PrinterJob.getPrinterJob();
     if (pageFormat != null) {
       //System.out.println("setting page format " + pageFormat);
       printerJob.setPrintable(textarea, pageFormat);