Merge pull request #9873 from matthijskooijman/allow-serial-change-when-disabled

Allow config changes and clear in disabled serial monitor and plotter

Author: facchinm

app/src/processing/app/AbstractTextMonitor.java

@@ -190,14 +190,9 @@ protected void onEnableWindow(boolean enable) {
       textArea.setBackground(new Color(238, 238, 238));
     }
     textArea.invalidate();
-    clearButton.setEnabled(enable);
     scrollPane.setEnabled(enable);
     textField.setEnabled(enable);
     sendButton.setEnabled(enable);
-    autoscrollBox.setEnabled(enable);
-    addTimeStampBox.setEnabled(enable);
-    lineEndings.setEnabled(enable);
-    serialRates.setEnabled(enable);
   }
 
   public void onSendCommand(ActionListener listener) {

app/src/processing/app/SerialMonitor.java

@@ -48,14 +48,16 @@ public SerialMonitor(BoardPort port) {
       String rateString = wholeString.substring(0, wholeString.indexOf(' '));
       serialRate = Integer.parseInt(rateString);
       PreferencesData.set("serial.debug_rate", rateString);
-      try {
-        close();
-        Thread.sleep(100); // Wait for serial port to properly close
-        open();
-      } catch (InterruptedException e) {
-        // noop
-      } catch (Exception e) {
-        System.err.println(e);
+      if (serial != null) {
+        try {
+          close();
+          Thread.sleep(100); // Wait for serial port to properly close
+          open();
+        } catch (InterruptedException e) {
+          // noop
+        } catch (Exception e) {
+          System.err.println(e);
+        }
       }
     });
 

app/src/processing/app/SerialPlotter.java

@@ -242,12 +242,14 @@ public SerialPlotter(BoardPort port) {
       String rateString = wholeString.substring(0, wholeString.indexOf(' '));
       serialRate = Integer.parseInt(rateString);
       PreferencesData.set("serial.debug_rate", rateString);
-      try {
-        close();
-        Thread.sleep(100); // Wait for serial port to properly close
-        open();
-      } catch (Exception e) {
-        // ignore
+      if (serial != null) {
+        try {
+          close();
+          Thread.sleep(100); // Wait for serial port to properly close
+          open();
+        } catch (Exception e) {
+          // ignore
+        }
       }
     });
 
@@ -379,10 +381,8 @@ public void appyPreferences() {
   }
 
   protected void onEnableWindow(boolean enable) {
-    serialRates.setEnabled(enable);
     textField.setEnabled(enable);
     sendButton.setEnabled(enable);
-    lineEndings.setEnabled(enable);
   }
 
   private void onSerialRateChange(ActionListener listener) {