Disabling uncertified boards warning even in java code, for good measure

Author: Federico Fissore

app/src/cc/arduino/view/ShowUncertifiedBoardWarning.java

@@ -966,22 +966,15 @@ protected JMenu addInternalTools(JMenu menu) {
 
   class SerialMenuListener implements ActionListener {
 
-    private final Frame parent;
     private final String serialPort;
-    private final String warning;
 
-    public SerialMenuListener(Frame parent, String serialPort, String warning) {
-      this.parent = parent;
+    public SerialMenuListener(String serialPort) {
       this.serialPort = serialPort;
-      this.warning = warning;
     }
 
     public void actionPerformed(ActionEvent e) {
       selectSerialPort(serialPort);
       base.onBoardOrPortChange();
-      if (warning != null && !Preferences.getBoolean("uncertifiedBoardWarning_dontShowMeAgain")) {
-        SwingUtilities.invokeLater(new ShowUncertifiedBoardWarning(parent));
-      }
     }
 
   }
@@ -1063,7 +1056,7 @@ public int compare(BoardPort o1, BoardPort o2) {
       String label = port.getLabel();
 
       JCheckBoxMenuItem item = new JCheckBoxMenuItem(label, address.equals(selectedPort));
-      item.addActionListener(new SerialMenuListener(this, address, port.getPrefs().get("warning")));
+      item.addActionListener(new SerialMenuListener(address));
       serialMenu.add(item);
     }
 

app/src/cc/arduino/view/UncertifiedBoardWarning.form

@@ -23,16 +23,12 @@
 
 package processing.app;
 
-import cc.arduino.packages.BoardPort;
 import cc.arduino.packages.Uploader;
-import cc.arduino.view.*;
 import processing.app.debug.Compiler;
 import processing.app.debug.Compiler.ProgressListener;
 import processing.app.debug.RunnerException;
-import processing.app.debug.TargetBoard;
 import processing.app.forms.PasswordAuthorizationDialog;
 import processing.app.helpers.OSUtils;
-import processing.app.helpers.PreferencesMap;
 import processing.app.helpers.PreferencesMapException;
 import processing.app.packages.UserLibrary;
 import static processing.app.I18n._;
@@ -46,8 +42,6 @@
 import java.util.LinkedList;
 import java.util.List;
 
-import static processing.app.I18n._;
-
 
 /**
  * Stores information about files in the current sketch
@@ -1153,8 +1147,6 @@ public String build(boolean verbose) throws RunnerException, PreferencesMapExcep
    * @return null if compilation failed, main class name if not
    */
   public String build(String buildPath, boolean verbose) throws RunnerException, PreferencesMapException {
-    useOriginalVidPidIfUncertified();
-
     // run the preprocessor
     editor.status.progressUpdate(20);
 
@@ -1204,38 +1196,6 @@ public boolean exportApplet(String appletPath, boolean usingProgrammer)
     return success;
   }
 
-  private void useOriginalVidPidIfUncertified() {
-    BoardPort boardPort = BaseNoGui.getDiscoveryManager().find(PreferencesData.get("serial.port"));
-    if (boardPort == null) {
-      return;
-    }
-    TargetBoard targetBoard = BaseNoGui.getTargetBoard();
-    if (targetBoard == null) {
-      return;
-    }
-    PreferencesMap boardPreferences = targetBoard.getPreferences();
-    if (boardPreferences.containsKey("build.vid") && boardPreferences.containsKey("build.pid")) {
-      if (!boardPreferences.containsKey("backup.build.vid")) {
-        boardPreferences.put("backup.build.vid", boardPreferences.get("build.vid"));
-        boardPreferences.put("backup.build.pid", boardPreferences.get("build.pid"));
-      }
-
-      if (boardPort.getPrefs().get("warning") != null) {
-        boardPreferences.put("build.vid", boardPort.getPrefs().get("vid"));
-        boardPreferences.put("build.pid", boardPort.getPrefs().get("pid"));
-      } else {
-        boardPreferences.put("build.vid", boardPreferences.get("backup.build.vid"));
-        boardPreferences.put("build.pid", boardPreferences.get("backup.build.pid"));
-      }
-    }
-
-    if (boardPort.getPrefs().get("warning") != null && !Preferences.getBoolean("uncertifiedBoardWarning_dontShowMeAgain")) {
-      SwingUtilities.invokeLater(new ShowUncertifiedBoardWarning(editor));
-    }
-
-
-  }
-
   protected boolean upload(String buildPath, String suggestedClassName, boolean usingProgrammer) throws Exception {
 
     Uploader uploader = Compiler.getUploaderByPreferences(false);