Fixed a bunch of trivial javac warnings

Author: cmaglie

app/src/processing/app/EditorStatus.java

@@ -98,7 +98,7 @@ public EditorStatus(Editor editor) {
     this.message = NO_MESSAGE;
     this.mode = NOTICE;
     this.font = Theme.getFont("status.font");
-    this.compilerProgressListeners = new ArrayList<CompilerProgressListener>();
+    this.compilerProgressListeners = new ArrayList<>();
     this.compilerProgressListeners.add(this::progressUpdate);
     initialize();
   }

app/src/processing/app/EditorToolbar.java

@@ -382,6 +382,9 @@ public void mousePressed(MouseEvent e) {
       case SERIAL:
         editor.handleSerial();
         break;
+
+      default:
+        break;
     }
   }
 

app/src/processing/app/SerialMonitor.java

@@ -76,6 +76,8 @@ private void send(String s) {
         case 3:
           s += "\r\n";
           break;
+        default:
+          break;
       }
       if ("".equals(s) && lineEndings.getSelectedIndex() == 0 && !PreferencesData.has("runtime.line.ending.alert.notified")) {
         noLineEndingAlert.setForeground(Color.RED);

arduino-core/src/cc/arduino/Compiler.java

@@ -153,7 +153,7 @@ public Compiler(File pathToSketch, Sketch sketch) {
   }
 
   public String build(CompilerProgressListener progListener, boolean exportHex) throws RunnerException, PreferencesMapException, IOException {
-    ArrayList<CompilerProgressListener> listeners = new ArrayList<CompilerProgressListener>();
+    ArrayList<CompilerProgressListener> listeners = new ArrayList<>();
     listeners.add(progListener);
     return this.build(listeners, exportHex);
   }

arduino-core/src/cc/arduino/packages/discoverers/NetworkDiscovery.java

@@ -34,16 +34,13 @@
 import processing.app.BaseNoGui;
 
 import javax.jmdns.*;
-import java.io.IOException;
 import java.net.InetAddress;
 import java.util.*;
 
 import cc.arduino.packages.discoverers.network.BoardReachabilityFilter;
 
 public class NetworkDiscovery implements Discovery, ServiceListener {
 
-  private static final int MAX_TIME_AWAITING_FOR_PACKAGES = 5000;
-
   private final List<BoardPort> reachableBoardPorts = new LinkedList<>();
   private final List<BoardPort> boardPortsDiscoveredWithJmDNS = new LinkedList<>();
   private Timer reachabilityTimer;

arduino-core/src/cc/arduino/packages/discoverers/network/BoardReachabilityFilter.java

@@ -34,16 +34,12 @@
 import processing.app.helpers.NetUtils;
 
 import java.net.InetAddress;
-import java.net.NetworkInterface;
-import java.util.Enumeration;
 import java.net.UnknownHostException;
 import java.util.*;
 
 public class BoardReachabilityFilter extends TimerTask {
 
   private final NetworkDiscovery networkDiscovery;
-  private Enumeration<NetworkInterface> staticNetworkInterfaces;
-  private final List<String> staticNetworkInterfacesList = new LinkedList<>();
 
   public BoardReachabilityFilter(NetworkDiscovery networkDiscovery) {
     this.networkDiscovery = networkDiscovery;

arduino-core/src/processing/app/packages/LibraryList.java

@@ -33,6 +33,7 @@
 import java.util.LinkedList;
 import java.util.List;
 
+import cc.arduino.contributions.libraries.ContributedLibrary;
 import processing.app.helpers.FileUtils;
 
 @SuppressWarnings("serial")
@@ -79,7 +80,7 @@ public synchronized void remove(UserLibrary lib, boolean archAware) {
   }
 
   public synchronized void sort() {
-    Collections.sort(this, UserLibrary.CASE_INSENSITIVE_ORDER);
+    Collections.sort(this, ContributedLibrary.CASE_INSENSITIVE_ORDER);
   }
 
   public synchronized LibraryList filterLibrariesInSubfolder(File subFolder) {