Line highlighting setting was read from preferences while it's stored in theme.txt. Fixed and disabled line highlighting by default since no one has never seen it. Fixes #1228

Author: Federico Fissore

app/src/processing/app/Editor.java

@@ -504,7 +504,7 @@ public void applyPreferences() {
 
     } else {
       textarea.setBackground(Theme.getColor("editor.bgcolor"));
-      textarea.setHighlightCurrentLine(PreferencesData.getBoolean("editor.linehighlight"));
+      textarea.setHighlightCurrentLine(Theme.getBoolean("editor.linehighlight"));
       textarea.setEditable(true);
     }
 

app/src/processing/app/syntax/SketchTextArea.java

@@ -32,13 +32,15 @@
 
 import org.apache.commons.compress.utils.IOUtils;
 import org.fife.ui.rsyntaxtextarea.*;
-import org.fife.ui.rsyntaxtextarea.Theme;
 import org.fife.ui.rsyntaxtextarea.Token;
 import org.fife.ui.rsyntaxtextarea.focusabletip.FocusableTip;
 import org.fife.ui.rtextarea.RTextArea;
 import org.fife.ui.rtextarea.RTextAreaUI;
 import org.fife.ui.rtextarea.RUndoManager;
-import processing.app.*;
+import processing.app.Base;
+import processing.app.BaseNoGui;
+import processing.app.EditorListener;
+import processing.app.PreferencesData;
 
 import javax.swing.*;
 import javax.swing.event.EventListenerList;
@@ -107,6 +109,7 @@ private void setTheme(String name) throws IOException {
     }
 
     setBackground(processing.app.Theme.getColor("editor.bgcolor"));
+    setHighlightCurrentLine(processing.app.Theme.getBoolean("editor.linehighlight"));
     setCurrentLineHighlightColor(processing.app.Theme.getColor("editor.linehighlight.color"));
     setCaretColor(processing.app.Theme.getColor("editor.caret.color"));
     setSelectedTextColor(null);

build/shared/lib/theme/theme.txt

@@ -50,7 +50,7 @@ editor.bgcolor = #ffffff
 # highlight for the current line
 editor.linehighlight.color=#e2e2e2
 # highlight for the current line
-editor.linehighlight=true
+editor.linehighlight=false
 
 # caret blinking and caret color
 editor.caret.color = #333300