Avoid warning about SCCS folders in libraries, just ignore them. Fixes #3237

Author: Federico Fissore

arduino-core/src/processing/app/helpers/FileUtils.java

@@ -169,7 +169,15 @@ public static String getLinuxPathFrom(File file) {
   }
 
   public static boolean isSCCSOrHiddenFile(File file) {
-    return file.isHidden() || file.getName().charAt(0) == '.' || (file.isDirectory() && SOURCE_CONTROL_FOLDERS.contains(file.getName()));
+    return isSCCSFolder(file) || isHiddenFile(file);
+  }
+
+  public static boolean isHiddenFile(File file) {
+    return file.isHidden() || file.getName().charAt(0) == '.';
+  }
+
+  public static boolean isSCCSFolder(File file) {
+    return file.isDirectory() && SOURCE_CONTROL_FOLDERS.contains(file.getName());
   }
 
   public static String readFileToString(File file) throws IOException {

arduino-core/src/processing/app/packages/UserLibrary.java

@@ -83,8 +83,7 @@ public static UserLibrary create(File libFolder) throws IOException {
     // "arch" folder no longer supported
     File archFolder = new File(libFolder, "arch");
     if (archFolder.isDirectory())
-      throw new IOException("'arch' folder is no longer supported! See "
-              + "http://goo.gl/gfFJzU for more information");
+      throw new IOException("'arch' folder is no longer supported! See http://goo.gl/gfFJzU for more information");
 
     // Check mandatory properties
     for (String p : MANDATORY_PROPERTIES)
@@ -101,20 +100,22 @@ public static UserLibrary create(File libFolder) throws IOException {
 
       File utilFolder = new File(libFolder, "utility");
       if (utilFolder.exists() && utilFolder.isDirectory()) {
-        throw new IOException(
-                "Library can't use both 'src' and 'utility' folders.");
+        throw new IOException("Library can't use both 'src' and 'utility' folders.");
       }
     } else {
       // Layout with source code on library's root and "utility" folders
       layout = LibraryLayout.FLAT;
     }
 
     // Warn if root folder contains development leftovers
-    for (File file : libFolder.listFiles()) {
-      if (file.isDirectory()) {
-        if (FileUtils.isSCCSOrHiddenFile(file)) {
+    File[] files = libFolder.listFiles();
+    if (files == null) {
+      throw new IOException("Unable to list files of library in " + libFolder);
+    }
+    for (File file : files) {
+      if (file.isDirectory() && FileUtils.isSCCSOrHiddenFile(file)) {
+        if (!FileUtils.isSCCSFolder(file) && FileUtils.isHiddenFile(file)) {
           System.out.println("WARNING: Spurious " + file.getName() + " folder in '" + properties.get("name") + "' library");
-          continue;
         }
       }
     }
@@ -131,8 +132,7 @@ public static UserLibrary create(File libFolder) throws IOException {
     if (category == null)
       category = "Uncategorized";
     if (!CATEGORIES.contains(category)) {
-      System.out.println("WARNING: Category '" + category + "' in library " +
-              properties.get("name") + " is not valid. Setting to 'Uncategorized'");
+      System.out.println("WARNING: Category '" + category + "' in library " + properties.get("name") + " is not valid. Setting to 'Uncategorized'");
       category = "Uncategorized";
     }