Use latest tools version for generic tool.paths properties

Author: cmaglie

arduino-core/src/processing/app/BaseNoGui.java

@@ -5,6 +5,7 @@
 import cc.arduino.UploaderUtils;
 import cc.arduino.contributions.GPGDetachedSignatureVerifier;
 import cc.arduino.contributions.SignatureVerificationFailedException;
+import cc.arduino.contributions.VersionComparator;
 import cc.arduino.contributions.libraries.LibrariesIndexer;
 import cc.arduino.contributions.packages.ContributedPlatform;
 import cc.arduino.contributions.packages.ContributedTool;
@@ -866,6 +867,8 @@ public static void createToolPreferences(Collection<ContributedTool> installedTo
       PreferencesData.removeAllKeysWithPrefix(prefix);
     }
 
+    Map<String, String> latestVersions = new HashMap<>();
+    VersionComparator comparator = new VersionComparator();
     for (ContributedTool tool : installedTools) {
       File installedFolder = tool.getDownloadableContribution(getPlatform()).getInstalledFolder();
       String toolPath;
@@ -874,10 +877,15 @@ public static void createToolPreferences(Collection<ContributedTool> installedTo
       } else {
         toolPath = Constants.PREF_REMOVE_PLACEHOLDER;
       }
-      PreferencesData.set(prefix + tool.getName() + ".path", toolPath);
-      PreferencesData.set(prefix + tool.getName() + "-" + tool.getVersion() + ".path", toolPath);
-      PreferencesData.set(prefix + tool.getPackager() + "-" + tool.getName() + "-" + tool.getVersion() + ".path",
-          toolPath);
+      String toolName = tool.getName();
+      String toolVersion = tool.getVersion();
+      PreferencesData.set(prefix + toolName + "-" + toolVersion + ".path", toolPath);
+      PreferencesData.set(prefix + tool.getPackager() + "-" + toolName + "-" + toolVersion + ".path", toolPath);
+      // In the generic tool property put the path of the latest version if more are available
+      if (!latestVersions.containsKey(toolName) || comparator.greaterThan(toolVersion, latestVersions.get(toolName))) {
+        latestVersions.put(toolName, toolVersion);
+        PreferencesData.set(prefix + toolName + ".path", toolPath);
+      }
     }
   }