EditorStatus rewritten: less shared state, shorter and cleaner code. Also fixes #666

Author: Federico Fissore

app/src/processing/app/Base.java

@@ -456,9 +456,9 @@ protected void onProgress(Progress progress) {
       }
 
       // Error during build or upload
-      int res = editor.status.mode;
-      if (res == EditorStatus.ERR)
+      if (editor.status.isErr()) {
         System.exit(1);
+      }
 
       // No errors exit gracefully
       System.exit(0);

app/src/processing/app/Editor.java

@@ -250,9 +250,9 @@ public void windowDeactivated(WindowEvent e) {
     // For rev 0120, placing things inside a JPanel
     Container contentPain = getContentPane();
     contentPain.setLayout(new BorderLayout());
-    JPanel pain = new JPanel();
-    pain.setLayout(new BorderLayout());
-    contentPain.add(pain, BorderLayout.CENTER);
+    JPanel pane = new JPanel();
+    pane.setLayout(new BorderLayout());
+    contentPain.add(pane, BorderLayout.CENTER);
 
     Box box = Box.createVerticalBox();
     Box upper = Box.createVerticalBox();
@@ -326,12 +326,12 @@ public void windowDeactivated(WindowEvent e) {
     // hopefully these are no longer needed w/ swing
     // (har har har.. that was wishful thinking)
     // listener = new EditorListener(this, textarea);
-    pain.add(box);
+    pane.add(box);
 
     // get shift down/up events so we can show the alt version of toolbar buttons
     textarea.addKeyListener(toolbar);
 
-    pain.setTransferHandler(new FileDropHandler());
+    pane.setTransferHandler(new FileDropHandler());
 
 //    System.out.println("t1");