PluggableDiscovery: BoardPort.label sanity check in the correct place

Author: cmaglie

arduino-core/src/cc/arduino/packages/discoverers/PluggableDiscovery.java

@@ -173,6 +173,10 @@ private void processJsonNode(ObjectMapper mapper, JsonNode node) {
   private BoardPort mapJsonNodeToBoardPort(ObjectMapper mapper, JsonNode node) {
     try {
       BoardPort port = mapper.treeToValue(node.get("port"), BoardPort.class);
+      // if no label, use address
+      if (port.getLabel() == null || port.getLabel().isEmpty()) {
+        port.setLabel(port.getAddress());
+      }
       port.searchMatchingBoard();
       return port;
     } catch (JsonProcessingException e) {
@@ -256,10 +260,6 @@ private synchronized void addOrUpdate(BoardPort port) {
     // if address already on the list, discard old info
     portList.removeIf(bp -> address.equals(bp.getAddress()));
 
-    // if no label, use address
-    if (port.getLabel() == null) {
-      port.setLabel(address);
-    }
     portList.add(port);
   }