Deleting json files if they are some how corrupted. Fixes #3015

Author: Federico Fissore

arduino-core/src/processing/app/BaseNoGui.java

@@ -7,6 +7,7 @@
 import cc.arduino.files.DeleteFilesOnShutdown;
 import cc.arduino.packages.DiscoveryManager;
 import cc.arduino.packages.Uploader;
+import com.fasterxml.jackson.core.JsonProcessingException;
 import org.apache.commons.logging.impl.LogFactoryImpl;
 import org.apache.commons.logging.impl.NoOpLog;
 import processing.app.debug.Compiler;
@@ -597,9 +598,13 @@ static public void initPackages() throws Exception {
 
     try {
       indexer.parseIndex();
+    } catch (JsonProcessingException e) {
+      FileUtils.deleteIfExists(indexFile);
+      FileUtils.deleteIfExists(indexSignatureFile);
+      throw e;
     } catch (SignatureVerificationFailedException e) {
-      indexFile.delete();
-      indexSignatureFile.delete();
+      FileUtils.deleteIfExists(indexFile);
+      FileUtils.deleteIfExists(indexSignatureFile);
       throw e;
     }
     indexer.syncWithFilesystem(getHardwareFolder());
@@ -631,7 +636,12 @@ static public void initPackages() throws Exception {
         }
       }
     }
-    librariesIndexer.parseIndex();
+    try {
+      librariesIndexer.parseIndex();
+    } catch (JsonProcessingException e) {
+      FileUtils.deleteIfExists(librariesIndexFile);
+      throw e;
+    }
   }
 
   static protected void initPlatform() {

arduino-core/src/processing/app/helpers/FileUtils.java

@@ -85,7 +85,7 @@ public static void recursiveDelete(File file) {
         recursiveDelete(current);
       }
     }
-    file.delete();
+    deleteIfExists(file);
   }
 
   public static File createTempFolder() throws IOException {
@@ -269,5 +269,16 @@ public static File newFile(File parent, String... parts) {
     return result;
   }
 
+  public static boolean deleteIfExists(File file) {
+    if (file == null) {
+      return true;
+    }
+
+    if (!file.exists()) {
+      return false;
+    }
+
+    return file.delete();
+  }
 
 }