Moved getDefaultSketchbookFolder() from Base to BaseNoGui and other minor fixes.

Author: bitron

app/src/processing/app/Base.java

@@ -1887,22 +1887,9 @@ static public File getSketchbookHardwareFolder() {
   }
 
 
-  protected File getDefaultSketchbookFolder() {
-    if (BaseNoGui.getPortableFolder() != null)
-      return new File(BaseNoGui.getPortableFolder(), BaseNoGui.getPortableSketchbookFolder());
-
-    File sketchbookFolder = null;
-    try {
-      sketchbookFolder = getPlatform().getDefaultSketchbookFolder();
-    } catch (Exception e) { }
-
-    return sketchbookFolder;
-  }
-
-
   protected File getDefaultSketchbookFolderOrPromptForIt() {
 
-    File sketchbookFolder = getDefaultSketchbookFolder();
+    File sketchbookFolder = BaseNoGui.getDefaultSketchbookFolder();
 
     if (sketchbookFolder == null) {
       sketchbookFolder = promptSketchbookLocation();

app/src/processing/app/BaseNoGui.java

@@ -143,6 +143,18 @@ static public TargetPlatform getCurrentTargetPlatformFromPackage(String pack) {
     return getTargetPlatform(pack, PreferencesData.get("target_platform"));
   }
 
+  static public  File getDefaultSketchbookFolder() {
+    if (getPortableFolder() != null)
+      return new File(getPortableFolder(), getPortableSketchbookFolder());
+
+    File sketchbookFolder = null;
+    try {
+      sketchbookFolder = getPlatform().getDefaultSketchbookFolder();
+    } catch (Exception e) { }
+
+    return sketchbookFolder;
+  }
+
   public static DiscoveryManager getDiscoveryManager() {
     return discoveryManager;
   }
@@ -262,14 +274,14 @@ static public File getSketchbookLibrariesFolder() {
 
   static public String getSketchbookPath() {
     // Get the sketchbook path, and make sure it's set properly
-    String sketchbookPath = Preferences.get("sketchbook.path");
+    String sketchbookPath = PreferencesData.get("sketchbook.path");
 
     // If a value is at least set, first check to see if the folder exists.
     // If it doesn't, warn the user that the sketchbook folder is being reset.
     if (sketchbookPath != null) {
       File sketchbookFolder;
-      if (BaseNoGui.getPortableFolder() != null)
-        sketchbookFolder = new File(BaseNoGui.getPortableFolder(), sketchbookPath);
+      if (getPortableFolder() != null)
+        sketchbookFolder = new File(getPortableFolder(), sketchbookPath);
       else
         sketchbookFolder = absoluteFile(sketchbookPath);
       if (!sketchbookFolder.exists()) {