Update NTPClient.cpp

bitsy · web-flow · commit 712c58c18e53 · 2018-09-16T21:11:26.000-07:00
The NTPClient method update() has been changed to only return "TRUE" after a successful update. The following conditions return "FALSE":
- Interval duration requirement not met
- forceUpdate() times out
diff --git a/NTPClient.cpp b/NTPClient.cpp
@@ -89,7 +89,7 @@ bool NTPClient::forceUpdate() {
 
   this->_currentEpoc = secsSince1900 - SEVENZYYEARS;
 
-  return true;
+  return true;  // return true after successful update
 }
 
 bool NTPClient::update() {
@@ -98,7 +98,7 @@ bool NTPClient::update() {
     if (!this->_udpSetup) this->begin();                         // setup the UDP client if needed
     return this->forceUpdate();
   }
-  return true;
+  return false;   // return false if update does not occur
 }
 
 unsigned long NTPClient::getEpochTime() const {

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ bool NTPClient::forceUpdate() {`
`89`	`89`
`90`	`90`	`this->_currentEpoc = secsSince1900 - SEVENZYYEARS;`
`91`	`91`
`92`		`- return true;`
	`92`	`+ return true; // return true after successful update`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`bool NTPClient::update() {`
`@@ -98,7 +98,7 @@ bool NTPClient::update() {`
`98`	`98`	`if (!this->_udpSetup) this->begin(); // setup the UDP client if needed`
`99`	`99`	`return this->forceUpdate();`
`100`	`100`	`}`
`101`		`- return true;`
	`101`	`+ return false; // return false if update does not occur`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`unsigned long NTPClient::getEpochTime() const {`