Tiny optimization (suggested by Rotzbua)

Author: PaulStoffregen

src/Ethernet.h

@@ -130,16 +130,16 @@ class EthernetClass {
 	static uint8_t socketPeek(uint8_t s);
 	// sets up a UDP datagram, the data for which will be provided by one
 	// or more calls to bufferData and then finally sent with sendUDP.
-	// return 1 if the datagram was successfully set up, or 0 if there was an error
-	static int socketStartUDP(uint8_t s, uint8_t* addr, uint16_t port);
+	// return true if the datagram was successfully set up, or false if there was an error
+	static bool socketStartUDP(uint8_t s, uint8_t* addr, uint16_t port);
 	// copy up to len bytes of data from buf into a UDP datagram to be
 	// sent later by sendUDP.  Allows datagrams to be built up from a series of bufferData calls.
 	// return Number of bytes successfully buffered
 	static uint16_t socketBufferData(uint8_t s, uint16_t offset, const uint8_t* buf, uint16_t len);
 	// Send a UDP datagram built up from a sequence of startUDP followed by one or more
 	// calls to bufferData.
-	// return 1 if the datagram was successfully sent, or 0 if there was an error
-	static int socketSendUDP(uint8_t s);
+	// return true if the datagram was successfully sent, or false if there was an error
+	static bool socketSendUDP(uint8_t s);
 	// Initialize the "random" source port number
 	static void socketPortRand(uint16_t n);
 };

src/socket.cpp

@@ -496,20 +496,20 @@ uint16_t EthernetClass::socketBufferData(uint8_t s, uint16_t offset, const uint8
 	return ret;
 }
 
-int EthernetClass::socketStartUDP(uint8_t s, uint8_t* addr, uint16_t port)
+bool EthernetClass::socketStartUDP(uint8_t s, uint8_t* addr, uint16_t port)
 {
 	if ( ((addr[0] == 0x00) && (addr[1] == 0x00) && (addr[2] == 0x00) && (addr[3] == 0x00)) ||
 	  ((port == 0x00)) ) {
-		return 0;
+		return false;
 	}
 	SPI.beginTransaction(SPI_ETHERNET_SETTINGS);
 	W5100.writeSnDIPR(s, addr);
 	W5100.writeSnDPORT(s, port);
 	SPI.endTransaction();
-	return 1;
+	return true;
 }
 
-int EthernetClass::socketSendUDP(uint8_t s)
+bool EthernetClass::socketSendUDP(uint8_t s)
 {
 	SPI.beginTransaction(SPI_ETHERNET_SETTINGS);
 	W5100.execCmdSn(s, Sock_SEND);
@@ -521,7 +521,7 @@ int EthernetClass::socketSendUDP(uint8_t s)
 			W5100.writeSnIR(s, (SnIR::SEND_OK|SnIR::TIMEOUT));
 			SPI.endTransaction();
 			//Serial.printf("sendUDP timeout\n");
-			return 0;
+			return false;
 		}
 		SPI.endTransaction();
 		yield();
@@ -534,6 +534,6 @@ int EthernetClass::socketSendUDP(uint8_t s)
 
 	//Serial.printf("sendUDP ok\n");
 	/* Sent ok */
-	return 1;
+	return true;
 }