Replace superfluous boolean operation

Author: sebromero

src/InternalStorage.cpp

@@ -32,7 +32,7 @@ bool InternalStorage::begin(){
             this -> userDataFileSystem = new LittleFileSystem(this->partitionName);
         }
         int err = this -> userDataFileSystem -> mount(userData);
-        return err == 0 ? true : false;
+        return err == 0;
     #elif defined(ARDUINO_PORTENTA_H7_M7) ||  defined(ARDUINO_OPTA) 
         this -> blockDevice = QSPIFBlockDevice::get_default_instance();
         this -> userData = new mbed::MBRBlockDevice(this->blockDevice, this->partitionNumber);
@@ -51,15 +51,15 @@ bool InternalStorage::begin(){
             this -> userDataFileSystem = new mbed::LittleFileSystem(this->partitionName);
         }
         int err = this -> userDataFileSystem -> mount(this -> userData);
-        return err == 0 ? true : false;
+        return err == 0;
     #else
         return false; // Unsupported board
     #endif
 }
 
 bool InternalStorage::unmount(){
     int err = this -> userDataFileSystem -> unmount();
-    return err == 0 ? true : false;
+    return err == 0;
 }
 
 Folder InternalStorage::getRootFolder(){
@@ -83,18 +83,18 @@ bool InternalStorage::format(FileSystems fs){
     if(fs == FS_FAT){
         #if defined(ARDUINO_PORTENTA_C33)
             this -> userDataFileSystem = new FATFileSystem(this->partitionName);
-            return this -> userDataFileSystem -> reformat(this-> userData)  == 0 ? true : false;
+            return this -> userDataFileSystem -> reformat(this-> userData)  == 0;
         #elif defined(ARDUINO_PORTENTA_H7_M7) ||  defined(ARDUINO_OPTA) 
             this -> userDataFileSystem =  new mbed::FATFileSystem(this->partitionName);
-            return this -> userDataFileSystem -> reformat(this-> userData)  == 0 ? true : false;
+            return this -> userDataFileSystem -> reformat(this-> userData)  == 0;
         #endif
     } if (fs == FS_LITTLEFS) {
         #if defined(ARDUINO_PORTENTA_C33)
             this -> userDataFileSystem = new LittleFileSystem(this->partitionName);
-            return this -> userDataFileSystem -> reformat(this-> userData)  == 0 ? true : false;
+            return this -> userDataFileSystem -> reformat(this-> userData)  == 0;
         #elif defined(ARDUINO_PORTENTA_H7_M7) ||  defined(ARDUINO_OPTA) 
             this -> userDataFileSystem =  new mbed::LittleFileSystem(this->partitionName);
-            return this -> userDataFileSystem -> reformat(this-> userData)  == 0 ? true : false;
+            return this -> userDataFileSystem -> reformat(this-> userData)  == 0;
         #endif
     }
 

src/SDStorage.cpp

@@ -9,7 +9,7 @@ SDStorage::SDStorage(){
 }
 
 bool SDStorage::begin(){
-  return mount(DEV_SDCARD, this->fileSystem, MNT_DEFAULT) == 0 ? true : false;
+  return mount(DEV_SDCARD, this->fileSystem, MNT_DEFAULT) == 0;
 }
 
 bool SDStorage::begin(FileSystems fs){
@@ -18,7 +18,7 @@ bool SDStorage::begin(FileSystems fs){
 }
 
 bool SDStorage::unmount(){
-    return umount(DEV_SDCARD) == 0 ? true : false;
+    return umount(DEV_SDCARD) == 0;
 }
 
 Folder SDStorage::getRootFolder(){
@@ -39,7 +39,7 @@ bool SDStorage::format(FileSystems fs){
         err =  mkfs(DEV_SDCARD, FS_LITTLEFS);
     }
 
-    return err == 0 ? true : false;
+    return err == 0;
 }
 
 

src/USBStorage.cpp

@@ -38,7 +38,7 @@ bool USBStorage::begin(){
         this -> connected = false;
     }
 
-    return err == 0 ? true : false;
+    return err == 0;
 }
 
 bool USBStorage::unmount(){
@@ -49,7 +49,7 @@ bool USBStorage::unmount(){
       this -> connected = false;
   }
 
-    return unmountResult == 0 ? true : false;
+    return unmountResult == 0;
 }
 
 Folder USBStorage::getRootFolder(){
@@ -90,12 +90,12 @@ bool  USBStorage::format(FileSystems fs){
         this -> begin();
         this -> unmount();
         this -> fileSystem = FS_FAT;
-        return mkfs(DEV_USB, FS_FAT) == 0 ? true : false;
+        return mkfs(DEV_USB, FS_FAT) == 0;
     } else if(FS_LITTLEFS) {
         this -> begin();
         this -> unmount();
         this -> fileSystem = FS_LITTLEFS;
-        return mkfs(DEV_USB, FS_LITTLEFS) == 0 ? true : false;
+        return mkfs(DEV_USB, FS_LITTLEFS) == 0;
     }
 
 }