Fix compiler issues

Author: sebromero

examples/RGBLED/RGBLED.ino

@@ -21,8 +21,7 @@ void pulseLED(RGBLED &led) {
 }
 
 void pulseColors(RGBLED &led) {
-    // Brightness can also be set via 4th struct element
-    led.setColor({255, 0, 0}, 255);  // Red
+    led.setColor({255, 0, 0});  // Red
     pulseLED(led);
 
     // Color can be set via Color struct or 3 separate uint8_t values

src/IndoorAirQualitySensor.cpp

@@ -58,7 +58,7 @@ bool IndoorAirQualitySensor::setMode(IndoorAirQualitySensorMode sensorMode, bool
 
     // Check if the existing value is already the same
     if ((currentRegisterData & (7 << 1)) == (mode << 1)) {
-        return;
+        return true;
     }
     if(!writeToRegister(STATUS_REGISTER_INFO, (currentRegisterData & ~(7 << 1)) | (mode << 1))){
         return false;
@@ -95,7 +95,7 @@ bool IndoorAirQualitySensor::enabled() {
 
 bool IndoorAirQualitySensor::setEnabled(bool isEnabled, bool persist) {
     if (isEnabled == enabled()) {
-        return;
+        return true;
     }
 
     auto mode = isEnabled ? IndoorAirQualitySensorMode::indoorAirQuality : IndoorAirQualitySensorMode::powerDown;

src/IndoorAirQualitySensor.h

@@ -120,7 +120,7 @@ class IndoorAirQualitySensor : public I2CDevice {
      *                When persist is true, the mode setting of OutdoorAirQualitySensor and TemperatureHumiditySensor will also be persisted.
      * @return True if the mode was set successfully, false otherwise.
      */
-    bool setMode(IndoorAirQualitySensorMode sensorMode, bool persist);
+    bool setMode(IndoorAirQualitySensorMode sensorMode, bool persist = false);
 
     /**
      * @brief Get the mode as a string. 

src/NiclaSenseEnv.cpp

@@ -155,12 +155,12 @@ int NiclaSenseEnv::UARTBaudRate() {
 bool NiclaSenseEnv::setUARTBaudRate(int baudRate, bool persist) {
     int baudRateIndex = baudRateNativeValue(baudRate);
     if (baudRateIndex == -1) {
-        return; // Baud rate not found
+        return false; // Baud rate not found
     }
 
     uint8_t uartControlRegisterData = readFromRegister<uint8_t>(UART_CONTROL_REGISTER_INFO);
     if ((uartControlRegisterData & 7) == baudRateIndex) {
-        return; // Value is already the same
+        return true; // Value is already the same
     }
     if(!writeToRegister(UART_CONTROL_REGISTER_INFO, (uartControlRegisterData & ~7) | baudRateIndex)){
         return false;
@@ -181,7 +181,7 @@ bool NiclaSenseEnv::isUARTCSVOutputEnabled() {
 bool NiclaSenseEnv::setUARTCSVOutputEnabled(bool enabled, bool persist) {
     uint8_t boardControlRegisterData = readFromRegister<uint8_t>(CONTROL_REGISTER_INFO);
     if ((boardControlRegisterData & 2) == static_cast<int>(enabled)) {
-        return; // Value is already the same
+        return true; // Value is already the same
     }
     if(!writeToRegister(CONTROL_REGISTER_INFO, (boardControlRegisterData & ~2) | (enabled << 1))){
         return false;
@@ -202,15 +202,15 @@ char NiclaSenseEnv::CSVDelimiter() {
 bool NiclaSenseEnv::setCSVDelimiter(char delimiter, bool persist) {
     char currentDelimiter = CSVDelimiter();
     if (currentDelimiter == delimiter) {
-        return; // Value is already the same
+        return true; // Value is already the same
     }
 
     // Define prohibited delimiters
     const char prohibitedDelimiters[] = {'\r', '\n', '\\', '"', '\''};
 
     for (auto prohibitedDelimiter : prohibitedDelimiters) {
         if (delimiter == prohibitedDelimiter) {
-            return; // Delimiter is prohibited
+            return false; // Delimiter is prohibited
         }
     }
 
@@ -234,7 +234,7 @@ bool NiclaSenseEnv::isDebuggingEnabled() {
 bool NiclaSenseEnv::setDebuggingEnabled(bool enabled, bool persist) {
     uint8_t boardControlRegisterData = readFromRegister<uint8_t>(CONTROL_REGISTER_INFO);
     if ((boardControlRegisterData & 1) == static_cast<int>(enabled)) {
-        return; // Value is already the same
+        return true; // Value is already the same
     }
     if(!writeToRegister(CONTROL_REGISTER_INFO, (boardControlRegisterData & ~1) | enabled)){
         return false;
@@ -249,12 +249,12 @@ bool NiclaSenseEnv::setDebuggingEnabled(bool enabled, bool persist) {
 
 bool NiclaSenseEnv::setDeviceAddress(int address, bool persist) {
     if (address < 0 || address > 127) {
-        return; // Invalid address
+        return false; // Invalid address
     }
     uint8_t addressRegisterData = readFromRegister<uint8_t>(SLAVE_ADDRESS_REGISTER_INFO);
     // Check bits 0 - 6
     if ((addressRegisterData & 127) == address) {
-        return; // Value is already the same
+        return true; // Value is already the same
     }
     if(!writeToRegister(SLAVE_ADDRESS_REGISTER_INFO, (addressRegisterData & ~127) | address)){
         return false;

src/OrangeLED.cpp

@@ -13,7 +13,7 @@ uint8_t OrangeLED::brightness() {
 
 bool OrangeLED::setBrightness(uint8_t brightness, bool persist) {
     if (brightness > 255) {
-        return; // Invalid brightness value
+        return false; // Invalid brightness value
     }
 
     uint8_t mappedBrightness = map(brightness, 0, 255, 0, 63);

src/OutdoorAirQualitySensor.cpp

@@ -49,7 +49,7 @@ bool OutdoorAirQualitySensor::setMode(OutdoorAirQualitySensorMode sensorMode, bo
 
     // Check if the existing value is already the same
     if ((currentRegisterData & (3 << 4)) == (mode << 4)) {
-        return;
+        return true;
     }
 
     // Overwrite bits 4 and 5 with the new value
@@ -84,7 +84,7 @@ bool OutdoorAirQualitySensor::enabled() {
 bool OutdoorAirQualitySensor::setEnabled(bool isEnabled, bool persist) {
     // Ignore the request if the sensor is already in the desired state to maintain the current mode
     if (isEnabled == enabled()) {
-        return;
+        return true;
     }
 
     auto mode = isEnabled ? OutdoorAirQualitySensorMode::outdoorAirQuality : OutdoorAirQualitySensorMode::powerDown;

src/RGBLED.cpp

@@ -6,35 +6,25 @@ RGBLED::RGBLED(TwoWire& bus, uint8_t deviceAddress) : I2CDevice(bus, deviceAddre
 RGBLED::RGBLED(uint8_t deviceAddress) : I2CDevice(deviceAddress) {}
 
 bool RGBLED::enableIndoorAirQualityStatus(uint8_t brightness, bool persist) {
-    return setColor(0, 0, 0, brightness, persist);
+    return setColor(0, 0, 0, persist) && setBrightness(brightness, persist);
 }
 
 bool RGBLED::setColor(uint8_t r, uint8_t g, uint8_t b, bool persist) {
-    return setColor(r, g, b, 255, persist);  // Default maximum brightness
-}
-
-bool RGBLED::setColor(uint8_t r, uint8_t g, uint8_t b, uint8_t brightness, bool persist) {
     if(!writeToRegister(RGB_LED_RED_REGISTER_INFO, r)) return false;
     if(!writeToRegister(RGB_LED_GREEN_REGISTER_INFO, g)) return false;
     if(!writeToRegister(RGB_LED_BLUE_REGISTER_INFO, b)) return false;
-    if(!writeToRegister(INTENSITY_REGISTER_INFO, brightness)) return false;
 
     if (persist) {
         return persistRegister(RGB_LED_RED_REGISTER_INFO) &&
                persistRegister(RGB_LED_GREEN_REGISTER_INFO) &&
-               persistRegister(RGB_LED_BLUE_REGISTER_INFO) &&
-               persistRegister(INTENSITY_REGISTER_INFO);
+               persistRegister(RGB_LED_BLUE_REGISTER_INFO);
     }
 
     return true;
 }
 
 bool RGBLED::setColor(Color color, bool persist) {
-    return setColor(color, 255, persist);  // Default maximum brightness
-}
-
-bool RGBLED::setColor(Color color, uint8_t brightness, bool persist) {
-    return setColor(color.red, color.green, color.blue, brightness, persist);
+    return setColor(color.red, color.green, color.blue, persist);
 }
 
 Color RGBLED::color() {

src/RGBLED.h

@@ -52,44 +52,20 @@ class RGBLED : public I2CDevice {
      * @param g The green value (0-255).
      * @param b The blue value (0-255).
      * @param persist If true, the change will be saved to flash memory.
-     *                When persist is True, the brightness will also be persisted.
      * @return True if the color was set successfully, false otherwise.
      */
     bool setColor(uint8_t r, uint8_t g, uint8_t b, bool persist = false);
 
-    /**
-     * Sets the RGB values of the LED along with the specified brightness.
-     * @param r The red value (0-255).
-     * @param g The green value (0-255).
-     * @param b The blue value (0-255).
-     * @param brightness The brightness value (0-255).
-     * @param persist If true, the change will be saved to flash memory.
-     *                When persist is True, the brightness will also be persisted.
-     * @return True if the color was set successfully, false otherwise.
-     */
-    bool setColor(uint8_t r, uint8_t g, uint8_t b, uint8_t brightness, bool persist = false); ;
-
     /**
      * @brief Sets the RGB color of the LED using a Color object.
      * The Color object contains the red, green, and blue values that can be changed individually.
      * Note: A value of 0, 0, 0 will set the color based on the IAQ value from the Indoor Air Quality sensor.
      * @param color The RGB color to set.
      * @param persist If true, the change will be saved to flash memory.
-     *                When persist is True, the brightness will also be persisted.
      * @return True if the color was set successfully, false otherwise.
      */
     bool setColor(Color color, bool persist = false);
 
-    /**
-     * @brief Sets the RGB color and brightness of the LED using a Color object.
-     * @param color The desired RGB color.
-     * @param brightness The desired brightness level (0-255).
-     * @param persist If true, the change will be saved to flash memory.
-     *                When persist is True, the brightness will also be persisted.
-     * @return True if the color was set successfully, false otherwise.
-     */
-    bool setColor(Color color, uint8_t brightness, bool persist = false);
-
     /**
      * @brief Gets the current RGB color of the LED.
      * 

src/TemperatureHumiditySensor.cpp

@@ -29,7 +29,7 @@ bool TemperatureHumiditySensor::setEnabled(bool enabled, bool persist) {
 
     // Check if current value is already the desired value
     if (static_cast<bool>(status & 1) == enabled) {
-        return;
+        return true;
     }
 
     status = enabled ? (status | 1) : (status & 0xFE);