- extended example with GSM compatibility options

- fixed typo in example
- cleanup GSMConnectionManager
- cleanup WiFiConnectionManager
- fixed missing WiFiUDP member which broke compilation

Author: ubidefeo

examples/ArduinoIoTCloud_LED_switch/ArduinoIoTCloud_LED_switch.ino

@@ -5,7 +5,11 @@
   When the potentiometer (or sensor) value changes the data is sent to the Cloud.
   When you flip the switch in the Cloud dashboard the onboard LED lights gets turned ON or OFF.
 
-  
+  IMPORTANT:
+  This sketch will work with both WiFi and GSM enabled boards supported by Arduino IoT Cloud.
+  By default settings for WiFi are chosen. If you prefer to use a GSM board take a look at thingProperties.h arduino_secrets.h,
+  to make sure you uncomment what's needed and comment incompatible instructions.
+
 */
 #include "arduino_secrets.h"
 #include "thingProperties.h"
@@ -51,5 +55,5 @@ void loop() {
 void onLedChange() {
   Serial.print("LED set to ");
   Serial.println(led);
-  digitalWrite(LED_BUILTIN, ledSwitch);
+  digitalWrite(LED_BUILTIN, led);
 }

examples/ArduinoIoTCloud_LED_switch/arduino_secrets.h

@@ -1,3 +1,15 @@
+/*
+	Fill in your login credentials:
+
+	The following lines are used for WiFi enabled boards (MKR1000, MKR WiFi 1010)
+*/
 #define SECRET_SSID "YOUR_WIFI_NETWORK_NAME"
 #define SECRET_PASS "YOUR_WIFI_PASSWORD"
-
+/*
+	If you prefer using a MKR GSM 1400 comment the lines above and uncommet the following.
+	PIN, APN, Login and Password are supplied by your Cellular Data provider.
+*/
+//#define SECRET_PIN ""
+//#define SECRET_APN ""
+//#define SECRET_LOGIN ""
+//#define SECRET_PASS ""

examples/ArduinoIoTCloud_LED_switch/thingProperties.h

@@ -1,9 +1,13 @@
 #include <ArduinoIoTCloud.h>
+/* 
+	The following include line is used for WiFi enabled boards (MKR1000, MKR WiFi 1010)
+*/
 #include <WiFiConnectionManager.h>
+/* 
+	If you prefer using a MKR GSM 1400 comment the line above and uncommet the following.
+*/
+//#include <GSMConnectionManager.h>
 
-
-char ssid[] = SECRET_SSID;        // your network SSID (name)
-char pass[] = SECRET_PASS;    // your network password (use for WPA, or use as key for WEP)
 // Your THING_ID
 #define THING_ID "ARDUINO_IOT_CLOUD_THING_ID"
 
@@ -18,4 +22,11 @@ void initProperties() {
   ArduinoCloud.addProperty(potentiometer, READ, ON_CHANGE);
 }
 
-ConnectionManager *ArduinoIoTPreferredConnection = new WiFiConnectionManager(SECRET_SSID, SECRET_PASS);
+/* 
+	The following include line is used for WiFi enabled boards (MKR1000, MKR WiFi 1010)
+*/
+ConnectionManager *ArduinoIoTPreferredConnection = new WiFiConnectionManager(SECRET_SSID, SECRET_PASS);
+/* 
+	If you prefer using a MKR GSM 1400 comment the line above and uncommet the following.
+*/
+//ConnectionManager *ArduinoIoTPreferredConnection = new GSMConnectionManager(SECRET_PIN, SECRET_APN, SECRET_LOGIN, SECRET_PASS);

src/GSMConnectionManager.h

@@ -51,7 +51,6 @@ class GSMConnectionManager : public ConnectionManager {
   unsigned long lastConnectionTickTime;
   unsigned long getTimeRetries;
   int connectionTickTimeInterval;
-  GSMUDP Udp;
 
 };
 

src/WiFiConnectionManager.h

@@ -16,6 +16,7 @@
  */
 
 #include "ConnectionManager.h"
+#include <WiFiUdp.h>
 
 class WiFiConnectionManager : public ConnectionManager {
 public:
@@ -27,6 +28,8 @@ class WiFiConnectionManager : public ConnectionManager {
   virtual Client &getClient() { return wifiClient; };
   virtual UDP &getUDP() { return udp; };
 
+  WiFiUDP udp;
+  
 private:
 
   void changeConnectionState(NetworkConnectionState _newState);
@@ -125,7 +128,7 @@ void WiFiConnectionManager::check() {
         if(WiFi.firmwareVersion() < WIFI_FIRMWARE_VERSION_REQUIRED){
           sprintf(msgBuffer, "Latest WiFi Firmware: %s", WIFI_FIRMWARE_VERSION_REQUIRED);
           debugMessage(msgBuffer, 0);
-          debugMessage("Please update to latest version for optimal performance.", 0);
+          debugMessage("Please update to the latest version for best performance.", 0);
           delay(5000);
         }
         changeConnectionState(CONNECTION_STATE_CONNECTING);