- applied per1234's suggestions on #31

Author: ubidefeo

examples/ArduinoIoTCloud_LED_switch/ArduinoIoTCloud_LED_switch.ino

@@ -7,7 +7,7 @@
 
   IMPORTANT:
   This sketch will work with both WiFi and GSM enabled boards supported by Arduino IoT Cloud.
-  By default settings for WiFi are chosen. If you prefer to use a GSM board take a look at thingProperties.h arduino_secrets.h,
+  By default, settings for WiFi are chosen. If you prefer to use a GSM board take a look at thingProperties.h arduino_secrets.h,
   to make sure you uncomment what's needed and comment incompatible instructions.
 
 */

examples/ArduinoIoTCloud_LED_switch/thingProperties.h

@@ -1,10 +1,10 @@
 #include <ArduinoIoTCloud.h>
-/* 
-	The following include line is used for WiFi enabled boards (MKR1000, MKR WiFi 1010)
+/*
+ The following include line is used for WiFi enabled boards (MKR1000, MKR WiFi 1010)
 */
 #include <WiFiConnectionManager.h>
-/* 
-	If you prefer using a MKR GSM 1400 comment the line above and uncommet the following.
+/*
+ If you prefer using a MKR GSM 1400 comment the line above and uncommet the following.
 */
 //#include <GSMConnectionManager.h>
 
@@ -22,11 +22,11 @@ void initProperties() {
   ArduinoCloud.addProperty(potentiometer, READ, ON_CHANGE);
 }
 
-/* 
-	The following include line is used for WiFi enabled boards (MKR1000, MKR WiFi 1010)
+/*
+ The following include line is used for WiFi enabled boards (MKR1000, MKR WiFi 1010)
 */
 ConnectionManager *ArduinoIoTPreferredConnection = new WiFiConnectionManager(SECRET_SSID, SECRET_PASS);
-/* 
-	If you prefer using a MKR GSM 1400 comment the line above and uncommet the following.
+/*
+ If you prefer using a MKR GSM 1400 comment the line above and uncommet the following.
 */
-//ConnectionManager *ArduinoIoTPreferredConnection = new GSMConnectionManager(SECRET_PIN, SECRET_APN, SECRET_LOGIN, SECRET_PASS);
+//ConnectionManager *ArduinoIoTPreferredConnection = new GSMConnectionManager(SECRET_PIN, SECRET_APN, SECRET_LOGIN, SECRET_PASS);

src/GSMConnectionManager.h

@@ -130,7 +130,7 @@ void GSMConnectionManager::check() {
         init();
         break;
       case CONNECTION_STATE_CONNECTING:
-        /***  Blocking Call when 4th parameter == true   ***/
+        // NOTE: Blocking Call when 4th parameter == true
         GSM3_NetworkStatus_t networkStatus;
         networkStatus = gprs.attachGPRS(apn, login, pass, true);
         sprintf(msgBuffer, "GPRS.attachGPRS(): %d", networkStatus);
@@ -174,7 +174,6 @@ void GSMConnectionManager::check() {
         }
         break;
       case CONNECTION_STATE_CONNECTED:
-        /***  keep testing network connection   ***/
         gsmAccessAlive = gsmAccess.isAccessAlive();
         sprintf(msgBuffer, "GPRS.isAccessAlive(): %d", gsmAccessAlive);
         debugMessage(msgBuffer, 4);

src/WiFiConnectionManager.h

@@ -139,7 +139,7 @@ void WiFiConnectionManager::check() {
         debugMessage(msgBuffer, 4);
         if (networkStatus != NETWORK_CONNECTED) {
           sprintf(msgBuffer, "Connection to \"%s\" failed", ssid);
-          debugMessage(msgBuffer, 0);  
+          debugMessage(msgBuffer, 0);
           sprintf(msgBuffer, "Retrying in  \"%d\" milliseconds", connectionTickTimeInterval);
           debugMessage(msgBuffer, 2);
           //changeConnectionState(CONNECTION_STATE_CONNECTING);

src/utility/NTPUtils.cpp

@@ -2,7 +2,7 @@
 #include "Arduino.h"
 /*
   This Utility Class is derived from the example code found here https://www.arduino.cc/en/Tutorial/UdpNTPClient
-  For more information on NPT (Network Time Protocol) you can refer to this WikiPedia article https://en.wikipedia.org/wiki/Network_Time_Protocol
+  For more information on NTP (Network Time Protocol) you can refer to this Wikipedia article https://en.wikipedia.org/wiki/Network_Time_Protocol
 */
 
 
@@ -56,9 +56,7 @@ unsigned long NTPUtils::getTime() {
   Udp.begin(localPort);
   sendNTPpacket(packetBuffer);
   long start = millis();
-  while (!Udp.parsePacket() && (millis() - start < 10000))  {
-
-  }
+  while (!Udp.parsePacket() && (millis() - start < 10000)){}
   if (millis() - start >= 1000) {
     //timeout reached
     return 0;
@@ -72,6 +70,5 @@ unsigned long NTPUtils::getTime() {
   unsigned long epoch = secsSince1900 - seventyYears;
 
   Udp.stop();
-
   return epoch;
-}
+}

src/utility/NTPUtils.h

@@ -2,7 +2,7 @@
 #define __NTP_UTILS__
 /*
 	This Utility Class is derived from the example code found here https://www.arduino.cc/en/Tutorial/UdpNTPClient
-	For more information on NPT (Network Time Protocol) you can refer to this WikiPedia article https://en.wikipedia.org/wiki/Network_Time_Protocol
+	For more information on NTP (Network Time Protocol) you can refer to this Wikipedia article https://en.wikipedia.org/wiki/Network_Time_Protocol
 */
 
 #include "Udp.h"
@@ -20,4 +20,4 @@ class NTPUtils {
   		UDP& Udp;
 };
 
-#endif
+#endif