Adding attribute 'deprecated' to poll function and changing back return type of connect function from bool to int after an internal discussion in order to keep consistency with other core libraries

Author: aentinger

src/ArduinoIoTCloud.cpp

@@ -83,17 +83,17 @@ void ArduinoIoTCloudClass::mqttClientBegin(Client& net)
   _mqttClient.setOptions(mqttOpt.keepAlive, mqttOpt.cleanSession, mqttOpt.timeout);
 }
 
-bool ArduinoIoTCloudClass::connect()
+int ArduinoIoTCloudClass::connect()
 {
   // Username: device id
   // Password: empty
   if (!_mqttClient.connect(_id.c_str())) {
-    return false;
+    return 0;
   }
   _mqttClient.subscribe(_stdinTopic);
   _mqttClient.subscribe(_dataTopicIn);
 
-  return true;
+  return 1;
 }
 
 bool ArduinoIoTCloudClass::disconnect()
@@ -169,7 +169,7 @@ int ArduinoIoTCloudClass::reconnect(Client& net)
     }
   _bearSslClient = new BearSSLClient(net);
   _bearSslClient->setEccSlot(keySlot, ECCX08Cert.bytes(), ECCX08Cert.length());
-  
+
   // Initialize again the MQTTClient, otherwise it would not be able to receive messages through its callback
   mqttClientBegin(*_bearSslClient);
   // Connect to the broker

src/ArduinoIoTCloud.h

@@ -28,10 +28,10 @@ class ArduinoIoTCloudClass {
   static const int RECONNECTION_TIMEOUT = 2000;
   const mqttConnectionOptions mqttOpt = {30, false, 1500};
 
-  bool connect();
+  int  connect   ();
   bool disconnect();
 
-  void poll(); /* Attention: Function is deprecated - use 'update' instead */
+  void poll() __attribute__((deprecated)); /* Attention: Function is deprecated - use 'update' instead */
   void update();
 
   // defined for users who want to specify max reconnections reties and timeout between them