Apply suggestions from code review

zfields · pennam · zfields · commit 8ae88fce7816 · 2024-03-30T11:23:55.000-05:00
Co-authored-by: Mattia Pennasilico &lt;m.pennasilico@arduino.cc&gt;
diff --git a/examples/ArduinoIoTCloud-Advanced/ArduinoIoTCloud-Advanced.ino b/examples/ArduinoIoTCloud-Advanced/ArduinoIoTCloud-Advanced.ino
@@ -10,9 +10,6 @@
    - https://github.com/arduino-libraries/ArduinoIoTCloud#what
 */
 
-#include <ArduinoIoTCloud.h>
-
-#include "arduino_secrets.h"
 #include "thingProperties.h"
 
 void setup() {
diff --git a/examples/ArduinoIoTCloud-Advanced/arduino_secrets.h b/examples/ArduinoIoTCloud-Advanced/arduino_secrets.h
@@ -1,4 +1,4 @@
-#include <AIoTC_Config.h>
+#include <Arduino_ConnectionHandler.h>
 
 /* A complete list of supported boards with WiFi is available here:
  * https://github.com/arduino-libraries/ArduinoIoTCloud/#what
diff --git a/examples/ArduinoIoTCloud-Advanced/thingProperties.h b/examples/ArduinoIoTCloud-Advanced/thingProperties.h
@@ -1,6 +1,5 @@
 #include <ArduinoIoTCloud.h>
 #include <Arduino_ConnectionHandler.h>
-
 #include "arduino_secrets.h"
 
 #if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \
diff --git a/examples/ArduinoIoTCloud-Basic/ArduinoIoTCloud-Basic.ino b/examples/ArduinoIoTCloud-Basic/ArduinoIoTCloud-Basic.ino
@@ -14,9 +14,6 @@
    - https://github.com/arduino-libraries/ArduinoIoTCloud#what
 */
 
-#include <ArduinoIoTCloud.h>
-
-#include "arduino_secrets.h"
 #include "thingProperties.h"
 
 #if !defined(LED_BUILTIN) && !defined(ARDUINO_NANO_ESP32)
diff --git a/examples/ArduinoIoTCloud-Basic/arduino_secrets.h b/examples/ArduinoIoTCloud-Basic/arduino_secrets.h
@@ -1,4 +1,4 @@
-#include <AIoTC_Config.h>
+#include <Arduino_ConnectionHandler.h>
 
 /* A complete list of supported boards with WiFi is available here:
  * https://github.com/arduino-libraries/ArduinoIoTCloud/#what
diff --git a/examples/ArduinoIoTCloud-Basic/thingProperties.h b/examples/ArduinoIoTCloud-Basic/thingProperties.h
@@ -1,6 +1,5 @@
 #include <ArduinoIoTCloud.h>
 #include <Arduino_ConnectionHandler.h>
-
 #include "arduino_secrets.h"
 
 #if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \
diff --git a/examples/ArduinoIoTCloud-Callbacks/ArduinoIoTCloud-Callbacks.ino b/examples/ArduinoIoTCloud-Callbacks/ArduinoIoTCloud-Callbacks.ino
@@ -26,9 +26,6 @@
    - https://github.com/arduino-libraries/ArduinoIoTCloud#what
 */
 
-#include <ArduinoIoTCloud.h>
-
-#include "arduino_secrets.h"
 #include "thingProperties.h"
 
 void setup() {
diff --git a/examples/ArduinoIoTCloud-Callbacks/arduino_secrets.h b/examples/ArduinoIoTCloud-Callbacks/arduino_secrets.h
@@ -1,4 +1,4 @@
-#include <AIoTC_Config.h>
+#include <Arduino_ConnectionHandler.h>
 
 /* A complete list of supported boards with WiFi is available here:
  * https://github.com/arduino-libraries/ArduinoIoTCloud/#what
diff --git a/examples/ArduinoIoTCloud-Callbacks/thingProperties.h b/examples/ArduinoIoTCloud-Callbacks/thingProperties.h
@@ -1,6 +1,5 @@
 #include <ArduinoIoTCloud.h>
 #include <Arduino_ConnectionHandler.h>
-
 #include "arduino_secrets.h"
 
 #if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \
diff --git a/examples/ArduinoIoTCloud-DeferredOTA/ArduinoIoTCloud-DeferredOTA.ino b/examples/ArduinoIoTCloud-DeferredOTA/ArduinoIoTCloud-DeferredOTA.ino
@@ -16,9 +16,6 @@
    - https://github.com/arduino-libraries/ArduinoIoTCloud/#ota
 */
 
-#include <ArduinoIoTCloud.h>
-
-#include "arduino_secrets.h"
 #include "thingProperties.h"
 
 #if !defined(LED_BUILTIN) && !defined(ARDUINO_NANO_ESP32)
diff --git a/examples/ArduinoIoTCloud-DeferredOTA/arduino_secrets.h b/examples/ArduinoIoTCloud-DeferredOTA/arduino_secrets.h
@@ -1,4 +1,4 @@
-#include <AIoTC_Config.h>
+#include <Arduino_ConnectionHandler.h>
 
 /* A complete list of supported boards with WiFi is available here:
  * https://github.com/arduino-libraries/ArduinoIoTCloud/#what
diff --git a/examples/ArduinoIoTCloud-DeferredOTA/thingProperties.h b/examples/ArduinoIoTCloud-DeferredOTA/thingProperties.h
@@ -1,6 +1,5 @@
 #include <ArduinoIoTCloud.h>
 #include <Arduino_ConnectionHandler.h>
-
 #include "arduino_secrets.h"
 
 #if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_ETHERNET))
diff --git a/examples/ArduinoIoTCloud-Schedule/ArduinoIoTCloud-Schedule.ino b/examples/ArduinoIoTCloud-Schedule/ArduinoIoTCloud-Schedule.ino
@@ -6,9 +6,6 @@
 
 */
 
-#include <ArduinoIoTCloud.h>
-
-#include "arduino_secrets.h"
 #include "thingProperties.h"
 
 #if !defined(LED_BUILTIN) && !defined(ARDUINO_NANO_ESP32)
diff --git a/examples/ArduinoIoTCloud-Schedule/arduino_secrets.h b/examples/ArduinoIoTCloud-Schedule/arduino_secrets.h
@@ -1,4 +1,4 @@
-#include <AIoTC_Config.h>
+#include <Arduino_ConnectionHandler.h>
 
 /* A complete list of supported boards with WiFi is available here:
  * https://github.com/arduino-libraries/ArduinoIoTCloud/#what
diff --git a/examples/ArduinoIoTCloud-Schedule/thingProperties.h b/examples/ArduinoIoTCloud-Schedule/thingProperties.h
@@ -1,6 +1,5 @@
 #include <ArduinoIoTCloud.h>
 #include <Arduino_ConnectionHandler.h>
-
 #include "arduino_secrets.h"
 
 #if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \
@@ -29,16 +28,16 @@ void initProperties() {
   ArduinoCloud.setSecretDeviceKey(SECRET_DEVICE_KEY);
 #endif
 #if defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_NB) || defined(BOARD_HAS_ETHERNET) || defined(BOARD_HAS_CATM1_NBIOT)
-  ArduinoCloud.addProperty(switchButton, Permission::Write).onUpdate(nullptr);
-  ArduinoCloud.addProperty(oneShot, Permission::ReadWrite).onUpdate(nullptr);
-  ArduinoCloud.addProperty(minute, Permission::ReadWrite).onUpdate(nullptr);
-  ArduinoCloud.addProperty(hourly, Permission::ReadWrite).onUpdate(nullptr);
-  ArduinoCloud.addProperty(daily, Permission::ReadWrite).onUpdate(nullptr);
-  ArduinoCloud.addProperty(weekly, Permission::ReadWrite).onUpdate(nullptr);
-  ArduinoCloud.addProperty(monthly, Permission::ReadWrite).onUpdate(nullptr);
-  ArduinoCloud.addProperty(yearly, Permission::ReadWrite).onUpdate(nullptr);
+  ArduinoCloud.addProperty(switchButton, Permission::Write);
+  ArduinoCloud.addProperty(oneShot, Permission::ReadWrite);
+  ArduinoCloud.addProperty(minute, Permission::ReadWrite);
+  ArduinoCloud.addProperty(hourly, Permission::ReadWrite);
+  ArduinoCloud.addProperty(daily, Permission::ReadWrite);
+  ArduinoCloud.addProperty(weekly, Permission::ReadWrite);
+  ArduinoCloud.addProperty(monthly, Permission::ReadWrite);
+  ArduinoCloud.addProperty(yearly, Permission::ReadWrite);
 #elif defined(BOARD_HAS_LORA)
-  ArduinoCloud.addProperty(switchButton, 1, Permission::Write).onUpdate(nullptr);
+  ArduinoCloud.addProperty(switchButton, 1, Permission::Write);
 #endif
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-#include <AIoTC_Config.h>`
	`1`	`+#include <Arduino_ConnectionHandler.h>`
`2`	`2`
`3`	`3`	`/* A complete list of supported boards with WiFi is available here:`
`4`	`4`	`* https://github.com/arduino-libraries/ArduinoIoTCloud/#what`