Fix ota properties synchronization ensuring all ota properties are sent together in a single message.

Author: pennam

src/ArduinoIoTCloudTCP.cpp

@@ -34,15 +34,14 @@
 #endif
 
 #if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_PORTENTA_H7_M4)
-#  include <algorithm>
 #  include "tls/utility/SHA256.h"
 #  include <stm32h7xx_hal_rtc_ex.h>
 #  include <WiFi.h>
 #endif
 
 #include "utility/ota/OTA.h"
 #include "utility/ota/FlashSHA256.h"
-
+#include <algorithm>
 #include "cbor/CBOREncoder.h"
 
 #include "utility/watchdog/Watchdog.h"
@@ -516,7 +515,7 @@ ArduinoIoTCloudTCP::State ArduinoIoTCloudTCP::handle_Connected()
         /* Clear the request flag. */
         _ota_req = false;
         /* Transmit the cleared error and request flags to the cloud. */
-        sendPropertiesToCloud();
+        sendOTAPropertiesToCloud();
         /* Call member function to handle OTA request. */
         onOTARequest();
       }
@@ -581,6 +580,37 @@ void ArduinoIoTCloudTCP::sendPropertiesToCloud()
     }
 }
 
+void ArduinoIoTCloudTCP::sendOTAPropertiesToCloud()
+{
+  int bytes_encoded = 0;
+  uint8_t data[MQTT_TRANSMIT_BUFFER_SIZE];
+
+  PropertyContainer ota_property_container;
+
+  std::list<String> const ota_property_list {"OTA_CAP", "OTA_ERROR", "OTA_SHA256", "OTA_URL", "OTA_REQ"};
+  std::for_each(ota_property_list.cbegin(),
+                ota_property_list.cend(),
+                [this, &ota_property_container ] (String const & name)
+                {
+                  Property* p = getProperty(this->_property_container, name);
+                  if(p != nullptr)
+                    addPropertyToContainer(ota_property_container, *p, p->name(), p->isWriteableByCloud() ? Permission::ReadWrite : Permission::Read);
+                }
+                );
+
+  if (CBOREncoder::encode(ota_property_container, data, sizeof(data), bytes_encoded, false) == CborNoError)
+    if (bytes_encoded > 0)
+    {
+      /* If properties have been encoded store them in the back-up buffer
+       * in order to allow retransmission in case of failure.
+       */
+      _mqtt_data_len = bytes_encoded;
+      memcpy(_mqtt_data_buf, data, _mqtt_data_len);
+      /* Transmit the properties to the MQTT broker */
+      write(_dataTopicOut, _mqtt_data_buf, _mqtt_data_len);
+    }
+}
+
 void ArduinoIoTCloudTCP::requestLastValue()
 {
   // Send the getLastValues CBOR message to the cloud

src/ArduinoIoTCloudTCP.h

@@ -165,6 +165,7 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass
     static void onMessage(int length);
     void handleMessage(int length);
     void sendPropertiesToCloud();
+    void sendOTAPropertiesToCloud();
     void requestLastValue();
     int write(String const topic, byte const data[], int const length);