Bugfix: _ota_cap is false per default, but we need to set it to true if the bootloader is in fact capable of OTA support.

Author: aentinger

src/ArduinoIoTCloudTCP.cpp

@@ -191,6 +191,20 @@ int ArduinoIoTCloudTCP::begin(String brokerAddress, uint16_t brokerPort)
   addPropertyReal(_ota_req, "OTA_REQ", Permission::ReadWrite).onSync(DEVICE_WINS);
 #endif /* OTA_ENABLED */
 
+#if OTA_STORAGE_PORTENTA_QSPI
+  #define BOOTLOADER_ADDR   (0x8000000)
+  uint32_t bootloader_data_offset = 0x1F000;
+  uint8_t* bootloader_data = (uint8_t*)(BOOTLOADER_ADDR + bootloader_data_offset);
+  uint8_t currentBootloaderVersion = bootloader_data[1];
+  if (currentBootloaderVersion < 22) {
+    _ota_cap = false;
+    DBG_WARNING(F("ArduinoIoTCloudTCP::%s In order to be ready for cloud OTA, update the bootloader"), __FUNCTION__);
+  }
+  else {
+    _ota_cap = true;
+  }
+#endif
+
 #if OTA_STORAGE_SNU && OTA_ENABLED
   String const nina_fw_version = WiFi.firmwareVersion();
   if (nina_fw_version < "1.4.1") {
@@ -479,7 +493,8 @@ void ArduinoIoTCloudTCP::onOTARequest()
   /* Just to be safe delete any remains from previous updates. */
   remove("/fs/UPDATE.BIN.LZSS");
 
-  OTAPortenta.begin(QSPI_FLASH_FATFS_MBR, 2048);
+  // Use second partition
+  OTAPortenta.begin(QSPI_FLASH_FATFS_MBR, 2);
 
   if (OTAPortenta.download(_ota_url.c_str()))
   {