Merge branch 'bug/path-lib-fix' of https://github.com/glowmouse/Arduino-CMake-NG into bug/path-lib-fix

Author: glowmouse

.gitignore

@@ -116,6 +116,17 @@ crashlytics.properties
 crashlytics-build.properties
 fabric.properties
 
+### VisualStudioCode ###
+.vscode/*
+.vscode/settings.json
+!.vscode/tasks.json
+!.vscode/launch.json
+!.vscode/extensions.json
+
+### VisualStudioCode Patch ###
+# Ignore all local history of files
+.history
+
 ### User-Defined
 [Aa]ssets/*
 /examples/blink-example/Blink.cpp

.idea/codeStyles/Project.xml

@@ -0,0 +1,5 @@
+{
+    "default": true,
+    "line_length": false,
+    "no-duplicate-heading": false
+}

.markdownlint.json

@@ -0,0 +1,6 @@
+[
+    {
+        "name": "Arduino-CMake-Toolchain",
+        "toolchainFile": "${workspaceRoot}/cmake/Arduino-Toolchain.cmake"
+    }
+]

.vscode/cmake-kits.json

@@ -44,8 +44,8 @@ It mostly addressed *3rd Party Libraries*.
 
   Besides,  the following sub-directories are searched under every path mentioned above:
 
-  - **libraries**
-  - **dependencies**
+  * **libraries**
+  * **dependencies**
 
 * 3rd Party Arduino Libraries do not longer have to include the **library.properties** file in their root directory - Their root directory is searched instead.  
   Nevertheless including the file is still ***recommended***, because when the file isn't present, the framework can't infer potentially required metadata from it.
@@ -96,9 +96,9 @@ This version refactored the Sketch API entirely to enhance support for missing f
 
 ### New Features
 
-- Headers included in a sketch file are now resolved to provide better insight
-  - Arduino/Platform libraries that are resolved from a sketch's headers are linked to the target
-- Option/Policy to "forcefully" convert a sketch to a source file when adding it to a target, even if the source file already exists (Usually means that sketch has already been converted).   
+* Headers included in a sketch file are now resolved to provide better insight
+  * Arduino/Platform libraries that are resolved from a sketch's headers are linked to the target
+* Option/Policy to "forcefully" convert a sketch to a source file when adding it to a target, even if the source file already exists (Usually means that sketch has already been converted).  
   By default it's set to **OFF**.
 
 ### Changes
@@ -195,4 +195,3 @@ Although basic, there's a lot that had to be done in order to reach a somewhat "
   * Parsing the `platform.txt` file is an entirely new concept that hasn't been used until now in all forks of the old Arduino-CMake. In fact, this is what allows the framework to be truly platform-agnostic, as it defines the platform's core behavior
 
 Many more subtle and internal features have been implemented, but they won't be listed here.
-

CHANGELOG.md

@@ -2,25 +2,30 @@
 
 ## Short Brief ##
 
-### What is this file? ###
+### What is this file ###
+
 It is a set of guidance rules for developers who'd like to contribute to this repo.  
 Versions go forward, new features are added, the API can change, but sometimes  - Documentation doesn't keep the pace, unfortunately.  
 To address those issues and allow developers to contribute good, quality code - This file must exist and always be up to date.
 
 ### Dear Contributors ###
+
 First of all, thank you for taking your time even considering contributing to this repo.  
 It is extremely important to us that you, ordinary users or continuous collaborators, contribute to this project in a combined effort to make it greater, stable than ever before.  
 
 ## Submitting Issues ##
+
 New features and bug reports keep the project moving forward and getting better.  
 This is partly your duty, the user, to request those features and report the bugs.
 
 ### Before you submit an issue ###
+
 * Please make sure your'e using the latest version of **Arduino CMake**.  
   Generally it's the [latest release](https://github.com/arduino-cmake/Arduino-CMake-NG/releases), unless said otherwise by any of the maintainers.
 * Go over the existing issue list (including closed ones) to make sure your issue hasn't already been reported or fixed.
 
-### Submitting a good issue ### 
+### Submitting a good issue ###
+
 Issues can be submitted with a very short description, but that would make the life of the developers addressing it very hard, leading to unresolved issues due to lack of information.  
 
 Here is a set of rules you should apply to **every** issue you submit:
@@ -30,11 +35,11 @@ Here is a set of rules you should apply to **every** issue you submit:
 * If the issue regards a special behavior, maybe related to a specific board - Please tell us all you know about it and put some links to external sources if those exist
 * Use Markdown formatting as appropriate to make the issue and code more readable
 
-#### Issue Signature
+#### Issue Signature ####
 
 At last, you should sign your issue with a special signature, following the next format:
 
-```
+```None
 OS: [Windows|OSx/MacOS|Linux]
 Distribution (Linux Only): [Fedora|Debian|Ubuntu|CentOS] etc.
 OS Version: [Version]
@@ -48,9 +53,10 @@ Platform SDK Version: [Version]
 * SDK versions usually have the form of [major].[minor].[patch], such as 1.8.5.
 * OS Distribution should be mentioned only for Linux-based OSs
 
-## Code Contribution
+## Code Contribution ##
+
+### Code Style ###
 
-### Code Style
 Like most projects, **Arduino-CMake** uses its own coding style which ensures that everybody can easily read and change files without the hassle of reading 3 different indentation styles paired 4 ways of brace spacing.
 
 While we believe that the coding style you are using benefits you, please try and stick to the project's accepted style as close as possible.  
@@ -59,24 +65,26 @@ It will take care of the some of the greatest hassles like indentation, new line
 As for spacing, naming conventions, etc.  - Please look at existing code to get an idea of the style.  
 If you use an Jetbrains `IDEA` based IDE (for example `CLion`), chances are that the auto formatting functionality will take care of things due to the project's `codeStyleSettings.xml` residing in the repository.
 
-### Versioning
-This project follows the [semantic versioning](http://semver.org/spec/v2.0.0.html).   
+### Versioning ###
+
+This project follows the [semantic versioning](http://semver.org/spec/v2.0.0.html).  
 It also allows easy integration with our [Workflow Model](#Project Workflow), which is described next.
 
-### Project Workflow
+### Project Workflow ###
 
 Up to version *0.6*, included, this project followed Git's [Classic Workflow Model](http://nvie.com/posts/a-successful-git-branching-model), allowing developers to work on multiple features simultaneously without clashing. This model is a bit different than suggested by **GitHub**, intended mostly for offline Git repositories.  
 For this reason the project has adapted the model to GitHub's model from version *0.6.x* and above.
 
 The elements of the adapted model are thoroughly described in the following sections.
 
-#### Bug Fixes
+#### Bug Fixes ####
+
 Bug fixes can be found in the *stable release* or in a *developed feature*.  
 The way we treat them is different, described in the next sections.
 
 **Note:** Before claiming to find a bug, make sure you are on the latest commit of that branch.
 
-##### Release Bugs/Critical Bugs
+##### Release Bugs/Critical Bugs #####
 
 Those are the ones with the highest priority to fix. If you encounter such a bug you should immediately submit a new issue. Before you submit, please see [Submitting Issues](#Submitting-Issues).  
 If you'd like to fix the bug yourself, please **state that** in the issue.
@@ -89,73 +97,76 @@ A better name would be `hotfix/platform-libraries-reloading`.
 According to our [Workflow model](#Project-Workflow), once the hotfix is finished one should:
 
 1. Add a tag to the *merge-commit* named after the patched version.
-   e.g If the current stable version is v2.1.0, the hotfix should make it v2.1.1 (Bump the patch number). 
+   e.g If the current stable version is v2.1.0, the hotfix should make it v2.1.1 (Bump the patch number).  
 2. Pull-Request directly to **master**
 
 The [Classic Workflow Model](http://nvie.com/posts/a-successful-git-branching-model) lists that a hotfix should be *merged* to both **master** and **develop**, however, GitHub doesn't play nicely with this exact model and basically allows only one of the branches to exist in such a workflow that respects *Pull-Requests* (Instead of *merges*) on one side, and the Workflow model on another.
 
-**Note to Maintainers/Collaborators:** 
+**Note to Maintainers/Collaborators:**  
 If an active **release** branch exists when the hotfix is integrated, meaning there's an on-going release, the hotfix should be also be *merged* to the **release** branch, optionally from the **master** branch if a *merge* from the hotfix branch isn't possible.
 
-##### Development Bugs
+##### Development Bugs #####
 
 These exist in **feature** branches or the **master** branch - Code that's planned for future releases and considered in development.  
 However, these still need to be reported by submitting relevant issues. You should also specify if your'e attempting to fix them.
 
 Fixes to such bugs should be made on a separate branch, preferably in a forked version, named after the bug. Once finished, you should PR it to the appropriate **feature** branch or directly to the **master** branch - depending on where you found them.  
 If the **feature** branch has already been merged to **master**, you should simply PR directly to **master**.
 
-#### New Features
+#### New Features ####
+
 To ensure your contribution makes it into the mainline codebase, always check the **master** branch for the next targeted release.  
-Make sure your contribution is on par with that branch, then PR directly into **master**. 
+Make sure your contribution is on par with that branch, then PR directly into **master**.  
 This strategy should be the right one for most users.  
 If you want to make further additions to a feature currently under development, you can also PR into the corresponding **feature** branch.
 
-##### Feature Branch Naming
+##### Feature Branch Naming #####
 
 **Feature** branch names should be short and descriptive, each word separated by a single hyphen (`-`).
 e.g A branch named `feature/blacklisting-libraries-to-avoid-automatic-inclusion-when-reloading-cmake` is a bad branch name because it's too long, even though it's very descriptive.  
 A better name would be `feature/library-blacklist` because it's short and generally descriptive.  
 
 Any further description would be written in commit messages or the final PR to the **master** branch.
 
-#### Releases
+#### Releases ####
 
 When a handful of features is complete, the developed product is ready for release.
 According to our [Workflow model](#Project-Workflow), every release should start with a branch named after the *about-to-be-released* version. e.g `release/2.0.0`.
 
 There are some strict rules we apply to our releases:
 
-* At any given moment there should be a <u>single release</u> **or** <u>no release at all</u>. 
+* At any given moment there should be a *single release* **or** *no release at all*.  
   We're not working Agile on this project, thus there's no need for multiple simultaneous releases.
 * Once existing, any hotfix should be merged to the **release** branch as well as to the **master** branch (See [Release Bugs](#Release-Bugs/Critical-Bugs)).
-* Any last-minute bug-fixes should be made directly on the **release** branch. 
+* Any last-minute bug-fixes should be made directly on the **release** branch.  
   They will be merged later to the **master** branch once the release is completed.
-* New features developed after the release has been started are intended for the <u>**next** release</u> - They should be merged only to the **master** branch!
-* Before completing the release: 
+* New features developed after the release has been started are intended for the _**next** release_ - They should be merged only to the **master** branch!
+* Before completing the release:  
   * Documentation should be up-to-date (Currently maintained in GitHub Wiki)
   * **Changelog** file should be updated accordingly
   * **Authors** file should be updated accordingly
 
 Once the release is complete it is merged to the **master** branch.  
 A tag with the final release version is also added to the *merge-commit* on **master**.
 
-### Pull Requests
+### Pull Requests ###
 
 At GitHub we support merging by Pull-Requesting.  
 It helps us document code better, as well as discussing and reviewing a change before it gets into the mainline codebase.
 
-Please make a Pull Request for every change you'd like to make, yes, <u>even if your'e an maintainer or a collaborator</u>.
+Please make a Pull Request for every change you'd like to make, yes, *even if your'e an maintainer or a collaborator*.
 
 Also note that we do have a strict rule about the branch your'e PRing from - Once it gets merged, it will be probably get deleted. This is done to avoid unnecessary cluttering of the project.  
 If you need to keep the branch for some reason, please state it in **bold** in the PR's description, so that the merging user will notice it.
 
-### Breaking Changes
+### Breaking Changes ###
+
 Breaking changes require the release of a new major version according to [semantic versioning](#Versioning) rules.  
 If your'e making changes to the **public** interface (API) that are not backwards-compatible, make sure it is **absolutely** necessary.
 
-### Changelog
+### Changelog ###
+
 All project changes, new features and bug fixes are documented in `CHANGELOG.md`.  
-<u>**Maintainers**</u> - For any contribution, please add a corresponding changelog entry.  
+**Maintainers** - For any contribution, please add a corresponding changelog entry.  
 Bump the patch version for bug fixes and the minor version for feature additions.  
 Don't **ever** bump the major version on your behalf - It should be done only by the maintainers of the project.

CONTRIBUTING.md

@@ -12,19 +12,19 @@ Wait - Hasn't it been possible all this time? Apparently not. You can read more
 **Arduino-CMake** should<sup id="fl1">[1](#f1)</sup> do almost<sup id="fl2">[2](#f2)</sup> <u>anything</u> that the **Arduino IDE** does!  
 Here's a list of features **already supported** by **Arduino-CMake**:
 
-- Creating Arduino "Executables"/Programs
-- Uploading programs to hardware boards
-- Adding/Finding and using Arduino Libraries
-  - 3rd Party libraries are fully supported
-  - User libraries which are not Arduino Libraries are also supported
-- Using Arduino example programs
-  - Using Arduino library example programs
-- Attaching Arduino sketches (`.ino` files) to programs
+* Creating Arduino "Executables"/Programs
+* Uploading programs to hardware boards
+* Adding/Finding and using Arduino Libraries
+  * 3rd Party libraries are fully supported
+  * User libraries which are not Arduino Libraries are also supported
+* Using Arduino example programs
+  * Using Arduino library example programs
+* Attaching Arduino sketches (`.ino` files) to programs
 
 Moreover, **Arduino-CMake** allows some things that **Arduino IDE** *doesn't*:
 
-- Developing Arduino programs in any IDE or text editor
-- Completely customizing the build process per user's requirements
+* Developing Arduino programs in any IDE or text editor
+* Completely customizing the build process per user's requirements
 
 What's **not** supported?  
 
@@ -76,9 +76,9 @@ And yet, it still had its own problems, leading once again to an abandoned state
 
 Then, in 2018, an extreme effort has been made and the project has been completely rewritten (mostly by [MrPointer](https://github.com/MrPointer)) with a few very clear goals in mind:
 
-- **Platform-Independent** - The framework shouldn't assume it works only with the basic Arduino platform, as there are many others out there. Any platform that confront to the design of the basic Arduino SDK is appropriate for use. An example of such a platform is ESP32.
-- **Modern CMake** - All previous projects/forks have been using the fairly old CMake 2.8. CMake itself has transitioned much from version 2 to 3, benefiting from a whole lot of new exciting features. Even the official package managers support CMake 3 versions, so there's no excuse to not use it.
-- **Modern Arduino SDK** - The Arduino SDK, much like CMake, has also undergone several major changes during the years, especially with version 1.6. The Arduino SDK has only recently got stable, and that's why we recommend always having the latest version installed, although we do have some minimum requirements for the framework to even work. You can find them at the Requirements section.
+* **Platform-Independent** - The framework shouldn't assume it works only with the basic Arduino platform, as there are many others out there. Any platform that confront to the design of the basic Arduino SDK is appropriate for use. An example of such a platform is ESP32.
+* **Modern CMake** - All previous projects/forks have been using the fairly old CMake 2.8. CMake itself has transitioned much from version 2 to 3, benefiting from a whole lot of new exciting features. Even the official package managers support CMake 3 versions, so there's no excuse to not use it.
+* **Modern Arduino SDK** - The Arduino SDK, much like CMake, has also undergone several major changes during the years, especially with version 1.6. The Arduino SDK has only recently got stable, and that's why we recommend always having the latest version installed, although we do have some minimum requirements for the framework to even work. You can find them at the Requirements section.
 
 ### How it works
 
@@ -89,7 +89,7 @@ But what's really useful in CMake, at least regarding our Arduino world, is the
 The Arduino SDK, which one usually downloads together with the Arduino IDE, is actually also a toolchain, as it includes the required compilation & linkage tools for cross-compiling.
 Analyzing the SDK allows us to build a framework using this toolchain, and also all of Arduino's other cool features such as *libraries, examples*, etc.
 
-### What is NG?
+### What is NG
 
 NG stands for "New Generation".
 Inferred from the written above, it can easily be understood why the project has this name.

README.md

@@ -31,6 +31,10 @@ endfunction()
 #=============================================================================#
 function(resolve_library_architecture _library_sources _return_var)
 
+    if(NOT _library_sources)
+        return()
+    endif()
+
     cmake_parse_arguments(parsed_args "" "LIB_PROPS_FILE" "" ${ARGN})
 
     if (parsed_args_LIB_PROPS_FILE) # Library properties file is given