Fixed platform libs bug completely.

It appears that an existing platform lib target has been rebuilding on each subsequent cmake run even though it shouldn't. Now it's created and linked as a valid Arduino-CMake library once, then linked as an existing target.

Author: MrPointer

cmake/Platform/Targets/ArduinoCMakeLibraryTarget.cmake

@@ -73,7 +73,7 @@ function(_link_arduino_cmake_library _target_name _library_name)
         message(FATAL_ERROR "Target doesn't exist - It must be created first!")
     endif ()
 
-    set(scope_options "PRIVATE" "PUBLIC" "INTERFACE" "PLATFORM_LIB")
+    set(scope_options "PRIVATE" "PUBLIC" "INTERFACE")
     cmake_parse_arguments(link_library "${scope_options}" "BOARD_CORE_TARGET" "" ${ARGN})
 
     # First, include core lib's directories in library as well
@@ -85,9 +85,7 @@ function(_link_arduino_cmake_library _target_name _library_name)
 
     get_target_property(core_lib_includes ${core_target} INCLUDE_DIRECTORIES)
     target_include_directories(${_library_name} PUBLIC "${core_lib_includes}")
-    if (NOT link_library_PLATFORM_LIB)
-        target_link_libraries(${_library_name} PUBLIC ${core_target})
-    endif ()
+    target_link_libraries(${_library_name} PUBLIC ${core_target})
 
     # Now, link library to executable
     if (link_library_PUBLIC)

cmake/Platform/Targets/PlatformLibraryTarget.cmake

@@ -48,12 +48,12 @@ function(link_platform_library _target_name _library_name _board_id)
 
     if (NOT TARGET ${_library_name})
         _add_platform_library(${_library_name} ${_board_id})
+        get_core_lib_target_name(${_board_id} core_lib_target)
+        _link_arduino_cmake_library(${_target_name} ${_library_name}
+                PUBLIC
+                BOARD_CORE_TARGET ${core_lib_target})
+    else ()
+        target_link_libraries(${_target_name} PUBLIC ${_library_name})
     endif ()
 
-    get_core_lib_target_name(${_board_id} core_lib_target)
-    _link_arduino_cmake_library(${_target_name} ${_library_name}
-            PUBLIC PLATFORM_LIB
-            BOARD_CORE_TARGET ${core_lib_target})
-    #target_link_libraries(${_target_name} PUBLIC ${_library_name})
-
 endfunction()