Fixed bug in sketch header resolving where Arduino libraries couldn't be linked.

Renamed `ArduinoLibraryParser` module to `PlatformLibraryUtils` as it's a better suited name.
Added a utility function to check if a given name resolves to a platform library.

Author: MrPointer

cmake/Platform/Arduino.cmake

@@ -12,6 +12,7 @@ include(MathUtils)
 include(ListUtils)
 include(StringUtils)
 include(PropertyUtils)
+include(PlatformLibraryUtils)
 
 include(BoardManager)
 include(RecipeParser)

cmake/Platform/Sketches/SketchHeadersManager.cmake

@@ -35,16 +35,18 @@ function(resolve_sketch_headers _target_name _board_id _sketch_file)
         # So first we should check whether it's a library
         get_name_without_file_extension("${header}" header_we)
 
-        if (${header_we} IN_LIST ARDUINO_CMAKE_PLATFORM_LIBRARIES)
-            link_platform_library(${_target_name} ${header_we} ${_board_id})
+        is_platform_library(${header_we} is_header_platform_lib)
+        if (is_header_platform_lib)
+            string(TOLOWER ${header_we} header_we_lower)
+            link_platform_library(${_target_name} ${header_we_lower} ${_board_id})
         else ()
             find_arduino_library(${header_we}_sketch_lib ${header_we} ${_board_id})
             # If library isn't found, display a wraning since it might be a user library
-            if (NOT ${header_we}_sketch_lib OR "${${header_we}_sketch_lib}" MATCHES "NOTFOUND")
+            if (NOT TARGET ${header_we}_sketch_lib OR "${${header_we}_sketch_lib}" MATCHES "NOTFOUND")
                 _validate_target_includes_header(${_target_name} ${header} is_header_validated)
                 if (NOT is_header_validated)
                     # Header hasn't been found in any of the target's include directories, Display warning
-                    message(WARNING "The header '${_header}' is used by the \
+                    message(WARNING "The header '${header_we}' is used by the \
                                      '${_sketch_file}' sketch \
                                      but it isn't a Arduino/Platform library, nor it's linked \
                                      to the target manually!")

cmake/Platform/Targets/PlatformLibraryTarget.cmake

@@ -1,5 +1,3 @@
-include(ArduinoLibraryParser)
-
 #=============================================================================#
 # Looks for any platform libraries (Resolved earlier when platform has been initialized)
 # within the given sources and returns them in a list.

cmake/Platform/Other/ArduinoLibraryParser.cmake renamed to cmake/Platform/Utilities/PlatformLibraryUtils.cmake

@@ -1,3 +1,22 @@
+#=============================================================================#
+# Checks whether the given name resolves to one of the platform libraries' names.
+#       _name - Name to check.
+#       _return_var - Name of variable in parent-scope holding the return value.
+#       Returns - True if name resolves to a platform library's name, false otherwise.
+#=============================================================================#
+function(is_platform_library _name _return_var)
+
+    string(TOLOWER "${_name}" name_lower)
+    if ("${name_lower}" IN_LIST ARDUINO_CMAKE_PLATFORM_LIBRARIES)
+        set(lib_found TRUE)
+    else ()
+        set(lib_found FALSE)
+    endif ()
+
+    set(${_return_var} ${lib_found} PARENT_SCOPE)
+
+endfunction()
+
 #=============================================================================#
 # Retrieves all registered platform library names from the given list of names,
 # which usually resolves to names of headers included by a source file.
@@ -8,6 +27,7 @@
 function(get_platform_libraries_from_names _names _return_var)
 
     foreach (name ${_names})
+        # Can't use `is_platform_library` function since it returns just a boolean
         string(TOLOWER "${name}" name_lower)
         if ("${name_lower}" IN_LIST ARDUINO_CMAKE_PLATFORM_LIBRARIES)
             list(APPEND platform_libs "${name}")
@@ -17,3 +37,4 @@ function(get_platform_libraries_from_names _names _return_var)
     set(${_return_var} ${platform_libs} PARENT_SCOPE)
 
 endfunction()
+