Skip to content

Commit d008074

Browse files
committed
video player: Better feedback when trying to create pipeline video
player Respond with a detailed error message, that pipeline playback is not yet implemented instead of just "video player creation failed".
1 parent c2ed358 commit d008074

File tree

1 file changed

+9
-4
lines changed
  • src/plugins/gstreamer_video_player

1 file changed

+9
-4
lines changed

src/plugins/gstreamer_video_player/plugin.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1201,11 +1201,16 @@ static int on_create_v2(const struct raw_std_value *arg, FlutterPlatformMessageR
12011201
free(uri);
12021202
uri = NULL;
12031203
} else if (pipeline != NULL) {
1204-
player = gstplayer_new_from_pipeline(flutterpi, pipeline, NULL);
1205-
1206-
// gstplayer_new_from_network will dup the pipeline internally.
12071204
free(pipeline);
1208-
pipeline = NULL;
1205+
1206+
/// TODO: Implement
1207+
1208+
return platch_respond_error_std(
1209+
responsehandle,
1210+
"unimplemented",
1211+
"Creating players from pipeline is not supported yet for the playbin-based video player.",
1212+
NULL
1213+
);
12091214
} else {
12101215
UNREACHABLE();
12111216
}

0 commit comments

Comments
 (0)