initial multidisplay work

- add multidisplay plugin stub
- make compositor multiview capable
  - use klib (khash) to implement the
    view id -> window mapping
- split drmdev into drm_resources and drmdev
  - drmdev: (mostly) non-stateful part. Basically a
    better wrapper around a drm fd. mt-safe
  - drm_resources: the DRM state / resources.
    is stateful, but does not update itself.
    To keep it in sync with kernel state,
    one needs to listen to kernel events with
    drm_monitor and call drm_resources_update.
  - drm_resources is not mt-safe and only
    supposed to be used on a single thread.
  - add a bunch of QoL stuff to drm_resources
- use evloop as platform and raster thread
  event loop (mt-safe wrapper around sd-event)
- add own mutex type & fns with thread safety annotations
- generally refactor flutter-pi.c and drmdev
- fix function mixup in sentry plugin

Author: ardera

CMakeLists.txt

@@ -55,7 +55,7 @@ option(ENABLE_MTRACE "True if flutter-pi should call GNU mtrace() on startup." O
 option(ENABLE_TESTS "True if tests should be built. Requires Unity to be checked out at third_party/Unity." OFF)
 option(ENABLE_SESSION_SWITCHING "True if flutter-pi should be built with session switching support. Requires libseat-dev to be installed." ON)
 option(TRY_ENABLE_SESSION_SWITCHING "Don't throw an error if libseat isn't found, instead just build without session switching support in that case." ON)
-option(LTO "Check for IPO/LTO support and enable, if supported. May require gold/lld when building with clang. (Either using `-fuse-ld` in CMAKE_C_FLAGS or by setting as the default system linker.) Only applies to Release or RelWithDebInfo build types." ON)
+option(LTO "Enable LTO. Does not work with all toolchains. May require gold/lld when building with clang. (Either using `-fuse-ld` in CMAKE_C_FLAGS or by setting as the default system linker.) Only applies to Release or RelWithDebInfo build types." OFF)
 option(LINT_EGL_HEADERS "Set an define that'll make the egl.h only export the extension definitions, prototypes that are explicitly marked as required." OFF)
 option(DEBUG_DRM_PLANE_ALLOCATIONS "Add logging in modesetting.c for debugging the process of choosing a fitting DRM plane for a framebuffer layer." OFF)
 option(USE_LEGACY_KMS "Force the use of legacy KMS." OFF)
@@ -80,7 +80,7 @@ endif()
 if (BUILD_SENTRY_PLUGIN)
   set(flutterpi_languages C CXX ASM)
 else()
-  set(flutterpi_languages C ASM)
+  set(flutterpi_languages C)
 endif()
 
 project(flutter-pi LANGUAGES ${flutterpi_languages} VERSION "1.0.0")
@@ -89,6 +89,7 @@ message(STATUS "Generator .............. ${CMAKE_GENERATOR}")
 message(STATUS "Build Type ............. ${CMAKE_BUILD_TYPE}")
 
 include(CheckCCompilerFlag)
+include(CheckCXXCompilerFlag)
 
 # Those libraries we definitely need.
 include(FindPkgConfig)
@@ -127,8 +128,12 @@ add_library(
   src/platformchannel.c
   src/pluginregistry.c
   src/texture_registry.c
-  src/modesetting.c
-  src/util/collection.c
+  src/kms/drmdev.c
+  src/kms/req_builder.c
+  src/kms/resources.c
+  src/kms/monitor.c
+  src/util/event_loop.c
+  src/util/lock_ops.c
   src/util/bitscan.c
   src/util/vector.c
   src/cursor.c
@@ -425,6 +430,7 @@ if (ENABLE_TSAN)
   target_link_options(flutterpi_module PUBLIC -fsanitize=thread)
   target_compile_options(flutterpi_module PUBLIC -fsanitize=thread)
 endif()
+
 if (ENABLE_ASAN)
   # when we use asan, we need to force linking against the C++ stdlib.
   # If we don't link against it, and load a dynamic library that's linked against the C++ stdlib (like the flutter engine),
@@ -435,8 +441,9 @@ if (ENABLE_ASAN)
   target_link_options(flutterpi_module PUBLIC -fsanitize=address -fno-omit-frame-pointer -Wl,--no-as-needed)
   target_compile_options(flutterpi_module PUBLIC -fsanitize=address)
 
-  check_c_compiler_flag(-static-libasan HAVE_STATIC_LIBASAN)
-  if (HAVE_STATIC_LIBASAN)
+  check_c_compiler_flag(-static-libasan HAVE_C_STATIC_LIBASAN)
+  check_cxx_compiler_flag(-static-libasan HAVE_CXX_STATIC_LIBASAN)
+  if (HAVE_C_STATIC_LIBASAN AND HAVE_CXX_STATIC_LIBASAN)
     target_link_options(flutterpi_module PUBLIC -static-libasan)
   endif()
 endif()
@@ -464,84 +471,19 @@ install(TARGETS flutter-pi RUNTIME DESTINATION bin)
 
 # Enable lto if supported.
 cmake_policy(SET CMP0069 NEW)
-include(CheckIPOSupported)
 # include(CheckLinkerFlag)
 
 set(USE_LTO OFF)
 # set(NEEDS_GOLD OFF)
 # set(NEEDS_LLD OFF)
 if(LTO AND (CMAKE_BUILD_TYPE STREQUAL Release OR CMAKE_BUILD_TYPE STREQUAL RelWithDebInfo))
-  # So people can specify `-fuse-ld=lld` in the CMAKE_C_FLAGS.
-  # Otherwise check_ipo_supported will not use CMAKE_C_FLAGS.
-  if (POLICY CMP0138)
-    cmake_policy(SET CMP0138 NEW)
-  endif()
-
-  check_ipo_supported(RESULT IPO_SUPPORTED OUTPUT IPO_SUPPORT_OUTPUT)
-  if (NOT IPO_SUPPORTED)
-    message(WARNING "IPO/LTO was requested in the configure options, but is not supported by the toolchain. Check CMakeFiles/CMakeError.log for details.")
-  endif()
-
-  # Try to enable IPO with gold and lld.
-  # Needs CMP0138.
-  # (untested because CMP0138 required CMake 3.24, that's why it's commented out)
-  # if (NOT IPO_SUPPORTED)
-  #   check_linker_flag(C "-fuse-ld=gold" SUPPORTS_GOLD)
-  #   if (SUPPORTS_GOLD)
-  #     set(OLD_CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
-  #
-  #     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fuse-ld=gold")
-  #     try_compile()
-  #     check_ipo_supported(RESULT IPO_SUPPORTED_WITH_GOLD OUTPUT IPO_SUPPORT_OUTPUT)
-  #     if (IPO_SUPPORTED_WITH_GOLD)
-  #       set(IPO_SUPPORTED ON)
-  #       set(NEEDS_GOLD ON)
-  #     endif()
-  #
-  #     set(CMAKE_C_FLAGS "${OLD_CMAKE_C_FLAGS}")
-  #   endif()
-  #
-  #   check_linker_flag(C "-fuse-ld=lld" SUPPORTS_LLD)
-  #   if (SUPPORTS_LLD)
-  #     set(OLD_CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
-  #
-  #     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fuse-ld=lld")
-  #     check_ipo_supported(RESULT IPO_SUPPORTED_WITH_LLD OUTPUT IPO_SUPPORT_OUTPUT)
-  #     if (IPO_SUPPORTED_WITH_LLD)
-  #       set(IPO_SUPPORTED ON)
-  #       set(NEEDS_LLD ON)
-  #     endif()
-  #
-  #     set(CMAKE_C_FLAGS "${OLD_CMAKE_C_FLAGS}")
-  #   endif()
-  # endif()
-
-  # clang doesn't support LTO when using GNU ld.
-  if(IPO_SUPPORTED AND ("${CMAKE_C_COMPILER_ID}" STREQUAL "Clang"))
-    execute_process(COMMAND ${CMAKE_C_COMPILER} -Wl,--version OUTPUT_VARIABLE LINKER_VERSION_OUTPUT ERROR_QUIET)
-    if("${LINKER_VERSION_OUTPUT}" MATCHES "GNU ld")
-      message(WARNING "IPO/LTO was requested, but is not supported when using clang with GNU ld as the linker. Try setting gold or lld as the system linker.")
-      set(IPO_SUPPORTED OFF)
-    endif()
-  endif()
-
-  if (IPO_SUPPORTED)
-    set(USE_LTO ON)
-  endif()
+  set(USE_LTO ON)
 endif()
 
 message(STATUS "IPO/LTO ................ ${USE_LTO}")
 if (USE_LTO)
   set_property(TARGET flutterpi_module PROPERTY INTERPROCEDURAL_OPTIMIZATION TRUE)
   set_property(TARGET flutter-pi PROPERTY INTERPROCEDURAL_OPTIMIZATION TRUE)
-  # if (NEEDS_GOLD)
-  #   Technically specifying only for one would suffice.
-  #   target_link_options(flutterpi_module PUBLIC "-fuse-ld=gold")
-  #   target_link_options(flutter-pi PUBLIC "-fuse-ld=gold")
-  # elseif (NEEDS_LLD)
-  #   target_link_options(flutterpi_module PUBLIC "-fuse-ld=lld")
-  #   target_link_options(flutter-pi PUBLIC "-fuse-ld=lld")
-  # endif()
 endif()
 
 if(ENABLE_TESTS)

CMakePresets.json

@@ -2,8 +2,8 @@
     "version": 2,
     "configurePresets": [
         {
-            "name": "default",
-            "displayName": "Default OpenGL host build",
+            "name": "default-debug",
+            "displayName": "Default OpenGL host build (Debug)",
             "description": "Sets Ninja generator, build and install directory",
             "generator": "Ninja",
             "binaryDir": "${sourceDir}/out/build/${presetName}",
@@ -20,7 +20,40 @@
                 "BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN": true,
                 "TRY_BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN": false,
                 "BUILD_SENTRY_PLUGIN": true,
-                "ENABLE_TESTS": true
+                "ENABLE_TESTS": true,
+                "ENABLE_ASAN": true
+            }
+        },
+        {
+            "name": "default-relwithdebinfo",
+            "displayName": "Default OpenGL host build (Release with Debug Info)",
+            "description": "Sets Ninja generator, build and install directory",
+            "generator": "Ninja",
+            "binaryDir": "${sourceDir}/out/build/${presetName}",
+            "cacheVariables": {
+                "CMAKE_BUILD_TYPE": "RelWithDebInfo",
+                "CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}",
+                "ENABLE_OPENGL": true,
+                "BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN": true,
+                "BUILD_SENTRY_PLUGIN": true,
+                "ENABLE_TESTS": false,
+                "ENABLE_ASAN": false
+            }
+        },
+        {
+            "name": "default-release",
+            "displayName": "Default OpenGL host build (Release)",
+            "description": "Sets Ninja generator, build and install directory",
+            "generator": "Ninja",
+            "binaryDir": "${sourceDir}/out/build/${presetName}",
+            "cacheVariables": {
+                "CMAKE_BUILD_TYPE": "Release",
+                "CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}",
+                "ENABLE_OPENGL": true,
+                "BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN": true,
+                "BUILD_SENTRY_PLUGIN": true,
+                "ENABLE_TESTS": false,
+                "ENABLE_ASAN": false
             }
         },
         {