gstplayer, video player: add tracing

ardera · ardera · commit 98215b19a350 · 2025-06-07T18:56:48.000+02:00
diff --git a/src/plugins/gstplayer.c b/src/plugins/gstplayer.c
@@ -447,7 +447,10 @@ static int apply_playback_state(struct gstplayer *player) {
 
     TRACER_BEGIN(player->tracer, "apply_playback_state()");
 
+    TRACER_BEGIN(player->tracer, "gst_element_get_state()");
     ok = gst_element_get_state(player->pipeline, &current_state, &pending_state, 0);
+    TRACER_END(player->tracer, "gst_element_get_state()");
+
     if (ok == GST_STATE_CHANGE_FAILURE) {
         LOG_PLAYER_DEBUG(
             player,
@@ -478,7 +481,10 @@ static int apply_playback_state(struct gstplayer *player) {
         if (player->has_desired_position) {
             position = player->desired_position_ms * GST_MSECOND;
         } else {
+            TRACER_BEGIN(player->tracer, "gst_element_query_position()");
             ok = gst_element_query_position(GST_ELEMENT(player->pipeline), GST_FORMAT_TIME, &position);
+            TRACER_END(player->tracer, "gst_element_query_position()");
+            
             if (ok == FALSE) {
                 LOG_PLAYER_ERROR(player, "Could not get the current playback position to apply the playback speed.\n");
                 goto fail_stop_trace;
@@ -509,6 +515,7 @@ static int apply_playback_state(struct gstplayer *player) {
                 GST_TIME_ARGS(GST_CLOCK_TIME_NONE)
             );
 
+            TRACER_BEGIN(player->tracer, "gst_element_seek()");
             ok = gst_element_seek(
                 GST_ELEMENT(player->pipeline),
                 desired_rate,
@@ -517,6 +524,8 @@ static int apply_playback_state(struct gstplayer *player) {
                 GST_SEEK_TYPE_SET, position,
                 GST_SEEK_TYPE_SET, GST_CLOCK_TIME_NONE
             );
+            TRACER_END(player->tracer, "gst_element_seek()");
+
             if (ok == FALSE) {
                 LOG_PLAYER_ERROR(
                     player,
@@ -534,6 +543,8 @@ static int apply_playback_state(struct gstplayer *player) {
                 GST_TIME_ARGS(0),
                 GST_TIME_ARGS(position)
             );
+
+            TRACER_BEGIN(player->tracer, "gst_element_seek()");
             ok = gst_element_seek(
                 GST_ELEMENT(player->pipeline),
                 desired_rate,
@@ -542,6 +553,7 @@ static int apply_playback_state(struct gstplayer *player) {
                 GST_SEEK_TYPE_SET, 0,
                 GST_SEEK_TYPE_SET, position
             );
+            TRACER_END(player->tracer, "gst_element_seek()");
 
             if (ok == FALSE) {
                 LOG_PLAYER_ERROR(
@@ -580,7 +592,9 @@ static int apply_playback_state(struct gstplayer *player) {
             gst_element_state_get_name(desired_state)
         );
 
+        TRACER_BEGIN(player->tracer, "gst_element_set_state()");
         ok = gst_element_set_state(player->pipeline, desired_state);
+        TRACER_END(player->tracer, "gst_element_set_state()");
 
         if (ok == GST_STATE_CHANGE_FAILURE) {
             LOG_GST_SET_STATE_ERROR(player, player->pipeline);
@@ -597,7 +611,10 @@ static int apply_playback_state(struct gstplayer *player) {
             gst_element_state_get_name(desired_state)
         );
 
+        TRACER_BEGIN(player->tracer, "gst_element_set_state()");
         ok = gst_element_set_state(player->pipeline, desired_state);
+        TRACER_END(player->tracer, "gst_element_set_state()");
+
         if (ok == GST_STATE_CHANGE_FAILURE) {
             LOG_GST_SET_STATE_ERROR(player, player->pipeline);
             goto fail_stop_trace;
@@ -1022,7 +1039,10 @@ static int on_bus_fd_ready(sd_event_source *s, int fd, uint32_t revents, void *u
 
     GstMessage *msg = gst_bus_pop(gst_element_get_bus(player->pipeline));
     if (msg != NULL) {
+        TRACER_BEGIN(player->tracer, "on_bus_message()");
         on_bus_message(player, msg);
+        TRACER_END(player->tracer, "on_bus_message()");
+
         gst_message_unref(msg);
     }
 
@@ -1237,7 +1257,7 @@ struct gstplayer *gstplayer_new(struct flutterpi *flutterpi, const char *uri, vo
 
         struct gl_renderer *gl_renderer = flutterpi_get_gl_renderer(flutterpi);
 
-        GstElement *sink = flutter_gl_texture_sink_new(p->texture, gl_renderer);
+        GstElement *sink = flutter_gl_texture_sink_new(p->texture, gl_renderer, p->tracer);
         if (sink == NULL) {
             goto fail_destroy_texture;
         }
@@ -1426,7 +1446,7 @@ struct gstplayer *gstplayer_new_from_pipeline(struct flutterpi *flutterpi, const
 
     struct gl_renderer *gl_renderer = flutterpi_get_gl_renderer(flutterpi);
 
-    if (!flutter_gl_texture_sink_patch(sink, p->texture, gl_renderer)) {
+    if (!flutter_gl_texture_sink_patch(sink, p->texture, gl_renderer, p->tracer)) {
         LOG_ERROR("Could not setup appsink.\n");
         goto fail_unref_pipeline;
     }
diff --git a/src/plugins/gstreamer_video_player.h b/src/plugins/gstreamer_video_player.h
@@ -66,9 +66,10 @@ const struct gl_texture_frame *frame_get_gl_frame(struct video_frame *frame);
 struct texture;
 struct gl_renderer;
 typedef struct _GstElement GstElement;
+struct tracer;
 
-GstElement *flutter_gl_texture_sink_new(struct texture *texture, struct gl_renderer *renderer);
+bool flutter_gl_texture_sink_patch(GstElement *element, struct texture *texture, struct gl_renderer *renderer, struct tracer *tracer);
 
-bool flutter_gl_texture_sink_patch(GstElement *element, struct texture *texture, struct gl_renderer *renderer);
+GstElement *flutter_gl_texture_sink_new(struct texture *texture, struct gl_renderer *renderer, struct tracer *tracer);
 
 #endif
diff --git a/src/plugins/gstreamer_video_player/flutter_texture_sink.c b/src/plugins/gstreamer_video_player/flutter_texture_sink.c
@@ -8,6 +8,7 @@
 #include "plugins/gstplayer.h"
 #include "texture_registry.h"
 #include "util/logging.h"
+#include "tracer.h"
 
 #if !defined(HAVE_EGL_GLES2)
     #error "gstreamer video player requires EGL and OpenGL ES2 support."
@@ -19,6 +20,7 @@
 struct texture_sink {
     struct texture *fl_texture;
     struct frame_interface *interface;
+    struct tracer *tracer;
 };
 
 static void on_destroy_texture_frame(const struct texture_frame *texture_frame, void *userdata) {
@@ -66,19 +68,27 @@ static GstFlowReturn on_appsink_new_preroll(GstAppSink *appsink, void *userdata)
 
     struct texture_sink *meta = userdata;
 
+    TRACER_BEGIN(meta->tracer, "on_appsink_new_preroll()");
+
+    TRACER_BEGIN(meta->tracer, "gst_app_sink_try_pull_preroll()");
     sample = gst_app_sink_try_pull_preroll(appsink, 0);
+    TRACER_END(meta->tracer, "gst_app_sink_try_pull_preroll()");
+
     if (sample == NULL) {
         LOG_ERROR("gstreamer returned a NULL sample.\n");
-        return GST_FLOW_ERROR;
+        goto fail_stop_tracing;
     }
 
+    TRACER_BEGIN(meta->tracer, "frame_new()");
     // supply video info here
     frame = frame_new(meta->interface, sample, NULL);
+    TRACER_END(meta->tracer, "frame_new()");
 
     // the frame has a reference on the sample internally.
     gst_sample_unref(sample);
 
     if (frame != NULL) {
+        TRACER_BEGIN(meta->tracer, "texture_push_frame()");
         texture_push_frame(
             meta->fl_texture,
             &(struct texture_frame){
@@ -87,9 +97,15 @@ static GstFlowReturn on_appsink_new_preroll(GstAppSink *appsink, void *userdata)
                 .userdata = frame,
             }
         );
+        TRACER_END(meta->tracer, "texture_push_frame()");
     }
 
+    TRACER_END(meta->tracer, "on_appsink_new_preroll()");
     return GST_FLOW_OK;
+
+fail_stop_tracing:
+    TRACER_END(meta->tracer, "on_appsink_new_preroll()");
+    return GST_FLOW_ERROR;
 }
 
 static GstFlowReturn on_appsink_new_sample(GstAppSink *appsink, void *userdata) {
@@ -101,19 +117,27 @@ static GstFlowReturn on_appsink_new_sample(GstAppSink *appsink, void *userdata)
 
     struct texture_sink *meta = userdata;
 
+    TRACER_BEGIN(meta->tracer, "on_appsink_new_sample()");
+
+    TRACER_BEGIN(meta->tracer, "gst_app_sink_try_pull_sample()");
     sample = gst_app_sink_try_pull_sample(appsink, 0);
+    TRACER_END(meta->tracer, "gst_app_sink_try_pull_sample()");
+
     if (sample == NULL) {
         LOG_ERROR("gstreamer returned a NULL sample.\n");
-        return GST_FLOW_ERROR;
+        goto fail_stop_tracing;
     }
 
+    TRACER_BEGIN(meta->tracer, "frame_new()");
     // supply video info here
     frame = frame_new(meta->interface, sample, NULL);
+    TRACER_END(meta->tracer, "frame_new()");
 
     // the frame has a reference on the sample internally.
     gst_sample_unref(sample);
 
     if (frame != NULL) {
+        TRACER_BEGIN(meta->tracer, "texture_push_frame()");
         texture_push_frame(
             meta->fl_texture,
             &(struct texture_frame){
@@ -122,9 +146,15 @@ static GstFlowReturn on_appsink_new_sample(GstAppSink *appsink, void *userdata)
                 .userdata = frame,
             }
         );
+        TRACER_END(meta->tracer, "texture_push_frame()");
     }
 
+    TRACER_END(meta->tracer, "on_appsink_new_preroll()");
     return GST_FLOW_OK;
+
+fail_stop_tracing:
+    TRACER_END(meta->tracer, "on_appsink_new_preroll()");
+    return GST_FLOW_ERROR;
 }
 
 static void on_appsink_cbs_destroy(void *userdata) {
@@ -136,6 +166,7 @@ static void on_appsink_cbs_destroy(void *userdata) {
     meta = userdata;
 
     // meta->texture is not owned by us. freed by the player
+    tracer_unref(meta->tracer);
     frame_interface_unref(meta->interface);
     free(meta);
 }
@@ -218,7 +249,7 @@ UNUSED static GstPadProbeReturn on_query_appsink_pad(GstPad *pad, GstPadProbeInf
     return GST_PAD_PROBE_HANDLED;
 }
 
-bool flutter_gl_texture_sink_patch(GstElement *element, struct texture *texture, struct gl_renderer *renderer) {
+bool flutter_gl_texture_sink_patch(GstElement *element, struct texture *texture, struct gl_renderer *renderer, struct tracer *tracer) {
     ASSERT_NOT_NULL(element);
     ASSERT_NOT_NULL(texture);
     ASSERT_NOT_NULL(renderer);
@@ -283,6 +314,8 @@ bool flutter_gl_texture_sink_patch(GstElement *element, struct texture *texture,
         gst_pad_add_probe(pad, GST_PAD_PROBE_TYPE_QUERY_DOWNSTREAM, on_query_appsink_pad, NULL, NULL);
     }
 
+    meta->tracer = tracer_ref(tracer);
+
     gst_app_sink_set_callbacks(
         GST_APP_SINK(appsink),
         &cbs,
@@ -293,7 +326,7 @@ bool flutter_gl_texture_sink_patch(GstElement *element, struct texture *texture,
     return element;
 }
 
-GstElement *flutter_gl_texture_sink_new(struct texture *texture, struct gl_renderer *renderer) {
+GstElement *flutter_gl_texture_sink_new(struct texture *texture, struct gl_renderer *renderer, struct tracer *tracer) {
     ASSERT_NOT_NULL(texture);
     ASSERT_NOT_NULL(renderer);
 
@@ -302,7 +335,7 @@ GstElement *flutter_gl_texture_sink_new(struct texture *texture, struct gl_rende
         return NULL;
     }
 
-    if (!flutter_gl_texture_sink_patch(element, texture, renderer)) {
+    if (!flutter_gl_texture_sink_patch(element, texture, renderer, tracer)) {
         gst_object_unref(element);
         return NULL;
     }
