repositories tx tests

Author: rashtao

src/main/java/com/arangodb/springframework/repository/query/ArangoResultConverter.java

@@ -160,6 +160,9 @@ private GeoResult<T> buildGeoResult(final ArangoJsonNode data) {
     private GeoResults<T> buildGeoResults(final ArangoCursor<ArangoJsonNode> cursor) {
         final List<GeoResult<T>> list = new LinkedList<>();
         cursor.forEachRemaining(o -> list.add(buildGeoResult(o)));
+        // FIXME: DE-803
+        //        convert geoResults to Metrics.NEUTRAL before
+        //        invoking GeoResults.GeoResults(java.util.List<? extends org.springframework.data.geo.GeoResult<T>>)
         return new GeoResults<>(list);
     }
 

src/test/java/com/arangodb/springframework/AbstractTxTest.java

@@ -13,7 +13,7 @@ public abstract class AbstractTxTest extends AbstractArangoTest {
     protected String tx;
     protected final DocumentCreateOptions insertOpts = new DocumentCreateOptions();
     protected final DocumentReadOptions findOpts = new DocumentReadOptions();
-    protected final AqlQueryOptions queryOpts = new AqlQueryOptions();
+    protected final AqlQueryOptions queryOpts = new AqlQueryOptions().batchSize(1);
     private final boolean withinTx;
 
     protected AbstractTxTest(boolean withinTx, Class<?>... collections) {

src/test/java/com/arangodb/springframework/ArangoTestConfiguration.java

@@ -49,7 +49,8 @@
 @EnableArangoRepositories(basePackages = {
         "com.arangodb.springframework.repository",
         "com.arangodb.springframework.example.polymorphic.repository",
-        "com.arangodb.springframework.debug.repository"},
+        "com.arangodb.springframework.debug.repository",
+        "com.arangodb.springframework.testdata.chess.repo"},
         namedQueriesLocation = "classpath*:arango-named-queries-test.properties")
 @EnableArangoAuditing(auditorAwareRef = "auditorProvider")
 public class ArangoTestConfiguration implements ArangoConfiguration {

src/test/java/com/arangodb/springframework/testdata/chess/AbstractRepositoryTest.java

@@ -0,0 +1,81 @@
+package com.arangodb.springframework.testdata.chess;
+
+import com.arangodb.springframework.AbstractTxTest;
+import com.arangodb.springframework.core.ArangoOperations;
+import com.arangodb.springframework.testdata.chess.entity.Player;
+import com.arangodb.springframework.testdata.chess.entity.Score;
+import com.arangodb.springframework.testdata.chess.entity.Tournament;
+import org.junit.jupiter.api.BeforeEach;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.data.geo.Point;
+
+import java.time.LocalDate;
+import java.util.List;
+
+abstract class AbstractRepositoryTest extends AbstractTxTest {
+
+    @Autowired
+    private ArangoOperations ops;
+
+    protected List<Player> players = List.of(
+            new Player("Magnus Carlsen", 2830, "Norway"),
+            new Player("Fabiano Caruana", 2803, "US"),
+            new Player("Maxime Vachier-Lagrave", 2732, "France"),
+            new Player("Hikaru Nakamura", 2789, "US"),
+            new Player("Ding Liren", 2762, "China"),
+            new Player("Wesley So", 2757, "US"),
+            new Player("Alireza Firouzja", 2760, "France"),
+            new Player("Anish Giri", 2745, "Netherlands"),
+            new Player("Ian Nepomniachtchi", 2758, "Russia")
+    );
+
+    protected List<Tournament> tournaments = List.of(
+            new Tournament(
+                    "Tata Steel 2023",
+                    LocalDate.of(2023, 1, 13),
+                    "Wijk aan Zee",
+                    new Point(4.6, 52.5)
+            ),
+            new Tournament(
+                    "World Chess Championship 2023",
+                    LocalDate.of(2023, 4, 9),
+                    "Astana",
+                    new Point(71.422222, 51.147222)
+            ),
+            new Tournament(
+                    "Norway Chess 2023",
+                    LocalDate.of(2023, 5, 30),
+                    "Stavanger",
+                    new Point(5.731389, 58.97)
+            )
+    );
+
+    protected List<Score> scores = List.of(
+            new Score(players.get(7), tournaments.get(0), 1),
+            new Score(players.get(0), tournaments.get(0), 3),
+            new Score(players.get(5), tournaments.get(0), 4),
+            new Score(players.get(1), tournaments.get(0), 5),
+            new Score(players.get(4), tournaments.get(1), 1),
+            new Score(players.get(8), tournaments.get(1), 2),
+            new Score(players.get(3), tournaments.get(1), 4),
+            new Score(players.get(1), tournaments.get(1), 5),
+            new Score(players.get(6), tournaments.get(1), 6),
+            new Score(players.get(3), tournaments.get(2), 1),
+            new Score(players.get(1), tournaments.get(2), 2),
+            new Score(players.get(7), tournaments.get(2), 4),
+            new Score(players.get(5), tournaments.get(2), 5),
+            new Score(players.get(0), tournaments.get(2), 6)
+    );
+
+    protected AbstractRepositoryTest(boolean withinTx) {
+        super(withinTx, Player.class, Score.class, Tournament.class);
+    }
+
+    @BeforeEach
+    void importData() {
+        ops.insertAll(players, insertOpts, Player.class);
+        ops.insertAll(tournaments, insertOpts, Tournament.class);
+        ops.insertAll(scores, insertOpts, Score.class);
+    }
+
+}

src/test/java/com/arangodb/springframework/testdata/chess/PlayerRepositoryAbstract.java

@@ -0,0 +1,65 @@
+package com.arangodb.springframework.testdata.chess;
+
+import com.arangodb.springframework.testdata.chess.entity.*;
+import com.arangodb.springframework.testdata.chess.repo.PlayerRepository;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.PageRequest;
+
+import java.util.Comparator;
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+abstract class PlayerRepositoryAbstract extends AbstractRepositoryTest {
+
+    @Autowired
+    @SuppressWarnings("SpringJavaInjectionPointsAutowiringInspection")
+    PlayerRepository repo;
+
+    PlayerRepositoryAbstract(boolean withinTx) {
+        super(withinTx);
+    }
+
+    @Test
+    void findAllByCountry() {
+        List<Player> expected = players.stream()
+                .filter(it -> "US".equals(it.getCountry()))
+                .toList();
+        Iterable<Player> found = repo.findAllByCountry("US", queryOpts);
+        assertThat(found).containsExactlyInAnyOrderElementsOf(expected);
+        found.forEach(this::checkRefs);
+    }
+
+    @Test
+    void findAllByRatingGreaterThan() {
+        int rating = 2780;
+        List<Player> expected = players.stream()
+                .filter(it -> it.getRating() > rating)
+                .sorted(Comparator.comparingInt(Player::getRating).reversed())
+                .toList();
+
+        for (int i = 0; i < expected.size(); i++) {
+            Page<Player> page = repo.findAllByRatingGreaterThanOrderByRatingDesc(PageRequest.of(i, 1), rating, queryOpts);
+            assertThat(page.getTotalElements()).isEqualTo(expected.size());
+            assertThat(page.getTotalPages()).isEqualTo(expected.size());
+            Player current = page.iterator().next();
+            assertThat(current).isEqualTo(expected.get(i));
+            checkRefs(current);
+        }
+    }
+
+    private void checkRefs(Player p) {
+        List<Score> expectedScores = scores.stream()
+                .filter(it -> it.player().equals(p))
+                .toList();
+        assertThat(p.getScores()).containsExactlyInAnyOrderElementsOf(expectedScores);
+
+        List<Tournament> expectedTournaments = expectedScores.stream()
+                .map(Score::tournament)
+                .toList();
+        assertThat(p.getTournaments()).containsExactlyInAnyOrderElementsOf(expectedTournaments);
+    }
+
+}

src/test/java/com/arangodb/springframework/testdata/chess/PlayerRepositoryTest.java

@@ -0,0 +1,7 @@
+package com.arangodb.springframework.testdata.chess;
+
+public class PlayerRepositoryTest extends PlayerRepositoryAbstract {
+    PlayerRepositoryTest() {
+        super(false);
+    }
+}

src/test/java/com/arangodb/springframework/testdata/chess/PlayerRepositoryTxTest.java

@@ -0,0 +1,7 @@
+package com.arangodb.springframework.testdata.chess;
+
+public class PlayerRepositoryTxTest extends PlayerRepositoryAbstract {
+    PlayerRepositoryTxTest() {
+        super(true);
+    }
+}

src/test/java/com/arangodb/springframework/testdata/chess/ScoreRepositoryAbstract.java

@@ -0,0 +1,28 @@
+package com.arangodb.springframework.testdata.chess;
+
+import com.arangodb.springframework.testdata.chess.repo.ScoreRepository;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+abstract class ScoreRepositoryAbstract extends AbstractRepositoryTest {
+
+    @Autowired
+    @SuppressWarnings("SpringJavaInjectionPointsAutowiringInspection")
+    ScoreRepository repo;
+
+    ScoreRepositoryAbstract(boolean withinTx) {
+        super(withinTx);
+    }
+
+    @Test
+    @Disabled("BTS-1859")
+    void findAll() {
+        assertThat(repo.findAll(queryOpts))
+                .hasSize(scores.size())
+                .containsExactlyInAnyOrderElementsOf(scores);
+    }
+
+}

src/test/java/com/arangodb/springframework/testdata/chess/ScoreRepositoryTest.java

@@ -0,0 +1,7 @@
+package com.arangodb.springframework.testdata.chess;
+
+public class ScoreRepositoryTest extends ScoreRepositoryAbstract {
+    ScoreRepositoryTest() {
+        super(false);
+    }
+}

src/test/java/com/arangodb/springframework/testdata/chess/ScoreRepositoryTxTest.java

@@ -0,0 +1,7 @@
+package com.arangodb.springframework.testdata.chess;
+
+public class ScoreRepositoryTxTest extends ScoreRepositoryAbstract {
+    ScoreRepositoryTxTest() {
+        super(true);
+    }
+}