[Feature] Promote RestartPolicy Always Feature (#1872)

Author: ajanikow

CHANGELOG.md

@@ -10,6 +10,7 @@
 - (Feature) AutoDiscover Operator Access
 - (Feature) (Platform) Adjust Gateway timeouts
 - (Feature) (Platform) Docs and Installer improvements
+- (Feature) Promote RestartPolicy Always Feature
 
 ## [1.2.47](https://github.com/arangodb/kube-arangodb/tree/1.2.47) (2025-03-28)
 - (Bugfix) Use Profile Annotations

docs/api/ArangoDeployment.V1.md

@@ -609,6 +609,21 @@ Links:
 
 ***
 
+### .spec.agents.restartPolicy
+
+Type: `core.RestartPolicy` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L224)</sup>
+
+RestartPolicy for all pods within the group.
+
+Links:
+* [Documentation of core.RestartPolicy](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po)
+
+Possible Values: 
+* `"Always"` (default) - Means that containers within the pod are always restarted.
+* `"Never"` - Means that containers within the pod are never restarted.
+
+***
+
 ### .spec.agents.schedulerName
 
 Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L58)</sup>
@@ -1691,6 +1706,21 @@ Links:
 
 ***
 
+### .spec.coordinators.restartPolicy
+
+Type: `core.RestartPolicy` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L224)</sup>
+
+RestartPolicy for all pods within the group.
+
+Links:
+* [Documentation of core.RestartPolicy](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po)
+
+Possible Values: 
+* `"Always"` (default) - Means that containers within the pod are always restarted.
+* `"Never"` - Means that containers within the pod are never restarted.
+
+***
+
 ### .spec.coordinators.schedulerName
 
 Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L58)</sup>
@@ -2641,6 +2671,21 @@ Links:
 
 ***
 
+### .spec.dbservers.restartPolicy
+
+Type: `core.RestartPolicy` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L224)</sup>
+
+RestartPolicy for all pods within the group.
+
+Links:
+* [Documentation of core.RestartPolicy](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po)
+
+Possible Values: 
+* `"Always"` (default) - Means that containers within the pod are always restarted.
+* `"Never"` - Means that containers within the pod are never restarted.
+
+***
+
 ### .spec.dbservers.schedulerName
 
 Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L58)</sup>
@@ -3754,6 +3799,21 @@ Links:
 
 ***
 
+### .spec.gateways.restartPolicy
+
+Type: `core.RestartPolicy` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L224)</sup>
+
+RestartPolicy for all pods within the group.
+
+Links:
+* [Documentation of core.RestartPolicy](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po)
+
+Possible Values: 
+* `"Always"` (default) - Means that containers within the pod are always restarted.
+* `"Never"` - Means that containers within the pod are never restarted.
+
+***
+
 ### .spec.gateways.schedulerName
 
 Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L58)</sup>
@@ -5469,6 +5529,21 @@ Links:
 
 ***
 
+### .spec.single.restartPolicy
+
+Type: `core.RestartPolicy` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L224)</sup>
+
+RestartPolicy for all pods within the group.
+
+Links:
+* [Documentation of core.RestartPolicy](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po)
+
+Possible Values: 
+* `"Always"` (default) - Means that containers within the pod are always restarted.
+* `"Never"` - Means that containers within the pod are never restarted.
+
+***
+
 ### .spec.single.schedulerName
 
 Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L58)</sup>
@@ -6633,6 +6708,21 @@ Links:
 
 ***
 
+### .spec.syncmasters.restartPolicy
+
+Type: `core.RestartPolicy` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L224)</sup>
+
+RestartPolicy for all pods within the group.
+
+Links:
+* [Documentation of core.RestartPolicy](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po)
+
+Possible Values: 
+* `"Always"` (default) - Means that containers within the pod are always restarted.
+* `"Never"` - Means that containers within the pod are never restarted.
+
+***
+
 ### .spec.syncmasters.schedulerName
 
 Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L58)</sup>
@@ -7575,6 +7665,21 @@ Links:
 
 ***
 
+### .spec.syncworkers.restartPolicy
+
+Type: `core.RestartPolicy` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L224)</sup>
+
+RestartPolicy for all pods within the group.
+
+Links:
+* [Documentation of core.RestartPolicy](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po)
+
+Possible Values: 
+* `"Always"` (default) - Means that containers within the pod are always restarted.
+* `"Never"` - Means that containers within the pod are never restarted.
+
+***
+
 ### .spec.syncworkers.schedulerName
 
 Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.47/pkg/apis/deployment/v1/server_group_spec.go#L58)</sup>

pkg/apis/deployment/v1/member_status.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2016-2024 ArangoDB GmbH, Cologne, Germany
+// Copyright 2016-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -136,6 +136,41 @@ func (s MemberStatus) Age() time.Duration {
 	return time.Since(s.CreatedAt.Time)
 }
 
+// AppendLastTermination appends termination to the list if required
+func (s *MemberStatus) AppendLastTermination(termination time.Time) bool {
+	if s == nil {
+		return false
+	}
+
+	if len(s.RecentTerminations) == 0 {
+		s.RecentTerminations = []meta.Time{
+			meta.NewTime(termination),
+		}
+		return true
+	}
+
+	if s.RecentTerminations[0].Time.Before(termination) {
+		s.RecentTerminations = append([]meta.Time{meta.NewTime(termination)}, s.RecentTerminations...)
+
+		return true
+	}
+
+	return false
+}
+
+// LastTermination returns last termination time
+func (s *MemberStatus) LastTermination() time.Time {
+	if s == nil {
+		return time.Time{}
+	}
+
+	if len(s.RecentTerminations) == 0 {
+		return time.Time{}
+	}
+
+	return s.RecentTerminations[0].Time
+}
+
 // RemoveTerminationsBefore removes all recent terminations before the given timestamp.
 // It returns the number of terminations that have been removed.
 func (s *MemberStatus) RemoveTerminationsBefore(timestamp time.Time) int {

pkg/apis/deployment/v1/server_group_spec.go

@@ -215,6 +215,13 @@ type ServerGroupSpec struct {
 	// +doc/enum: replace|Replaces server instead of upgrading. Takes an effect only on DBServer
 	// +doc/default: inplace
 	UpgradeMode *ServerGroupUpgradeMode `json:"upgradeMode,omitempty"`
+
+	// RestartPolicy for all pods within the group.
+	// +doc/type: core.RestartPolicy
+	// +doc/enum: Always|Means that containers within the pod are always restarted.
+	// +doc/enum: Never|Means that containers within the pod are never restarted.
+	// +doc/link: Documentation of core.RestartPolicy|https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po
+	RestartPolicy *core.RestartPolicy `json:"restartPolicy,omitempty"`
 }
 
 func (s *ServerGroupSpec) Get() ServerGroupSpec {

pkg/apis/deployment/v1/zz_generated.deepcopy.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2016-2024 ArangoDB GmbH, Cologne, Germany
+// Copyright 2016-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -136,6 +136,41 @@ func (s MemberStatus) Age() time.Duration {
 	return time.Since(s.CreatedAt.Time)
 }
 
+// AppendLastTermination appends termination to the list if required
+func (s *MemberStatus) AppendLastTermination(termination time.Time) bool {
+	if s == nil {
+		return false
+	}
+
+	if len(s.RecentTerminations) == 0 {
+		s.RecentTerminations = []meta.Time{
+			meta.NewTime(termination),
+		}
+		return true
+	}
+
+	if s.RecentTerminations[0].Time.Before(termination) {
+		s.RecentTerminations = append([]meta.Time{meta.NewTime(termination)}, s.RecentTerminations...)
+
+		return true
+	}
+
+	return false
+}
+
+// LastTermination returns last termination time
+func (s *MemberStatus) LastTermination() time.Time {
+	if s == nil {
+		return time.Time{}
+	}
+
+	if len(s.RecentTerminations) == 0 {
+		return time.Time{}
+	}
+
+	return s.RecentTerminations[0].Time
+}
+
 // RemoveTerminationsBefore removes all recent terminations before the given timestamp.
 // It returns the number of terminations that have been removed.
 func (s *MemberStatus) RemoveTerminationsBefore(timestamp time.Time) int {

pkg/apis/deployment/v2alpha1/member_status.go

@@ -215,6 +215,13 @@ type ServerGroupSpec struct {
 	// +doc/enum: replace|Replaces server instead of upgrading. Takes an effect only on DBServer
 	// +doc/default: inplace
 	UpgradeMode *ServerGroupUpgradeMode `json:"upgradeMode,omitempty"`
+
+	// RestartPolicy for all pods within the group.
+	// +doc/type: core.RestartPolicy
+	// +doc/enum: Always|Means that containers within the pod are always restarted.
+	// +doc/enum: Never|Means that containers within the pod are never restarted.
+	// +doc/link: Documentation of core.RestartPolicy|https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-po
+	RestartPolicy *core.RestartPolicy `json:"restartPolicy,omitempty"`
 }
 
 func (s *ServerGroupSpec) Get() ServerGroupSpec {