[Bugfix] Prevent changes when UID is wrong (#1138)

Author: ajanikow

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Change Log
 
 ## [master](https://github.com/arangodb/kube-arangodb/tree/master) (N/A)
+- (Bugfix) Prevent changes when UID is wrong
 
 ## [1.2.18](https://github.com/arangodb/kube-arangodb/tree/1.2.18) (2022-09-28)
 - (Feature) Define Actions PlaceHolder

pkg/deployment/deployment.go

@@ -103,6 +103,7 @@ type Deployment struct {
 	log logging.Logger
 
 	name      string
+	uid       types.UID
 	namespace string
 
 	currentObject       *api.ArangoDeployment
@@ -234,6 +235,7 @@ func New(config Config, deps Dependencies, apiObject *api.ArangoDeployment) (*De
 		currentObject:       apiObject,
 		currentObjectStatus: apiObject.Status.DeepCopy(),
 		name:                apiObject.GetName(),
+		uid:                 apiObject.GetUID(),
 		namespace:           apiObject.GetNamespace(),
 		config:              config,
 		deps:                deps,

pkg/deployment/deployment_inspector.go

@@ -76,6 +76,12 @@ func (d *Deployment) inspectDeployment(lastInterval util.Interval) util.Interval
 		d.log.Info("Deployment is gone")
 		d.Stop()
 		return nextInterval
+	} else if err != nil {
+		d.log.Err(err).Error("Deployment fetch error")
+		return nextInterval
+	} else if d.uid != updated.GetUID() {
+		d.log.Error("Deployment UID Changed!")
+		return nextInterval
 	} else if updated != nil && updated.GetDeletionTimestamp() != nil {
 		// Deployment is marked for deletion
 		if err := d.runDeploymentFinalizers(ctxReconciliation, d.GetCachedStatus()); err != nil {