Skip to content

Commit b5c88a5

Browse files
author
lamai93
committed
Updated makefile. Updated tests.
1 parent 6abd51c commit b5c88a5

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

Makefile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,10 @@ update-vendor:
150150

151151

152152
.PHONY: update-generated
153-
update-generated: $(GOBUILDDIR)
153+
update-generated:
154+
@rm -f $(ORGDIR)
155+
@mkdir -p $(ORGDIR)
156+
@ln -s -f $(SCRIPTDIR) $(ORGDIR)
154157
$(VENDORDIR)/k8s.io/code-generator/generate-groups.sh \
155158
"all" \
156159
"github.com/arangodb/kube-arangodb/pkg/generated" \
@@ -172,7 +175,7 @@ dashboard/assets.go: $(DASHBOARDSOURCES) $(DASHBOARDDIR)/Dockerfile.build
172175
-v $(DASHBOARDDIR)/public:/usr/code/public:ro \
173176
-v $(DASHBOARDDIR)/src:/usr/code/src:ro \
174177
$(DASHBOARDBUILDIMAGE)
175-
$(GOASSETSBUILDER) -s /dashboard/build/ -o dashboard/assets.go -p dashboard dashboard/build
178+
go run github.com/jessevdk/go-assets-builder -s /dashboard/build/ -o dashboard/assets.go -p dashboard dashboard/build
176179

177180
$(BIN): $(SOURCES) dashboard/assets.go
178181
@mkdir -p $(BINDIR)

tests/sync_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import (
4343
// waitUntilReplicationNotFound waits until a replication resource is deleted
4444
func waitUntilReplicationNotFound(ns, name string, cli versioned.Interface) error {
4545
return retry.Retry(func() error {
46-
if _, err := cli.Replication().ArangoDeploymentReplications(ns).Get(name, metav1.GetOptions{}); k8sutil.IsNotFound(err) {
46+
if _, err := cli.ReplicationV1alpha().ArangoDeploymentReplications(ns).Get(name, metav1.GetOptions{}); k8sutil.IsNotFound(err) {
4747
return nil
4848
} else if err != nil {
4949
return err

tests/test_util.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import (
3434
"testing"
3535
"time"
3636

37-
"k8s.io/api/core/v1"
37+
v1 "k8s.io/api/core/v1"
3838
"k8s.io/client-go/kubernetes"
3939

4040
"github.com/arangodb/arangosync/client"
@@ -541,12 +541,12 @@ func clusterHealthEqualsSpec(h driver.ClusterHealth, spec api.DeploymentSpec) er
541541
func updateDeployment(cli versioned.Interface, deploymentName, ns string, update func(*api.DeploymentSpec)) (*api.ArangoDeployment, error) {
542542
for {
543543
// Get current version
544-
current, err := cli.Database().ArangoDeployments(ns).Get(deploymentName, metav1.GetOptions{})
544+
current, err := cli.DatabaseV1alpha().ArangoDeployments(ns).Get(deploymentName, metav1.GetOptions{})
545545
if err != nil {
546546
return nil, maskAny(err)
547547
}
548548
update(&current.Spec)
549-
current, err = cli.Database().ArangoDeployments(ns).Update(current)
549+
current, err = cli.DatabaseV1alpha().ArangoDeployments(ns).Update(current)
550550
if k8sutil.IsConflict(err) {
551551
// Retry
552552
} else if err != nil {
@@ -558,15 +558,15 @@ func updateDeployment(cli versioned.Interface, deploymentName, ns string, update
558558

559559
// removeDeployment removes a deployment
560560
func removeDeployment(cli versioned.Interface, deploymentName, ns string) error {
561-
if err := cli.Database().ArangoDeployments(ns).Delete(deploymentName, nil); err != nil && k8sutil.IsNotFound(err) {
561+
if err := cli.DatabaseV1alpha().ArangoDeployments(ns).Delete(deploymentName, nil); err != nil && k8sutil.IsNotFound(err) {
562562
return maskAny(err)
563563
}
564564
return nil
565565
}
566566

567567
// removeReplication removes a deployment
568568
func removeReplication(cli versioned.Interface, replicationName, ns string) error {
569-
if err := cli.Replication().ArangoDeploymentReplications(ns).Delete(replicationName, nil); err != nil && k8sutil.IsNotFound(err) {
569+
if err := cli.ReplicationV1alpha().ArangoDeploymentReplications(ns).Delete(replicationName, nil); err != nil && k8sutil.IsNotFound(err) {
570570
return maskAny(err)
571571
}
572572
return nil

0 commit comments

Comments
 (0)