[Feature] [Scheduler] Add Status Conditions (#1720)

Author: ajanikow

.golangci.yaml

@@ -79,6 +79,8 @@ linters-settings:
         pkg: github.com/arangodb/kube-arangodb/pkg/apis/scheduler/v1beta1/container
       - alias: schedulerContainerResourcesApi
         pkg: github.com/arangodb/kube-arangodb/pkg/apis/scheduler/v1beta1/container/resources
+      - alias: schedulerIntegrationApi
+        pkg: github.com/arangodb/kube-arangodb/pkg/apis/scheduler/v1beta1/integration
       - alias: schedulerPodApi
         pkg: github.com/arangodb/kube-arangodb/pkg/apis/scheduler/v1beta1/pod
       - alias: schedulerPodResourcesApi

CHANGELOG.md

@@ -28,6 +28,7 @@
 - (Feature) (Gateway) ArangoDB Auth Token
 - (Feature) (Gateway) Dynamic Configuration
 - (Feature) DebugPackage ArangoRoutes
+- (Feature) (Scheduler) Add Status Conditions
 
 ## [1.2.42](https://github.com/arangodb/kube-arangodb/tree/1.2.42) (2024-07-23)
 - (Maintenance) Go 1.22.4 & Kubernetes 1.29.6 libraries

Makefile

@@ -452,7 +452,7 @@ update-generated:
 			"github.com/arangodb/kube-arangodb/pkg/apis" \
 			"shared:v1 \
 			scheduler:v1alpha1/container scheduler:v1alpha1/container/resources scheduler:v1alpha1/pod scheduler:v1alpha1/pod/resources \
-			scheduler:v1beta1/container scheduler:v1beta1/container/resources scheduler:v1beta1/pod scheduler:v1beta1/pod/resources" \
+			scheduler:v1beta1/integration scheduler:v1beta1/container scheduler:v1beta1/container/resources scheduler:v1beta1/pod scheduler:v1beta1/pod/resources" \
 			--go-header-file "./tools/codegen/boilerplate.go.txt" \
 			$(VERIFYARGS)
 

docs/api/ArangoDeployment.V1.md

@@ -3110,7 +3110,7 @@ Links:
 
 ### .spec.gateway.sidecar.controllerListenPort
 
-Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration.go#L36)</sup>
+Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration/integration.go#L16)</sup>
 
 ControllerListenPort defines on which port the sidecar container will be listening for controller requests
 
@@ -3168,7 +3168,7 @@ Lifecycle keeps actions that the management system should take in response to co
 
 ### .spec.gateway.sidecar.listenPort
 
-Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration.go#L32)</sup>
+Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration/integration.go#L12)</sup>
 
 ListenPort defines on which port the sidecar container will be listening for connections
 

docs/api/ArangoMLExtension.V1Beta1.md

@@ -798,7 +798,7 @@ Links:
 
 ### .spec.integrationSidecar.controllerListenPort
 
-Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration.go#L36)</sup>
+Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration/integration.go#L16)</sup>
 
 ControllerListenPort defines on which port the sidecar container will be listening for controller requests
 
@@ -856,7 +856,7 @@ Lifecycle keeps actions that the management system should take in response to co
 
 ### .spec.integrationSidecar.listenPort
 
-Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration.go#L32)</sup>
+Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration/integration.go#L12)</sup>
 
 ListenPort defines on which port the sidecar container will be listening for connections
 

docs/api/ArangoProfile.V1Beta1.md

@@ -394,5 +394,5 @@ Links:
 
 ### .spec.template.priority
 
-Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/profile_template.go#L30)</sup>
+Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/profile_template.go#L31)</sup>
 

docs/api/GraphAnalyticsEngine.V1Alpha1.md

@@ -440,7 +440,7 @@ Links:
 
 ### .spec.integrationSidecar.controllerListenPort
 
-Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration.go#L36)</sup>
+Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration/integration.go#L16)</sup>
 
 ControllerListenPort defines on which port the sidecar container will be listening for controller requests
 
@@ -498,7 +498,7 @@ Lifecycle keeps actions that the management system should take in response to co
 
 ### .spec.integrationSidecar.listenPort
 
-Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration.go#L32)</sup>
+Type: `integer` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.42/pkg/apis/scheduler/v1beta1/integration/integration.go#L12)</sup>
 
 ListenPort defines on which port the sidecar container will be listening for connections
 

internal/docs_test.go

@@ -180,6 +180,7 @@ func Test_GenerateAPIDocs(t *testing.T) {
 					"scheduler/v1beta1",
 					"scheduler/v1beta1/container",
 					"scheduler/v1beta1/container/resources",
+					"scheduler/v1beta1/integration",
 					"scheduler/v1beta1/pod",
 					"scheduler/v1beta1/pod/resources",
 				},
@@ -253,6 +254,7 @@ func Test_GenerateAPIDocs(t *testing.T) {
 					"scheduler/v1beta1",
 					"scheduler/v1beta1/container",
 					"scheduler/v1beta1/container/resources",
+					"scheduler/v1beta1/integration",
 					"scheduler/v1beta1/pod",
 					"scheduler/v1beta1/pod/resources",
 				},
@@ -284,6 +286,7 @@ func Test_GenerateAPIDocs(t *testing.T) {
 					"scheduler/v1beta1",
 					"scheduler/v1beta1/container",
 					"scheduler/v1beta1/container/resources",
+					"scheduler/v1beta1/integration",
 					"scheduler/v1beta1/pod",
 					"scheduler/v1beta1/pod/resources",
 				},
@@ -323,6 +326,7 @@ func Test_GenerateAPIDocs(t *testing.T) {
 					"shared/v1",
 					"scheduler/v1beta1/container",
 					"scheduler/v1beta1/container/resources",
+					"scheduler/v1beta1/integration",
 					"scheduler/v1beta1/pod",
 					"scheduler/v1beta1/pod/resources",
 				},

pkg/apis/analytics/v1alpha1/gae_spec.go

@@ -21,7 +21,7 @@
 package v1alpha1
 
 import (
-	schedulerApi "github.com/arangodb/kube-arangodb/pkg/apis/scheduler/v1beta1"
+	schedulerIntegrationApi "github.com/arangodb/kube-arangodb/pkg/apis/scheduler/v1beta1/integration"
 	shared "github.com/arangodb/kube-arangodb/pkg/apis/shared"
 	"github.com/arangodb/kube-arangodb/pkg/util/errors"
 )
@@ -34,7 +34,7 @@ type GraphAnalyticsEngineSpec struct {
 	Deployment *GraphAnalyticsEngineSpecDeployment `json:"deployment,omitempty"`
 
 	// IntegrationSidecar define the integration sidecar spec
-	IntegrationSidecar *schedulerApi.IntegrationSidecar `json:"integrationSidecar,omitempty"`
+	IntegrationSidecar *schedulerIntegrationApi.Sidecar `json:"integrationSidecar,omitempty"`
 }
 
 func (a *GraphAnalyticsEngineSpec) GetDeployment() *GraphAnalyticsEngineSpecDeployment {
@@ -44,7 +44,7 @@ func (a *GraphAnalyticsEngineSpec) GetDeployment() *GraphAnalyticsEngineSpecDepl
 	return a.Deployment
 }
 
-func (a *GraphAnalyticsEngineSpec) GetIntegrationSidecar() *schedulerApi.IntegrationSidecar {
+func (a *GraphAnalyticsEngineSpec) GetIntegrationSidecar() *schedulerIntegrationApi.Sidecar {
 	if a == nil || a.IntegrationSidecar == nil {
 		return nil
 	}