Merge pull request #375 from arangodb/bug-fix/fix-pdb-test

Give default image for test.

Author: neunhoef

MAINTAINERS.md

@@ -2,20 +2,42 @@
 
 ## Running tests
 
-To run the entire test set, run:
+To run the entire test set, first set the following environment variables:
+
+  - `DOCKERNAMESPACE` to your docker hub account
+  - `VERBOSE` to `1` (default is empty)
+  - `LONG` to `1` (default is empty, which skips lots of tests)
+  - `ARANGODB` to the name of a community image you want to test,
+    default is `arangodb/arangodb:latest`
+  - `ENTERPRISEIMAGE` to the name of an enterprise image, you want to
+    test, if not set, some tests are skipped
+  - `ARANGO_LICENSE_KEY` to the enterpise license key
+  - `KUBECONFIG` to the path to some k8s configuration with
+    credentials, this indicates which cluster to use
 
 ```bash
-export DOCKERNAMESPACE=<your docker hub account>
 make clean
 make build
 make run-tests
 ```
 
+To run only a single test, set `TESTOPTIONS` to something like
+`-test.run=TestRocksDBEncryptionSingle` where
+`TestRocksDBEncryptionSingle` is the name of the test.
+
 ## Preparing a release
 
 To prepare for a release, do the following:
 
 - Make sure all tests are OK.
+- To run a complete set of tests, do the following:
+
+  Then do
+
+~~~
+make run-tests
+~~~
+
 - Update the CHANGELOG manually, since the automatic CHANGELOG
   generation is switched off (did not work in many cases).
 

tests/pdb_test.go

@@ -11,6 +11,7 @@ import (
 	"github.com/arangodb/kube-arangodb/pkg/util"
 	"github.com/arangodb/kube-arangodb/pkg/util/retry"
 	"github.com/dchest/uniuri"
+	"github.com/stretchr/testify/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes"
 )
@@ -80,6 +81,12 @@ func TestPDBCreate(t *testing.T) {
 	depl.Spec.SetDefaults(depl.GetName()) // this must be last
 	defer deferedCleanupDeployment(c, depl.GetName(), ns)
 
+	// This test failes to validate the spec if no image is set explicitly because this is required in production mode
+	if depl.Spec.Image == nil {
+		depl.Spec.Image = util.NewString("arangodb/arangodb:latest")
+	}
+	assert.NoError(t, depl.Spec.Validate())
+
 	// Create deployment
 	_, err := c.DatabaseV1alpha().ArangoDeployments(ns).Create(depl)
 	if err != nil {