[Bugfix] Change SyncWorker Affinity to Soft (#1128)

Author: ajanikow

CHANGELOG.md

@@ -6,6 +6,7 @@
 - (Feature) Active Member condition
 - (Bugfix) Accept Initial Spec
 - (Bugfix) Prevent LifeCycle restarts
+- (Bugfix) Change SyncWorker Affinity to Soft
 
 ## [1.2.17](https://github.com/arangodb/kube-arangodb/tree/1.2.17) (2022-09-22)
 - (Feature) Add new field to DeploymentReplicationStatus with details on DC2DC sync status=

pkg/deployment/pod/affinity.go

@@ -64,20 +64,13 @@ func AppendAffinityWithRole(p interfaces.PodCreator, a *core.PodAffinity, role s
 	labelSelector := &meta.LabelSelector{
 		MatchLabels: k8sutil.LabelsForDeployment(p.GetName(), role),
 	}
-	if !p.IsDeploymentMode() {
-		a.RequiredDuringSchedulingIgnoredDuringExecution = append(a.RequiredDuringSchedulingIgnoredDuringExecution, core.PodAffinityTerm{
+	a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution, core.WeightedPodAffinityTerm{
+		Weight: 1,
+		PodAffinityTerm: core.PodAffinityTerm{
 			LabelSelector: labelSelector,
 			TopologyKey:   shared.TopologyKeyHostname,
-		})
-	} else {
-		a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution, core.WeightedPodAffinityTerm{
-			Weight: 1,
-			PodAffinityTerm: core.PodAffinityTerm{
-				LabelSelector: labelSelector,
-				TopologyKey:   shared.TopologyKeyHostname,
-			},
-		})
-	}
+		},
+	})
 }
 
 func MergePodAntiAffinity(a, b *core.PodAntiAffinity) {