GT-196 Update DeploymentReplicationStatus if configuring synchronisation errored (#1150)

Author: nikita-vanyasin

CHANGELOG.md

@@ -13,6 +13,7 @@
 - (Feature) Remove stuck Pods
 - (Bugfix) Fix Go routine leak
 - (Feature) Extend Pod Security context
+- (Improvement) Update DeploymentReplicationStatus on configuration error
 
 ## [1.2.19](https://github.com/arangodb/kube-arangodb/tree/1.2.19) (2022-10-05)
 - (Bugfix) Prevent changes when UID is wrong

pkg/replication/deployment_replication.go

@@ -342,10 +342,20 @@ func (dr *DeploymentReplication) failOnError(err error, msg string) {
 	dr.reportFailedStatus()
 }
 
+func (dr *DeploymentReplication) reportInvalidConfigError(isRecoverable bool, err error, msg string) {
+	if !isRecoverable {
+		dr.status.Phase = api.DeploymentReplicationPhaseFailed
+		dr.status.Reason = fmt.Sprintf("%s: %s", msg, err.Error())
+	}
+	dr.status.Conditions.Update(api.ConditionTypeConfigured, false, api.ConditionConfiguredReasonInvalid, msg)
+	if err = dr.updateCRStatus(); err != nil {
+		dr.log.Err(err).Warn("Failed to update status")
+	}
+}
+
 // reportFailedStatus sets the status of the deployment replication to Failed and keeps trying to forward
 // that to the API server.
 func (dr *DeploymentReplication) reportFailedStatus() {
-	dr.log.Info("local storage failed. Reporting failed reason...")
 	repls := dr.deps.Client.Arango().ReplicationV1().ArangoDeploymentReplications(dr.apiObject.GetNamespace())
 
 	op := func() error {

pkg/replication/sync_inspector.go

@@ -189,7 +189,9 @@ func (dr *DeploymentReplication) inspectDeploymentReplication(lastInterval time.
 				} else {
 					auth, err := dr.createArangoSyncTLSAuthentication(spec)
 					if err != nil {
-						dr.log.Err(err).Warn("Failed to configure synchronization authentication")
+						msg := "Failed to configure synchronization authentication"
+						dr.log.Err(err).Warn(msg)
+						dr.reportInvalidConfigError(false, err, msg)
 						hasError = true
 					} else {
 						req := client.SynchronizationRequest{
@@ -198,7 +200,9 @@ func (dr *DeploymentReplication) inspectDeploymentReplication(lastInterval time.
 						}
 						dr.log.Info("Configuring synchronization")
 						if err := destClient.Master().Synchronize(ctx, req); err != nil {
-							dr.log.Err(err).Warn("Failed to configure synchronization")
+							msg := "Failed to configure synchronization"
+							dr.log.Err(err).Warn(msg)
+							dr.reportInvalidConfigError(true, err, msg)
 							hasError = true
 						} else {
 							dr.log.Info("Configured synchronization")