Alpine & status fixes

Author: ewoutp

dashboard/assets.go

@@ -15,7 +15,7 @@ const HeaderView = () => (
       <Table.HeaderCell><Popup trigger={<span>Pods</span>}>Ready / Total</Popup></Table.HeaderCell>
       <Table.HeaderCell><Popup trigger={<span>Volumes</span>}>Bound / Total</Popup></Table.HeaderCell>
       <Table.HeaderCell>StorageClass</Table.HeaderCell>
-      <Table.HeaderCell></Table.HeaderCell>
+      <Table.HeaderCell>Actions</Table.HeaderCell>
     </Table.Row>
   </Table.Header>
 );
@@ -34,10 +34,12 @@ const NoDatabaseLinkView = () => (
   </Popup>
 );
 
-const RowView = ({name, mode, environment, version, license, ready_pod_count, pod_count, ready_volume_count, volume_count, storage_classes, database_url, delete_command}) => (
+const RowView = ({name, mode, environment, stateColor, version, license, readyPodCount, podCount, readyVolumeCount, volumeCount, storageClasses, databaseURL, deleteCommand, describeCommand}) => (
   <Table.Row>
     <Table.Cell>
-      <Icon name="bell" color="red"/>
+      <Popup trigger={<Icon name={(stateColor==="green") ? "check" : "bell"} color={stateColor}/>}>
+        {getStateColorDescription(stateColor)}
+      </Popup>
     </Table.Cell>
     <Table.Cell>
       <Link to={`/deployment/${name}`}>
@@ -58,15 +60,21 @@ const RowView = ({name, mode, environment, version, license, ready_pod_count, po
         {(license==="enterprise") ? <Popup trigger={<Icon name="dollar"/>} content="Enterprise edition"/>: null}
       </span>
     </Table.Cell>
-    <Table.Cell>{ready_pod_count} / {pod_count}</Table.Cell>
-    <Table.Cell>{ready_volume_count} / {volume_count}</Table.Cell>
-    <Table.Cell>{storage_classes.map((item) => (item === "") ? "<default>" : item)}</Table.Cell>
+    <Table.Cell>{readyPodCount} / {podCount}</Table.Cell>
+    <Table.Cell>{readyVolumeCount} / {volumeCount}</Table.Cell>
+    <Table.Cell>{storageClasses.map((item) => (item === "") ? "<default>" : item)}</Table.Cell>
     <Table.Cell>
-      { database_url ? <DatabaseLinkView name={name} url={database_url}/> : <NoDatabaseLinkView/>}
+      { databaseURL ? <DatabaseLinkView name={name} url={databaseURL}/> : <NoDatabaseLinkView/>}
+      <CommandInstruction 
+          trigger={<Icon link name="zoom"/>}
+          command={describeCommand}
+          title="Describe deployment"
+          description="To get more information on the state of this deployment, run:"
+        />
       <span style={{"float":"right"}}>
         <CommandInstruction 
           trigger={<Icon link name="trash"/>}
-          command={delete_command}
+          command={deleteCommand}
           title="Delete deployment"
           description="To delete this deployment, run:"
         />
@@ -87,15 +95,17 @@ const ListView = ({items}) => (
             namespace={item.namespace}
             mode={item.mode}
             environment={item.environment}
+            stateColor={item.state_color}
             version={item.database_version}
             license={item.database_license}
-            ready_pod_count={item.ready_pod_count}
-            pod_count={item.pod_count}
-            ready_volume_count={item.ready_volume_count}
-            volume_count={item.volume_count}
-            storage_classes={item.storage_classes}
-            database_url={item.database_url}
-            delete_command={createDeleteCommand(item.name, item.namespace)}
+            readyPodCount={item.ready_pod_count}
+            podCount={item.pod_count}
+            readyVolumeCount={item.ready_volume_count}
+            volumeCount={item.volume_count}
+            storageClasses={item.storage_classes}
+            databaseURL={item.database_url}
+            deleteCommand={createDeleteCommand(item.name, item.namespace)}
+            describeCommand={createDescribeCommand(item.name, item.namespace)}
           />) : <p>No items</p>
       }
     </Table.Body>
@@ -108,6 +118,25 @@ function createDeleteCommand(name, namespace) {
   return `kubectl delete ArangoDeployment -n ${namespace} ${name}`;
 }
 
+function createDescribeCommand(name, namespace) {
+  return `kubectl describe ArangoDeployment -n ${namespace} ${name}`;
+}
+
+function getStateColorDescription(stateColor) {
+  switch (stateColor) {
+    case "green":
+      return "Everything is running smooth.";
+    case "yellow":
+      return "There is some activity going on, but deployment is available.";
+    case "orange":
+      return "There is some activity going on, deployment may be/become unavailable. You should pay attention now!";
+    case "red":
+      return "The deployment is in a bad state and manual intervention is likely needed.";
+    default:
+      return "State is not known.";
+  }
+}
+
 class DeploymentList extends Component {
   state = {};
 

dashboard/src/deployment/DeploymentList.js

@@ -59,6 +59,7 @@ const (
 	defaultServerPort      = 8528
 	defaultLogLevel        = "debug"
 	defaultAdminSecretName = "arangodb-operator-dashboard"
+	defaultAlpineImage     = "alpine:3.7"
 )
 
 var (
@@ -86,6 +87,7 @@ var (
 		enableDeployment            bool // Run deployment operator
 		enableDeploymentReplication bool // Run deployment-replication operator
 		enableStorage               bool // Run local-storage operator
+		alpineImage                 string
 	}
 	chaosOptions struct {
 		allowed bool
@@ -107,6 +109,7 @@ func init() {
 	f.BoolVar(&operatorOptions.enableDeployment, "operator.deployment", false, "Enable to run the ArangoDeployment operator")
 	f.BoolVar(&operatorOptions.enableDeploymentReplication, "operator.deployment-replication", false, "Enable to run the ArangoDeploymentReplication operator")
 	f.BoolVar(&operatorOptions.enableStorage, "operator.storage", false, "Enable to run the ArangoLocalStorage operator")
+	f.StringVar(&operatorOptions.alpineImage, "operator.alpine-image", defaultAlpineImage, "Docker image used for alpine containers")
 	f.BoolVar(&chaosOptions.allowed, "chaos.allowed", false, "Set to allow chaos in deployments. Only activated when allowed and enabled in deployment")
 }
 
@@ -249,6 +252,7 @@ func newOperatorConfigAndDeps(id, namespace, name string) (operator.Config, oper
 		EnableDeploymentReplication: operatorOptions.enableDeploymentReplication,
 		EnableStorage:               operatorOptions.enableStorage,
 		AllowChaos:                  chaosOptions.allowed,
+		AlpineImage:                 operatorOptions.alpineImage,
 	}
 	deps := operator.Dependencies{
 		LogService:                 logService,

main.go

@@ -63,6 +63,11 @@ func (d *Deployment) GetLifecycleImage() string {
 	return d.config.LifecycleImage
 }
 
+// GetAlpineImage returns the image name containing the alpine environment
+func (d *Deployment) GetAlpineImage() string {
+	return d.config.AlpineImage
+}
+
 // GetNamespace returns the kubernetes namespace that contains
 // this deployment.
 func (d *Deployment) GetNamespace() string {

pkg/deployment/context_impl.go

@@ -52,6 +52,7 @@ type Config struct {
 	ServiceAccount string
 	AllowChaos     bool
 	LifecycleImage string
+	AlpineImage    string
 }
 
 // Dependencies holds dependent services for a Deployment

pkg/deployment/deployment.go

@@ -178,7 +178,7 @@ func (ib *imagesBuilder) fetchArangoDBImageIDAndVersion(ctx context.Context, ima
 	tolerations = k8sutil.AddTolerationIfNotFound(tolerations, k8sutil.NewNoExecuteToleration(k8sutil.TolerationKeyNodeAlphaUnreachable, shortDur))
 	serviceAccountName := ""
 
-	if err := k8sutil.CreateArangodPod(ib.KubeCli, true, ib.APIObject, role, id, podName, "", image, "", ib.Spec.GetImagePullPolicy(), "", false, terminationGracePeriod, args, nil, nil, nil, nil,
+	if err := k8sutil.CreateArangodPod(ib.KubeCli, true, ib.APIObject, role, id, podName, "", image, "", "", ib.Spec.GetImagePullPolicy(), "", false, terminationGracePeriod, args, nil, nil, nil, nil,
 		tolerations, serviceAccountName, "", ""); err != nil {
 		log.Debug().Err(err).Msg("Failed to create image ID pod")
 		return true, maskAny(err)

pkg/deployment/images.go

@@ -60,6 +60,8 @@ type Context interface {
 	GetKubeCli() kubernetes.Interface
 	// GetLifecycleImage returns the image name containing the lifecycle helper (== name of operator image)
 	GetLifecycleImage() string
+	// GetAlpineImage returns the image name containing the alpine environment
+	GetAlpineImage() string
 	// GetNamespace returns the namespace that contains the deployment
 	GetNamespace() string
 	// CreateEvent creates a given event.

pkg/deployment/resources/context.go

@@ -448,6 +448,7 @@ func (r *Resources) createPodForMember(spec api.DeploymentSpec, memberID string,
 	}
 	groupSpec := spec.GetServerGroupSpec(group)
 	lifecycleImage := r.context.GetLifecycleImage()
+	alpineImage := r.context.GetAlpineImage()
 	terminationGracePeriod := group.DefaultTerminationGracePeriod()
 	tolerations := r.createPodTolerations(group, groupSpec)
 	serviceAccountName := groupSpec.GetServiceAccountName()
@@ -514,7 +515,7 @@ func (r *Resources) createPodForMember(spec api.DeploymentSpec, memberID string,
 		engine := spec.GetStorageEngine().AsArangoArgument()
 		requireUUID := group == api.ServerGroupDBServers && m.IsInitialized
 		finalizers := r.createPodFinalizers(group)
-		if err := k8sutil.CreateArangodPod(kubecli, spec.IsDevelopment(), apiObject, role, m.ID, m.PodName, m.PersistentVolumeClaimName, imageInfo.ImageID, lifecycleImage, spec.GetImagePullPolicy(),
+		if err := k8sutil.CreateArangodPod(kubecli, spec.IsDevelopment(), apiObject, role, m.ID, m.PodName, m.PersistentVolumeClaimName, imageInfo.ImageID, lifecycleImage, alpineImage, spec.GetImagePullPolicy(),
 			engine, requireUUID, terminationGracePeriod, args, env, finalizers, livenessProbe, readinessProbe, tolerations, serviceAccountName, tlsKeyfileSecretName, rocksdbEncryptionSecretName); err != nil {
 			return maskAny(err)
 		}

pkg/deployment/resources/pod_creator.go

@@ -56,6 +56,44 @@ func (d *Deployment) Environment() api.Environment {
 	return d.GetSpec().GetEnvironment()
 }
 
+// StateColor determinates the state of the deployment in color codes.
+func (d *Deployment) StateColor() server.StateColor {
+	allGood := true
+	deploymentAvailable := true
+	failed := false
+	if d.PodCount() != d.ReadyPodCount() {
+		allGood = false
+	}
+	if d.VolumeCount() != d.ReadyVolumeCount() {
+		allGood = false
+	}
+	status, _ := d.GetStatus()
+	status.Members.ForeachServerGroup(func(group api.ServerGroup, list api.MemberStatusList) error {
+		for _, m := range list {
+			switch m.Phase {
+			case api.MemberPhaseFailed:
+				failed = true
+			case api.MemberPhaseCreated:
+				// Should be ok now
+			default:
+				// Something is going on
+				allGood = true
+			}
+		}
+		return nil
+	})
+	if failed {
+		return server.StateRed
+	}
+	if !deploymentAvailable {
+		return server.StateOrange
+	}
+	if !allGood {
+		return server.StateYellow
+	}
+	return server.StateGreen
+}
+
 // PodCount returns the number of pods for the deployment
 func (d *Deployment) PodCount() int {
 	count := 0

pkg/deployment/server_api.go

@@ -71,6 +71,7 @@ type Config struct {
 	PodName                     string
 	ServiceAccount              string
 	LifecycleImage              string
+	AlpineImage                 string
 	EnableDeployment            bool
 	EnableDeploymentReplication bool
 	EnableStorage               bool