Added placeholder checks for headers and fixed VST issue.

Author: Dan Larkin-York

tests/load_balancer_test.go

@@ -197,7 +197,7 @@ func LoadBalancingCursorSubtest(t *testing.T, useVst bool) {
 
 	// keep track of whether at least one request was forwarded internally to the
 	// correct coordinator behind the load balancer
-	someRequestForwarded = false
+	someRequestForwarded := false
 
 	// Run tests for every context alternative
 	for _, qctx := range contexts {
@@ -239,6 +239,8 @@ func LoadBalancingCursorSubtest(t *testing.T, useVst bool) {
 						t.Error("HasMore returned false, but ReadDocument returns a document")
 					}
 					result = append(result, doc.Elem().Interface())
+					// TODO extract `x-arango-request-served-by` header
+					// if header exists, set someRequestForwarded = true
 				}
 				if len(result) != len(test.ExpectedDocuments) {
 					t.Errorf("Expected %d documents, got %d in query %d (%s)", len(test.ExpectedDocuments), len(result), i, test.Query)
@@ -261,4 +263,8 @@ func LoadBalancingCursorSubtest(t *testing.T, useVst bool) {
 			}
 		}
 	}
+
+	if !someRequestForwarded {
+		t.Error("Did not detect any request being forwarded behind load balancer!")
+	}
 }

tests/test_util.go

@@ -97,10 +97,10 @@ func createArangodVSTClientForDNSName(ctx context.Context, cli corev1.CoreV1Inte
 // createArangodVSTConfigForDNSNames creates a go-driver VST connection config for a given DNS names.
 func createArangodVSTConfigForDNSNames(ctx context.Context, cli corev1.CoreV1Interface, apiObject *api.ArangoDeployment, dnsNames []string) (vst.ConnectionConfig, error) {
 	scheme := "http"
-	tlsConfig := &tls.Config{InsecureSkipVerify: true}
+	tlsConfig := &tls.Config{}
 	if apiObject != nil && apiObject.Spec.IsSecure() {
 		scheme = "https"
-		tlsConfig = &tls.Config{}
+		tlsConfig = &tls.Config{InsecureSkipVerify: true}
 	}
 	transport := vstProtocol.TransportConfig{
 		Version: vstProtocol.Version1_1,