[Improvement] Deprecate Endpoint field in ArangoDeployment (#1293)

Author: jwierzbo

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [master](https://github.com/arangodb/kube-arangodb/tree/master) (N/A)
 - (Bugfix) Fix manual overwrite for ReplicasCount in helm
 - (Bugfix) Fix for ArangoTask list error
+- (Improvement) Deprecate Endpoint field in ArangoDeployment
 
 ## [1.2.25](https://github.com/arangodb/kube-arangodb/tree/1.2.25) (2023-04-07)
 - (Feature) Add Generics & Drop policy/v1beta1 support

pkg/apis/deployment/v1/arango_member_pod_template.go

@@ -52,6 +52,7 @@ type ArangoMemberPodTemplate struct {
 	PodSpecChecksum string                `json:"podSpecChecksum,omitempty"`
 	Checksum        string                `json:"checksum,omitempty"`
 
+	// deprecated
 	Endpoint *string `json:"endpoint,omitempty"`
 }
 

pkg/apis/deployment/v1/member_status.go

@@ -73,8 +73,7 @@ type MemberStatus struct {
 	Architecture *ArangoDeploymentArchitectureType `json:"architecture,omitempty"`
 	// Upgrade define if upgrade should be enforced during next execution
 	Upgrade bool `json:"upgrade,omitempty"`
-	// Endpoint definition how member should be reachable
-	Endpoint *string `json:"endpoint,omitempty"`
+
 	// Topology define topology member status assignment
 	Topology     *TopologyMemberStatus `json:"topology,omitempty"`
 	Pod          *MemberPodStatus      `json:"pod,omitempty"`
@@ -101,6 +100,9 @@ type MemberStatus struct {
 	// deprecated
 	// PersistentVolumeClaimName holds the name of the persistent volume claim used for this member (if any).
 	PersistentVolumeClaimName string `json:"persistentVolumeClaimName,omitempty"`
+	// deprecated
+	// Endpoint definition how member should be reachable
+	Endpoint *string `json:"-"`
 }
 
 // Equal checks for equality
@@ -152,6 +154,7 @@ func (s *MemberStatus) RemoveTerminationsBefore(timestamp time.Time) int {
 	}
 }
 
+// deprecated
 func (s *MemberStatus) GetEndpoint(defaultEndpoint string) string {
 	if s == nil || s.Endpoint == nil {
 		return defaultEndpoint

pkg/apis/deployment/v1/zz_generated.deepcopy.go

@@ -52,6 +52,7 @@ type ArangoMemberPodTemplate struct {
 	PodSpecChecksum string                `json:"podSpecChecksum,omitempty"`
 	Checksum        string                `json:"checksum,omitempty"`
 
+	// deprecated
 	Endpoint *string `json:"endpoint,omitempty"`
 }
 

pkg/apis/deployment/v2alpha1/arango_member_pod_template.go

@@ -73,8 +73,7 @@ type MemberStatus struct {
 	Architecture *ArangoDeploymentArchitectureType `json:"architecture,omitempty"`
 	// Upgrade define if upgrade should be enforced during next execution
 	Upgrade bool `json:"upgrade,omitempty"`
-	// Endpoint definition how member should be reachable
-	Endpoint *string `json:"endpoint,omitempty"`
+
 	// Topology define topology member status assignment
 	Topology     *TopologyMemberStatus `json:"topology,omitempty"`
 	Pod          *MemberPodStatus      `json:"pod,omitempty"`
@@ -101,6 +100,9 @@ type MemberStatus struct {
 	// deprecated
 	// PersistentVolumeClaimName holds the name of the persistent volume claim used for this member (if any).
 	PersistentVolumeClaimName string `json:"persistentVolumeClaimName,omitempty"`
+	// deprecated
+	// Endpoint definition how member should be reachable
+	Endpoint *string `json:"-"`
 }
 
 // Equal checks for equality
@@ -152,6 +154,7 @@ func (s *MemberStatus) RemoveTerminationsBefore(timestamp time.Time) int {
 	}
 }
 
+// deprecated
 func (s *MemberStatus) GetEndpoint(defaultEndpoint string) string {
 	if s == nil || s.Endpoint == nil {
 		return defaultEndpoint