Skip to content

Commit 39638b1

Browse files
ajanikowajanikow
authored
[Feature] Remove ImagePullSecrets Reference from Container (#1629)
1 parent 0fc7878 commit 39638b1

File tree

10 files changed

+32
-153
lines changed

10 files changed

+32
-153
lines changed

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
- (Feature) Expose Force CRD Install option
1111
- (Maintenance) Move Container utils functions
1212
- (Feature) ArangoProfile Selectors
13+
- (Bugfix) Remove ImagePullSecrets Reference from Container
1314

1415
## [1.2.39](https://github.com/arangodb/kube-arangodb/tree/1.2.39) (2024-03-11)
1516
- (Feature) Extract Scheduler API

‎docs/api/ArangoMLExtension.V1Alpha1.md‎

Lines changed: 27 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -193,30 +193,22 @@ Default Value: `false`
193193

194194
### .spec.deployment.prediction.image
195195

196-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
196+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
197197

198198
Image define image details
199199

200200
***
201201

202202
### .spec.deployment.prediction.imagePullPolicy
203203

204-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
204+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
205205

206206
ImagePullPolicy define Image pull policy
207207

208208
Default Value: `IfNotPresent`
209209

210210
***
211211

212-
### .spec.deployment.prediction.imagePullSecrets
213-
214-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
215-
216-
ImagePullSecrets define Secrets used to pull Image from registry
217-
218-
***
219-
220212
### .spec.deployment.prediction.lifecycle
221213

222214
Type: `core.Lifecycle` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/lifecycle.go#L35)</sup>
@@ -391,30 +383,22 @@ Default Value: `false`
391383

392384
### .spec.deployment.project.image
393385

394-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
386+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
395387

396388
Image define image details
397389

398390
***
399391

400392
### .spec.deployment.project.imagePullPolicy
401393

402-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
394+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
403395

404396
ImagePullPolicy define Image pull policy
405397

406398
Default Value: `IfNotPresent`
407399

408400
***
409401

410-
### .spec.deployment.project.imagePullSecrets
411-
412-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
413-
414-
ImagePullSecrets define Secrets used to pull Image from registry
415-
416-
***
417-
418402
### .spec.deployment.project.lifecycle
419403

420404
Type: `core.Lifecycle` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/lifecycle.go#L35)</sup>
@@ -662,30 +646,22 @@ Default Value: `false`
662646

663647
### .spec.deployment.training.image
664648

665-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
649+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
666650

667651
Image define image details
668652

669653
***
670654

671655
### .spec.deployment.training.imagePullPolicy
672656

673-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
657+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
674658

675659
ImagePullPolicy define Image pull policy
676660

677661
Default Value: `IfNotPresent`
678662

679663
***
680664

681-
### .spec.deployment.training.imagePullSecrets
682-
683-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
684-
685-
ImagePullSecrets define Secrets used to pull Image from registry
686-
687-
***
688-
689665
### .spec.deployment.training.lifecycle
690666

691667
Type: `core.Lifecycle` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/lifecycle.go#L35)</sup>
@@ -924,15 +900,15 @@ Default Value: `false`
924900

925901
### .spec.init.image
926902

927-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
903+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
928904

929905
Image define image details
930906

931907
***
932908

933909
### .spec.init.imagePullPolicy
934910

935-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
911+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
936912

937913
ImagePullPolicy define Image pull policy
938914

@@ -942,7 +918,7 @@ Default Value: `IfNotPresent`
942918

943919
### .spec.init.imagePullSecrets
944920

945-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
921+
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/pod/resources/image.go#L36)</sup>
946922

947923
ImagePullSecrets define Secrets used to pull Image from registry
948924

@@ -1270,15 +1246,15 @@ Default Value: `false`
12701246

12711247
### .spec.jobsTemplates.featurization.cpu.image
12721248

1273-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
1249+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
12741250

12751251
Image define image details
12761252

12771253
***
12781254

12791255
### .spec.jobsTemplates.featurization.cpu.imagePullPolicy
12801256

1281-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
1257+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
12821258

12831259
ImagePullPolicy define Image pull policy
12841260

@@ -1288,7 +1264,7 @@ Default Value: `IfNotPresent`
12881264

12891265
### .spec.jobsTemplates.featurization.cpu.imagePullSecrets
12901266

1291-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
1267+
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/pod/resources/image.go#L36)</sup>
12921268

12931269
ImagePullSecrets define Secrets used to pull Image from registry
12941270

@@ -1616,15 +1592,15 @@ Default Value: `false`
16161592

16171593
### .spec.jobsTemplates.featurization.gpu.image
16181594

1619-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
1595+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
16201596

16211597
Image define image details
16221598

16231599
***
16241600

16251601
### .spec.jobsTemplates.featurization.gpu.imagePullPolicy
16261602

1627-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
1603+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
16281604

16291605
ImagePullPolicy define Image pull policy
16301606

@@ -1634,7 +1610,7 @@ Default Value: `IfNotPresent`
16341610

16351611
### .spec.jobsTemplates.featurization.gpu.imagePullSecrets
16361612

1637-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
1613+
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/pod/resources/image.go#L36)</sup>
16381614

16391615
ImagePullSecrets define Secrets used to pull Image from registry
16401616

@@ -1962,15 +1938,15 @@ Default Value: `false`
19621938

19631939
### .spec.jobsTemplates.prediction.cpu.image
19641940

1965-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
1941+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
19661942

19671943
Image define image details
19681944

19691945
***
19701946

19711947
### .spec.jobsTemplates.prediction.cpu.imagePullPolicy
19721948

1973-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
1949+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
19741950

19751951
ImagePullPolicy define Image pull policy
19761952

@@ -1980,7 +1956,7 @@ Default Value: `IfNotPresent`
19801956

19811957
### .spec.jobsTemplates.prediction.cpu.imagePullSecrets
19821958

1983-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
1959+
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/pod/resources/image.go#L36)</sup>
19841960

19851961
ImagePullSecrets define Secrets used to pull Image from registry
19861962

@@ -2308,15 +2284,15 @@ Default Value: `false`
23082284

23092285
### .spec.jobsTemplates.prediction.gpu.image
23102286

2311-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
2287+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
23122288

23132289
Image define image details
23142290

23152291
***
23162292

23172293
### .spec.jobsTemplates.prediction.gpu.imagePullPolicy
23182294

2319-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
2295+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
23202296

23212297
ImagePullPolicy define Image pull policy
23222298

@@ -2326,7 +2302,7 @@ Default Value: `IfNotPresent`
23262302

23272303
### .spec.jobsTemplates.prediction.gpu.imagePullSecrets
23282304

2329-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
2305+
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/pod/resources/image.go#L36)</sup>
23302306

23312307
ImagePullSecrets define Secrets used to pull Image from registry
23322308

@@ -2654,15 +2630,15 @@ Default Value: `false`
26542630

26552631
### .spec.jobsTemplates.training.cpu.image
26562632

2657-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
2633+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
26582634

26592635
Image define image details
26602636

26612637
***
26622638

26632639
### .spec.jobsTemplates.training.cpu.imagePullPolicy
26642640

2665-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
2641+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
26662642

26672643
ImagePullPolicy define Image pull policy
26682644

@@ -2672,7 +2648,7 @@ Default Value: `IfNotPresent`
26722648

26732649
### .spec.jobsTemplates.training.cpu.imagePullSecrets
26742650

2675-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
2651+
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/pod/resources/image.go#L36)</sup>
26762652

26772653
ImagePullSecrets define Secrets used to pull Image from registry
26782654

@@ -3000,15 +2976,15 @@ Default Value: `false`
30002976

30012977
### .spec.jobsTemplates.training.gpu.image
30022978

3003-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
2979+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
30042980

30052981
Image define image details
30062982

30072983
***
30082984

30092985
### .spec.jobsTemplates.training.gpu.imagePullPolicy
30102986

3011-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
2987+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
30122988

30132989
ImagePullPolicy define Image pull policy
30142990

@@ -3018,7 +2994,7 @@ Default Value: `IfNotPresent`
30182994

30192995
### .spec.jobsTemplates.training.gpu.imagePullSecrets
30202996

3021-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
2997+
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/pod/resources/image.go#L36)</sup>
30222998

30232999
ImagePullSecrets define Secrets used to pull Image from registry
30243000

‎docs/api/ArangoMLStorage.V1Alpha1.md‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -172,30 +172,22 @@ Links:
172172

173173
### .spec.mode.sidecar.image
174174

175-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
175+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
176176

177177
Image define image details
178178

179179
***
180180

181181
### .spec.mode.sidecar.imagePullPolicy
182182

183-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
183+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
184184

185185
ImagePullPolicy define Image pull policy
186186

187187
Default Value: `IfNotPresent`
188188

189189
***
190190

191-
### .spec.mode.sidecar.imagePullSecrets
192-
193-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
194-
195-
ImagePullSecrets define Secrets used to pull Image from registry
196-
197-
***
198-
199191
### .spec.mode.sidecar.lifecycle
200192

201193
Type: `core.Lifecycle` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/lifecycle.go#L35)</sup>

‎docs/api/ArangoProfile.V1Alpha1.md‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,30 +104,22 @@ Links:
104104

105105
### .spec.template.container.containers.\<string\>.image
106106

107-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L37)</sup>
107+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L35)</sup>
108108

109109
Image define image details
110110

111111
***
112112

113113
### .spec.template.container.containers.\<string\>.imagePullPolicy
114114

115-
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L41)</sup>
115+
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L39)</sup>
116116

117117
ImagePullPolicy define Image pull policy
118118

119119
Default Value: `IfNotPresent`
120120

121121
***
122122

123-
### .spec.template.container.containers.\<string\>.imagePullSecrets
124-
125-
Type: `array` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/image.go#L44)</sup>
126-
127-
ImagePullSecrets define Secrets used to pull Image from registry
128-
129-
***
130-
131123
### .spec.template.container.containers.\<string\>.lifecycle
132124

133125
Type: `core.Lifecycle` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.39/pkg/apis/scheduler/v1alpha1/container/resources/lifecycle.go#L35)</sup>

0 commit comments

Comments
 (0)