Added event when pvc is resized. Added log if the user tries to shrink a volume.

Author: lamai93

pkg/deployment/resources/pvc_inspector.go

@@ -85,16 +85,21 @@ func (r *Resources) InspectPVCs(ctx context.Context) (util.Interval, error) {
 		groupSpec := spec.GetServerGroupSpec(group)
 		if requestedSize, ok := groupSpec.Resources.Requests[apiv1.ResourceStorage]; ok {
 			if volumeSize, ok := p.Spec.Resources.Requests[apiv1.ResourceStorage]; ok {
-				if volumeSize.Cmp(requestedSize) < 0 {
+				cmp := volumeSize.Cmp(requestedSize)
+				if cmp < 0 {
 					// Size of the volume is smaller than the requested size
 					// Update the pvc with the request size
 					p.Spec.Resources.Requests[apiv1.ResourceStorage] = requestedSize
 
-					log.Debug().Str("pvc-capacity", volumeSize.String()).Str("requested", requestedSize.String()).Msg("PVC capacity differes - updating")
+					log.Debug().Str("pvc-capacity", volumeSize.String()).Str("requested", requestedSize.String()).Msg("PVC capacity differs - updating")
 					kube := r.context.GetKubeCli()
 					if _, err := kube.CoreV1().PersistentVolumeClaims(r.context.GetNamespace()).Update(&p); err != nil {
 						log.Error().Err(err).Msg("Failed to update pvc")
 					}
+					r.context.CreateEvent(k8sutil.NewPVCResizedEvent(r.context.GetAPIObject(), p.Name))
+				} else if cmp > 0 {
+					log.Error().Str("server-group", group.AsRole()).Str("pvc-storage-size", volumeSize.String()).Str("requested-size", requestedSize.String()).
+						Msg("Volume size should not shrink")
 				}
 			}
 		}

pkg/util/k8sutil/events.go

@@ -193,6 +193,15 @@ func NewDowntimeNotAllowedEvent(apiObject APIObject, operation string) *Event {
 	return event
 }
 
+// NewPVCResizedEvent creates an event indicating that a PVC has been resized
+func NewPVCResizedEvent(apiObject APIObject, pvcname string) *Event {
+	event := newDeploymentEvent(apiObject)
+	event.Type = v1.EventTypeNormal
+	event.Reason = "PVC Resized"
+	event.Message = fmt.Sprintf("The persistent volume claim %s has been resized", pvcname)
+	return event
+}
+
 // NewUpgradeNotAllowedEvent creates an event indicating that an upgrade (or downgrade) is not allowed.
 func NewUpgradeNotAllowedEvent(apiObject APIObject,
 	fromVersion, toVersion driver.Version,