Sort members by ID

ewoutp · ewoutp · commit 01cbcae5a828 · 2018-08-30T11:16:34.000+02:00
diff --git a/pkg/apis/deployment/v1alpha/member_status_list.go b/pkg/apis/deployment/v1alpha/member_status_list.go
@@ -24,6 +24,7 @@ package v1alpha
 
 import (
 	"math/rand"
+	"sort"
 
 	"github.com/pkg/errors"
 )
@@ -83,7 +84,9 @@ func (l *MemberStatusList) add(m MemberStatus) error {
 			return maskAny(errors.Wrapf(AlreadyExistsError, "Member '%s' already exists", m.ID))
 		}
 	}
-	*l = append(src, m)
+	newList := append(src, m)
+	sort.Slice(newList, func(i, j int) bool { return newList[i].ID < newList[j].ID })
+	*l = newList
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ package v1alpha`
`24`	`24`
`25`	`25`	`import (`
`26`	`26`	`"math/rand"`
	`27`	`+ "sort"`
`27`	`28`
`28`	`29`	`"github.com/pkg/errors"`
`29`	`30`	`)`
`@@ -83,7 +84,9 @@ func (l *MemberStatusList) add(m MemberStatus) error {`
`83`	`84`	`return maskAny(errors.Wrapf(AlreadyExistsError, "Member '%s' already exists", m.ID))`
`84`	`85`	`}`
`85`	`86`	`}`
`86`		`- *l = append(src, m)`
	`87`	`+ newList := append(src, m)`
	`88`	`+ sort.Slice(newList, func(i, j int) bool { return newList[i].ID < newList[j].ID })`
	`89`	`+ *l = newList`
`87`	`90`	`return nil`
`88`	`91`	`}`
`89`	`92`