feat: implement GenerateSigningMessage trait for RawTransaction and RawTransactionWithData

Author: WGB5445

crates/aptos-rust-sdk-types/src/api_types/transaction.rs

@@ -7,9 +7,16 @@ use crate::api_types::numbers::U64;
 use crate::api_types::transaction_authenticator::TransactionAuthenticator;
 use crate::api_types::type_tag::TypeTag;
 use crate::api_types::write_set::WriteSet;
+use anyhow::Error;
+use aptos_crypto::compat::Sha3_256;
 use aptos_crypto_derive::{BCSCryptoHash, CryptoHasher};
+use ed25519_dalek::Digest;
 use serde::{Deserialize, Serialize};
 
+pub trait GenerateSigningMessage {
+    fn generate_signing_message(&self) -> Result<Vec<u8>, Error>;
+}
+
 #[derive(Clone, Debug, Deserialize, Eq, PartialEq, Serialize)]
 pub enum TransactionData {
     /// A committed transaction
@@ -235,6 +242,20 @@ impl RawTransactionWithData {
     }
 }
 
+impl GenerateSigningMessage for RawTransactionWithData {
+    fn generate_signing_message(&self) -> Result<Vec<u8>, anyhow::Error> {
+        let mut sha3 = Sha3_256::new();
+        sha3.update("APTOS::RawTransactionWithData".as_bytes());
+        let hash = sha3.finalize().to_vec();
+        let mut bytes = vec![];
+        bcs::serialize_into(&mut bytes, &self)?;
+        let mut message = vec![];
+        message.extend(hash);
+        message.extend(bytes);
+        Ok(message)
+    }   
+}
+
 impl SignedTransaction {
     pub fn new(raw_txn: RawTransaction, authenticator: TransactionAuthenticator) -> Self {
         Self {
@@ -286,6 +307,21 @@ impl RawTransaction {
     }
 }
 
+impl GenerateSigningMessage for RawTransaction {
+    fn generate_signing_message(&self) -> Result<Vec<u8>, anyhow::Error> {
+        let mut sha3 = Sha3_256::new();
+        sha3.update("APTOS::RawTransaction".as_bytes());
+        let hash = sha3.finalize().to_vec();
+        let mut bytes = vec![];
+        bcs::serialize_into(&mut bytes, &self)?;
+        let mut message = vec![];
+        message.extend(hash);
+        message.extend(bytes);
+        Ok(message)
+    }
+    
+}
+
 impl EntryFunction {
     pub fn new(
         module: ModuleId,

crates/examples/src/lib.rs

@@ -1,6 +1,5 @@
 #[cfg(test)]
 mod tests {
-    use aptos_crypto::compat::Sha3_256;
     use aptos_crypto::ed25519::{Ed25519PrivateKey, Ed25519PublicKey};
     use aptos_crypto::Uniform;
     use aptos_rust_sdk::client::builder::AptosClientBuilder;
@@ -9,13 +8,12 @@ mod tests {
     use aptos_rust_sdk_types::api_types::chain_id::ChainId;
     use aptos_rust_sdk_types::api_types::module_id::ModuleId;
     use aptos_rust_sdk_types::api_types::transaction::{
-        EntryFunction, RawTransaction, RawTransactionWithData, SignedTransaction,
-        TransactionPayload,
+        EntryFunction, GenerateSigningMessage, RawTransaction, RawTransactionWithData,
+        SignedTransaction, TransactionPayload,
     };
     use aptos_rust_sdk_types::api_types::transaction_authenticator::{
         AccountAuthenticator, AuthenticationKey, TransactionAuthenticator,
     };
-    use ed25519_dalek::Digest;
     use std::str::FromStr;
     use std::vec;
 
@@ -73,14 +71,7 @@ mod tests {
             chain_id,
         );
 
-        let mut sha3 = Sha3_256::new();
-        sha3.update("APTOS::RawTransaction".as_bytes());
-        let hash = sha3.finalize().to_vec();
-        let mut bytes = vec![];
-        bcs::serialize_into(&mut bytes, &raw_txn).unwrap();
-        let mut message = vec![];
-        message.extend(hash);
-        message.extend(bytes);
+        let message = raw_txn.generate_signing_message().unwrap();
 
         let signature = key.sign_message(&message);
 
@@ -159,14 +150,7 @@ mod tests {
             fee_payer_address,
         );
 
-        let mut sha3 = Sha3_256::new();
-        sha3.update("APTOS::RawTransactionWithData".as_bytes());
-        let hash = sha3.finalize().to_vec();
-        let mut bytes = vec![];
-        bcs::serialize_into(&mut bytes, &raw_txn_with_data).unwrap();
-        let mut message = vec![];
-        message.extend(hash);
-        message.extend(bytes);
+        let message = raw_txn_with_data.generate_signing_message().unwrap();
 
         let txn_sender_signature = txn_sender_key.sign_message(&message);